public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug libstdc++/114680] New: libstdc++-v3/include/ext/mt_allocator.h:142: possible performance problem ?
@ 2024-04-10 18:09 dcb314 at hotmail dot com
  2024-04-10 18:55 ` [Bug libstdc++/114680] " redi at gcc dot gnu.org
  2024-04-10 19:04 ` redi at gcc dot gnu.org
  0 siblings, 2 replies; 3+ messages in thread
From: dcb314 at hotmail dot com @ 2024-04-10 18:09 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114680

            Bug ID: 114680
           Summary: libstdc++-v3/include/ext/mt_allocator.h:142: possible
                    performance problem ?
           Product: gcc
           Version: 14.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: libstdc++
          Assignee: unassigned at gcc dot gnu.org
          Reporter: dcb314 at hotmail dot com
  Target Milestone: ---

Static analyser cppcheck says:

libstdc++-v3/include/ext/mt_allocator.h:142:26: performance: Function parameter
'__t' should be passed by const reference. [passedByValue]

Source code is

    _M_set_options(_Tune __t)

AFAIK sizeof( _Tune) >= 6 * sizeof( size_t) + sizeof( bool), so it might
well be worthwhile to take the advice of the static analyser.

^ permalink raw reply	[flat|nested] 3+ messages in thread
* [Bug libstdc++/114680] libstdc++-v3/include/ext/mt_allocator.h:142: possible performance problem ?
  2024-04-10 18:09 [Bug libstdc++/114680] New: libstdc++-v3/include/ext/mt_allocator.h:142: possible performance problem ? dcb314 at hotmail dot com
@ 2024-04-10 18:55 ` redi at gcc dot gnu.org
  2024-04-10 19:04 ` redi at gcc dot gnu.org
  1 sibling, 0 replies; 3+ messages in thread
From: redi at gcc dot gnu.org @ 2024-04-10 18:55 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114680

--- Comment #1 from Jonathan Wakely <redi at gcc dot gnu.org> ---
I doubt anybody uses that code anyway.

^ permalink raw reply	[flat|nested] 3+ messages in thread
* [Bug libstdc++/114680] libstdc++-v3/include/ext/mt_allocator.h:142: possible performance problem ?
  2024-04-10 18:09 [Bug libstdc++/114680] New: libstdc++-v3/include/ext/mt_allocator.h:142: possible performance problem ? dcb314 at hotmail dot com
  2024-04-10 18:55 ` [Bug libstdc++/114680] " redi at gcc dot gnu.org
@ 2024-04-10 19:04 ` redi at gcc dot gnu.org
  1 sibling, 0 replies; 3+ messages in thread
From: redi at gcc dot gnu.org @ 2024-04-10 19:04 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114680

--- Comment #2 from Jonathan Wakely <redi at gcc dot gnu.org> ---
There's line 685 too

      void
      _M_set_options(__pool_base::_Tune __t)
      { __policy_type::_S_get_pool()._M_set_options(__t); }

^ permalink raw reply	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-04-10 19:04 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-04-10 18:09 [Bug libstdc++/114680] New: libstdc++-v3/include/ext/mt_allocator.h:142: possible performance problem ? dcb314 at hotmail dot com
2024-04-10 18:55 ` [Bug libstdc++/114680] " redi at gcc dot gnu.org
2024-04-10 19:04 ` redi at gcc dot gnu.org

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).