public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug libgcc/114689] [14 Regression] libgcc/config/m68k/fpgnulib.c:305: Suspicious coding ?
Date: Mon, 15 Apr 2024 15:46:37 +0000 [thread overview]
Message-ID: <bug-114689-4-TdN6eS3mqW@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-114689-4@http.gcc.gnu.org/bugzilla/>
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114689
--- Comment #7 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jakub Jelinek <jakub@gcc.gnu.org>:
https://gcc.gnu.org/g:f8409c3109d2970a1fd63ac1a61601138b7ae46f
commit r14-9976-gf8409c3109d2970a1fd63ac1a61601138b7ae46f
Author: Jakub Jelinek <jakub@redhat.com>
Date: Mon Apr 15 17:46:03 2024 +0200
m68k: Quiet up cppcheck warning [PR114689]
cppcheck apparently warns on the | !!sticky part of the expression and
using | (!!sticky) quiets it up (it is correct as is).
The following patch adds the ()s, and also adds them around mant >> 1 just
in case it makes it clearer to all readers that the expression is parsed
that way already.
2024-04-15 Jakub Jelinek <jakub@redhat.com>
PR libgcc/114689
* config/m68k/fpgnulib.c (__truncdfsf2): Add parentheses around
!!sticky bitwise or operand to quiet up cppcheck. Add parentheses
around mant >> 1 bitwise or operand.
next prev parent reply other threads:[~2024-04-15 15:46 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-11 9:00 [Bug libgcc/114689] New: " dcb314 at hotmail dot com
2024-04-11 10:35 ` [Bug libgcc/114689] " rguenth at gcc dot gnu.org
2024-04-12 8:30 ` jakub at gcc dot gnu.org
2024-04-12 10:13 ` schwab@linux-m68k.org
2024-04-12 10:16 ` jakub at gcc dot gnu.org
2024-04-12 13:33 ` law at gcc dot gnu.org
2024-04-12 21:47 ` dcb314 at hotmail dot com
2024-04-12 21:56 ` jakub at gcc dot gnu.org
2024-04-13 7:06 ` dcb314 at hotmail dot com
2024-04-15 15:46 ` cvs-commit at gcc dot gnu.org [this message]
2024-04-15 15:48 ` jakub at gcc dot gnu.org
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-114689-4-TdN6eS3mqW@http.gcc.gnu.org/bugzilla/ \
--to=gcc-bugzilla@gcc.gnu.org \
--cc=gcc-bugs@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).