[Bug sanitizer/114743] New: ICE in build_check_stmt at asan.cc:2707 while compiling gcc.dg/ubsan/pr112709-2.c with -fsanitize=address

[Bug sanitizer/114743] New: ICE in build_check_stmt at asan.cc:2707 while compiling gcc.dg/ubsan/pr112709-2.c with -fsanitize=address

[pheeck at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114743

            Bug ID: 114743
           Summary: ICE in build_check_stmt at asan.cc:2707 while
                    compiling gcc.dg/ubsan/pr112709-2.c with
                    -fsanitize=address
           Product: gcc
           Version: 14.0
            Status: UNCONFIRMED
          Keywords: ice-on-valid-code
          Severity: normal
          Priority: P3
         Component: sanitizer
          Assignee: unassigned at gcc dot gnu.org
          Reporter: pheeck at gcc dot gnu.org
                CC: dodji at gcc dot gnu.org, dvyukov at gcc dot gnu.org,
                    jakub at gcc dot gnu.org, kcc at gcc dot gnu.org
  Target Milestone: ---
              Host: x86_64-linux
            Target: aarch64-gnu-linux

Compiling the GCC testsuite testcase gcc.dg/ubsan/pr112709-2.c with
-fsanitize=address on an aarch64 cross compiler results in an ICE

aarch64-linux-gnu-gcc gcc.dg/ubsan/pr112709-2.c -fsanitize=address

during GIMPLE pass: asan0
/home/worker/buildworker/tiber-option-juggler/build/gcc/testsuite/gcc.dg/ubsan/pr112709-2.c:
In function ‘freddy’:
/home/worker/buildworker/tiber-option-juggler/build/gcc/testsuite/gcc.dg/ubsan/pr112709-2.c:53:1:
internal compiler error: Segmentation fault
   53 | freddy (int x, int *y, struct S *p)
      | ^~~~~~
0xd9dc7f crash_signal
       
/home/worker/buildworker/tiber-gcc-trunk-aarch64/build/gcc/toplev.cc:319
0xa7b205 edge_before_returns_twice_call
       
/home/worker/buildworker/tiber-gcc-trunk-aarch64/build/gcc/gimple-iterator.cc:987
0xa7bee7 gsi_safe_insert_before(gimple_stmt_iterator*, gimple*)
       
/home/worker/buildworker/tiber-gcc-trunk-aarch64/build/gcc/gimple-iterator.cc:1055
0xdb514b build_check_stmt
        /home/worker/buildworker/tiber-gcc-trunk-aarch64/build/gcc/asan.cc:2707
0xdb72b7 instrument_derefs
        /home/worker/buildworker/tiber-gcc-trunk-aarch64/build/gcc/asan.cc:2830
0xdb8173 maybe_instrument_call
        /home/worker/buildworker/tiber-gcc-trunk-aarch64/build/gcc/asan.cc:3083
0xdb8173 transform_statements
        /home/worker/buildworker/tiber-gcc-trunk-aarch64/build/gcc/asan.cc:3138
0xdb838b asan_instrument
        /home/worker/buildworker/tiber-gcc-trunk-aarch64/build/gcc/asan.cc:4282
0xdb838b execute
        /home/worker/buildworker/tiber-gcc-trunk-aarch64/build/gcc/asan.cc:4323
Please submit a full bug report, with preprocessed source (by using
-freport-bug).
Please include the complete backtrace with any bug report.
See <https://gcc.gnu.org/bugs/> for instructions.


aarch64-linux-gnu-gcc -v

Using built-in specs.
COLLECT_GCC=/home/worker/cross/bin/aarch64-linux-gnu-gcc
COLLECT_LTO_WRAPPER=/home/worker/cross/libexec/gcc/aarch64-linux-gnu/14.0.1/lto-wrapper
Target: aarch64-linux-gnu
Configured with:
/home/worker/buildworker/tiber-gcc-trunk-aarch64/build/configure
--enable-languages=c,c++,fortran,rust,m2 --disable-bootstrap
--disable-libsanitizer --disable-multilib --enable-checking=release
--prefix=/home/worker/cross --target=aarch64-linux-gnu
--with-as=/usr/bin/aarch64-suse-linux-as
Thread model: posix
Supported LTO compression algorithms: zlib zstd
gcc version 14.0.1 20240414 (experimental)
62a0ef0d02cbb74cd865c1db2ecb7ca1b11f87cd (GCC)

[Bug sanitizer/114743] ICE in build_check_stmt at asan.cc:2707 while compiling gcc.dg/ubsan/pr112709-2.c with -fsanitize=address

[pheeck at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114743

Filip Kastl <pheeck at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |14.0

[Bug sanitizer/114743] ICE in build_check_stmt at asan.cc:2707 while compiling gcc.dg/ubsan/pr112709-2.c with -fsanitize=address

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114743

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
     Ever confirmed|0                           |1
           Assignee|unassigned at gcc dot gnu.org      |jakub at gcc dot gnu.org
   Last reconfirmed|                            |2024-04-16
             Status|UNCONFIRMED                 |ASSIGNED

--- Comment #1 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Created attachment 57962
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=57962&action=edit
gcc14-pr114743.patch

Untested fix.

[Bug sanitizer/114743] ICE in build_check_stmt at asan.cc:2707 while compiling gcc.dg/ubsan/pr112709-2.c with -fsanitize=address

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114743

--- Comment #2 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jakub Jelinek <jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:299d14a54672a4d12c1abbe4031a732bb56cddaa

commit r14-10000-g299d14a54672a4d12c1abbe4031a732bb56cddaa
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Wed Apr 17 10:24:18 2024 +0200

    asan: Don't instrument .ABNORMAL_DISPATCHER [PR114743]

    .ABNORMAL_DISPATCHER is currently the only internal function with
    ECF_NORETURN, and asan likes to instrument ECF_NORETURN calls by adding
    some builtin call before them, which breaks the .ABNORMAL_DISPATCHER
    discovery added in gsi_safe_*.

    The following patch fixes asan not to instrument .ABNORMAL_DISPATCHER
    calls, like it doesn't instrument a couple of specific builtin calls
    as well.

    2024-04-17  Jakub Jelinek  <jakub@redhat.com>

            PR sanitizer/114743
            * asan.cc (maybe_instrument_call): Don't instrument calls to
            .ABNORMAL_DISPATCHER.

            * gcc.dg/asan/pr112709-2.c (freddy): New function from
            gcc.dg/ubsan/pr112709-2.c version of the test.

[Bug sanitizer/114743] ICE in build_check_stmt at asan.cc:2707 while compiling gcc.dg/ubsan/pr112709-2.c with -fsanitize=address

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114743

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #3 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Fixed.

[Bug sanitizer/114743] ICE in build_check_stmt at asan.cc:2707 while compiling gcc.dg/ubsan/pr112709-2.c with -fsanitize=address

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114743

--- Comment #4 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-13 branch has been updated by Jakub Jelinek
<jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:cd8e2137462d9ae1723fa193b6062ec65d164457

commit r13-8634-gcd8e2137462d9ae1723fa193b6062ec65d164457
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Wed Apr 17 10:24:18 2024 +0200

    asan: Don't instrument .ABNORMAL_DISPATCHER [PR114743]

    .ABNORMAL_DISPATCHER is currently the only internal function with
    ECF_NORETURN, and asan likes to instrument ECF_NORETURN calls by adding
    some builtin call before them, which breaks the .ABNORMAL_DISPATCHER
    discovery added in gsi_safe_*.

    The following patch fixes asan not to instrument .ABNORMAL_DISPATCHER
    calls, like it doesn't instrument a couple of specific builtin calls
    as well.

    2024-04-17  Jakub Jelinek  <jakub@redhat.com>

            PR sanitizer/114743
            * asan.cc (maybe_instrument_call): Don't instrument calls to
            .ABNORMAL_DISPATCHER.

            * gcc.dg/asan/pr112709-2.c (freddy): New function from
            gcc.dg/ubsan/pr112709-2.c version of the test.

    (cherry picked from commit 299d14a54672a4d12c1abbe4031a732bb56cddaa)

[Bug sanitizer/114743] ICE in build_check_stmt at asan.cc:2707 while compiling gcc.dg/ubsan/pr112709-2.c with -fsanitize=address

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114743

--- Comment #5 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Fixed for 13.3 too.