public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
* [Bug tree-optimization/114785] New: special handling of COND_EXPR in gimple_extract can be removed
@ 2024-04-20 0:38 pinskia at gcc dot gnu.org
2024-04-20 0:38 ` [Bug tree-optimization/114785] " pinskia at gcc dot gnu.org
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: pinskia at gcc dot gnu.org @ 2024-04-20 0:38 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114785
Bug ID: 114785
Summary: special handling of COND_EXPR in gimple_extract can be
removed
Product: gcc
Version: 14.0
Status: UNCONFIRMED
Keywords: internal-improvement
Severity: enhancement
Priority: P3
Component: tree-optimization
Assignee: unassigned at gcc dot gnu.org
Reporter: pinskia at gcc dot gnu.org
Target Milestone: ---
After r13-707-g68e0063397ba82, COND_EXPR for gimple assign no longer could
contain a comparison but the code in gimple_extract was not updated so the code
there is dead and no longer could happen.
Found while improving factor_out_conditional_operation in phi-opt to use
gimple_match_op to allow for calls and simplify some of the code there handling
VIEW_CONVERT_EXPR.
^ permalink raw reply [flat|nested] 4+ messages in thread* [Bug tree-optimization/114785] special handling of COND_EXPR in gimple_extract can be removed 2024-04-20 0:38 [Bug tree-optimization/114785] New: special handling of COND_EXPR in gimple_extract can be removed pinskia at gcc dot gnu.org @ 2024-04-20 0:38 ` pinskia at gcc dot gnu.org 2024-04-20 1:09 ` pinskia at gcc dot gnu.org 2024-04-22 19:19 ` rguenth at gcc dot gnu.org 2 siblings, 0 replies; 4+ messages in thread From: pinskia at gcc dot gnu.org @ 2024-04-20 0:38 UTC (permalink / raw) To: gcc-bugs https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114785 Andrew Pinski <pinskia at gcc dot gnu.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |ASSIGNED Last reconfirmed| |2024-04-20 Ever confirmed|0 |1 Assignee|unassigned at gcc dot gnu.org |pinskia at gcc dot gnu.org --- Comment #1 from Andrew Pinski <pinskia at gcc dot gnu.org> --- Filed so I can get back to this after finishing up the phi-opt patch. ^ permalink raw reply [flat|nested] 4+ messages in thread
* [Bug tree-optimization/114785] special handling of COND_EXPR in gimple_extract can be removed 2024-04-20 0:38 [Bug tree-optimization/114785] New: special handling of COND_EXPR in gimple_extract can be removed pinskia at gcc dot gnu.org 2024-04-20 0:38 ` [Bug tree-optimization/114785] " pinskia at gcc dot gnu.org @ 2024-04-20 1:09 ` pinskia at gcc dot gnu.org 2024-04-22 19:19 ` rguenth at gcc dot gnu.org 2 siblings, 0 replies; 4+ messages in thread From: pinskia at gcc dot gnu.org @ 2024-04-20 1:09 UTC (permalink / raw) To: gcc-bugs https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114785 --- Comment #2 from Andrew Pinski <pinskia at gcc dot gnu.org> --- I think the code code in maybe_push_res_to_seq for COMPARISON_CLASS_P can be removed too ... ^ permalink raw reply [flat|nested] 4+ messages in thread
* [Bug tree-optimization/114785] special handling of COND_EXPR in gimple_extract can be removed 2024-04-20 0:38 [Bug tree-optimization/114785] New: special handling of COND_EXPR in gimple_extract can be removed pinskia at gcc dot gnu.org 2024-04-20 0:38 ` [Bug tree-optimization/114785] " pinskia at gcc dot gnu.org 2024-04-20 1:09 ` pinskia at gcc dot gnu.org @ 2024-04-22 19:19 ` rguenth at gcc dot gnu.org 2 siblings, 0 replies; 4+ messages in thread From: rguenth at gcc dot gnu.org @ 2024-04-22 19:19 UTC (permalink / raw) To: gcc-bugs https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114785 --- Comment #3 from Richard Biener <rguenth at gcc dot gnu.org> --- Note there's still code in tree-vect-patterns.cc creating those and code in tree-vect-stmts.cc might use gimple_extract on them. ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-04-22 19:19 UTC | newest] Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2024-04-20 0:38 [Bug tree-optimization/114785] New: special handling of COND_EXPR in gimple_extract can be removed pinskia at gcc dot gnu.org 2024-04-20 0:38 ` [Bug tree-optimization/114785] " pinskia at gcc dot gnu.org 2024-04-20 1:09 ` pinskia at gcc dot gnu.org 2024-04-22 19:19 ` rguenth at gcc dot gnu.org
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).