[Bug tree-optimization/114799] New: [14 Regression] ICE: tree check: expected class 'type', have 'exceptional' (error_mark) in useless_type_conversion_p, at gimple-expr.cc:85 with -O2 -fno-tree-forwprop -fvect-cost-model=unlimited

[Bug tree-optimization/114799] New: [14 Regression] ICE: tree check: expected class 'type', have 'exceptional' (error_mark) in useless_type_conversion_p, at gimple-expr.cc:85 with -O2 -fno-tree-forwprop -fvect-cost-model=unlimited

[zsojka at seznam dot cz]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114799

            Bug ID: 114799
           Summary: [14 Regression] ICE: tree check: expected class
                    'type', have 'exceptional' (error_mark) in
                    useless_type_conversion_p, at gimple-expr.cc:85 with
                    -O2 -fno-tree-forwprop -fvect-cost-model=unlimited
           Product: gcc
           Version: 14.0
            Status: UNCONFIRMED
          Keywords: ice-on-valid-code
          Severity: normal
          Priority: P3
         Component: tree-optimization
          Assignee: unassigned at gcc dot gnu.org
          Reporter: zsojka at seznam dot cz
  Target Milestone: ---
              Host: x86_64-pc-linux-gnu
            Target: x86_64-pc-linux-gnu

Created attachment 58004
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=58004&action=edit
reduced testcase

Compiler output:
$ x86_64-pc-linux-gnu-gcc -O2 -fno-tree-forwprop -fvect-cost-model=unlimited
testcase.c -Wno-psabi
during GIMPLE pass: slp
testcase.c: In function 'foo':
testcase.c:17:1: internal compiler error: tree check: expected class 'type',
have 'exceptional' (error_mark) in useless_type_conversion_p, at
gimple-expr.cc:85
   17 | foo (void)
      | ^~~
0x894e6f tree_class_check_failed(tree_node const*, tree_code_class, char
const*, int, char const*)
        /repo/gcc-trunk/gcc/tree.cc:9006
0x77ef52 tree_class_check(tree_node*, tree_code_class, char const*, int, char
const*)
        /repo/gcc-trunk/gcc/tree.h:3779
0x77ef52 useless_type_conversion_p(tree_node*, tree_node*)
        /repo/gcc-trunk/gcc/gimple-expr.cc:85
0x155c516 verify_gimple_assign_single
        /repo/gcc-trunk/gcc/tree-cfg.cc:4791
0x155c516 verify_gimple_assign
        /repo/gcc-trunk/gcc/tree-cfg.cc:4843
0x155c516 verify_gimple_stmt
        /repo/gcc-trunk/gcc/tree-cfg.cc:5108
0x155fd01 verify_gimple_in_cfg(function*, bool, bool)
        /repo/gcc-trunk/gcc/tree-cfg.cc:5603
0x13ced14 execute_function_todo
        /repo/gcc-trunk/gcc/passes.cc:2089
0x13cf26e execute_todo
        /repo/gcc-trunk/gcc/passes.cc:2143
Please submit a full bug report, with preprocessed source (by using
-freport-bug).
Please include the complete backtrace with any bug report.
See <https://gcc.gnu.org/bugs/> for instructions.

$ x86_64-pc-linux-gnu-gcc -v
Using built-in specs.
COLLECT_GCC=/repo/gcc-trunk/binary-latest-amd64/bin/x86_64-pc-linux-gnu-gcc
COLLECT_LTO_WRAPPER=/repo/gcc-trunk/binary-trunk-r14-10062-20240422092604-gec78916bb37-checking-yes-rtl-df-extra-nobootstrap-amd64/bin/../libexec/gcc/x86_64-pc-linux-gnu/14.0.1/lto-wrapper
Target: x86_64-pc-linux-gnu
Configured with: /repo/gcc-trunk//configure --enable-languages=c,c++
--enable-valgrind-annotations --disable-nls --enable-checking=yes,rtl,df,extra
--disable-bootstrap --with-cloog --with-ppl --with-isl
--build=x86_64-pc-linux-gnu --host=x86_64-pc-linux-gnu
--target=x86_64-pc-linux-gnu --with-ld=/usr/bin/x86_64-pc-linux-gnu-ld
--with-as=/usr/bin/x86_64-pc-linux-gnu-as --enable-libsanitizer
--disable-libstdcxx-pch
--prefix=/repo/gcc-trunk//binary-trunk-r14-10062-20240422092604-gec78916bb37-checking-yes-rtl-df-extra-nobootstrap-amd64
Thread model: posix
Supported LTO compression algorithms: zlib zstd
gcc version 14.0.1 20240422 (experimental) (GCC)

[Bug tree-optimization/114799] [14 Regression] ICE: tree check: expected class 'type', have 'exceptional' (error_mark) in useless_type_conversion_p, at gimple-expr.cc:85 with -O2 -fno-tree-forwprop -fvect-cost-model=unlimited

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114799

--- Comment #1 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Created attachment 58005
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=58005&action=edit
Reduced further

Just need `-O3  -fno-vect-cost-model` with this one.

[Bug tree-optimization/114799] [14 Regression] ICE: tree check: expected class 'type', have 'exceptional' (error_mark) in useless_type_conversion_p, at gimple-expr.cc:85 with -O2 -fno-tree-forwprop -fvect-cost-model=unlimited

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114799

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |14.0

[Bug tree-optimization/114799] [14 Regression] ICE: tree check: expected class 'type', have 'exceptional' (error_mark) in useless_type_conversion_p, at gimple-expr.cc:85 with -O2 -fno-tree-forwprop -fvect-cost-model=unlimited

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114799

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever confirmed|0                           |1
   Last reconfirmed|                            |2024-04-22

--- Comment #2 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Confirmed.

[Bug tree-optimization/114799] [14 Regression] ICE: tree check: expected class 'type', have 'exceptional' (error_mark) in useless_type_conversion_p, at gimple-expr.cc:85 with -O2 -fno-vect-cost-model

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114799

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[14 Regression] ICE: tree   |[14 Regression] ICE: tree
                   |check: expected class       |check: expected class
                   |'type', have 'exceptional'  |'type', have 'exceptional'
                   |(error_mark) in             |(error_mark) in
                   |useless_type_conversion_p,  |useless_type_conversion_p,
                   |at gimple-expr.cc:85 with   |at gimple-expr.cc:85 with
                   |-O2 -fno-tree-forwprop      |-O2  -fno-vect-cost-model
                   |-fvect-cost-model=unlimited |

--- Comment #3 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
  _20 = {t1_6, _10};
  vect_patt_12.5_22 = { 254, 255 } + _20;
  vect_t1_7.4_21 = { 254, 255 } - _20;


_10 is not defined anywhere.

[Bug tree-optimization/114799] [14 Regression] ICE: tree check: expected class 'type', have 'exceptional' (error_mark) in useless_type_conversion_p, at gimple-expr.cc:85 with -O2 -fno-vect-cost-model since r14-9316

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114799

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|needs-bisection             |
            Summary|[14 Regression] ICE: tree   |[14 Regression] ICE: tree
                   |check: expected class       |check: expected class
                   |'type', have 'exceptional'  |'type', have 'exceptional'
                   |(error_mark) in             |(error_mark) in
                   |useless_type_conversion_p,  |useless_type_conversion_p,
                   |at gimple-expr.cc:85 with   |at gimple-expr.cc:85 with
                   |-O2  -fno-vect-cost-model   |-O2  -fno-vect-cost-model
                   |                            |since r14-9316
                 CC|                            |jakub at gcc dot gnu.org,
                   |                            |rguenth at gcc dot gnu.org
           Priority|P3                          |P1

--- Comment #4 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Started with r14-9316-g7890836de20912bd92afaf5abbeaf9d8c5b86542

[Bug tree-optimization/114799] [14 Regression] ICE: tree check: expected class 'type', have 'exceptional' (error_mark) in useless_type_conversion_p, at gimple-expr.cc:85 with -O2 -fno-vect-cost-model since r14-9316

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114799

--- Comment #5 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
_10 is created during pattern recognition:
patt_10 = (unsigned short) y.0_1;

#0  vect_convert_input (vinfo=0x3a883e0, stmt_info=0x3be5410,
type=<integer_type 0x7fffea2db540>, unprom=0x7fffffffcc80, vectype=<vector_type
0x7fffea2db930>, subtype=optab_default)
    at ../../gcc/tree-vect-patterns.cc:926
#1  0x00000000026dcede in vect_convert_inputs (vinfo=0x3a883e0,
stmt_info=0x3be5410, n=2, result=0x7fffffffcc50, type=<integer_type
0x7fffea2db540>, unprom=0x7fffffffcc80, 
    vectype=<vector_type 0x7fffea2db930>, subtype=optab_default) at
../../gcc/tree-vect-patterns.cc:977
#2  0x00000000026e35f5 in vect_recog_over_widening_pattern (vinfo=0x3a883e0,
last_stmt_info=0x3be5410, type_out=0x7fffffffce48) at
../../gcc/tree-vect-patterns.cc:3155
#3  0x00000000026f250a in vect_pattern_recog_1 (vinfo=0x3a883e0,
recog_func=0x385ae30 <vect_vect_recog_func_ptrs+48>, stmt_info=0x3be5410) at
../../gcc/tree-vect-patterns.cc:7181
#4  0x00000000026f29fb in vect_pattern_recog (vinfo=0x3a883e0) at
../../gcc/tree-vect-patterns.cc:7338
#5  0x00000000011663ac in vect_slp_analyze_bb_1 (bb_vinfo=0x3a883e0, n_stmts=9,
fatal=@0x7fffffffd2cb: false, Python Exception <class 'gdb.error'>: There is no
member or method named m_vecpfx.
dataref_groups=0x7fffffffd760) at ../../gcc/tree-vect-slp.cc:7722
#6  0x00000000011668b6 in vect_slp_region (bbs=..., datarefs=..., Python
Exception <class 'gdb.error'>: There is no member or method named m_vecpfx.
dataref_groups=0x7fffffffd760, n_stmts=9, orig_loop=0x0) at
../../gcc/tree-vect-slp.cc:7831
#7  0x000000000116791f in vect_slp_bbs (bbs=..., orig_loop=0x0) at
../../gcc/tree-vect-slp.cc:8042

Unfortunately, I'm afraid I know next to nothing about SLP handling of
patterns, just loop vectorization :(

[Bug tree-optimization/114799] [14 Regression] ICE: tree check: expected class 'type', have 'exceptional' (error_mark) in useless_type_conversion_p, at gimple-expr.cc:85 with -O2 -fno-vect-cost-model since r14-9316

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114799

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|unassigned at gcc dot gnu.org      |rguenth at gcc dot gnu.org
             Status|NEW                         |ASSIGNED

--- Comment #6 from Richard Biener <rguenth at gcc dot gnu.org> ---
I will have a look.

[Bug tree-optimization/114799] [14 Regression] ICE: tree check: expected class 'type', have 'exceptional' (error_mark) in useless_type_conversion_p, at gimple-expr.cc:85 with -O2 -fno-vect-cost-model since r14-9316

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114799

--- Comment #7 from Richard Biener <rguenth at gcc dot gnu.org> ---
t.i:11:6: note:   node (external) 0x4918928 (max_nunits=1, refcnt=2)
t.i:11:6: note:         { t1_6, patt_10 }

I have a fix for this latent issue.

[Bug tree-optimization/114799] [14 Regression] ICE: tree check: expected class 'type', have 'exceptional' (error_mark) in useless_type_conversion_p, at gimple-expr.cc:85 with -O2 -fno-vect-cost-model since r14-9316

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114799

--- Comment #8 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Richard Biener <rguenth@gcc.gnu.org>:

https://gcc.gnu.org/g:18e8e55487238237f37f621668fdee316624981a

commit r14-10088-g18e8e55487238237f37f621668fdee316624981a
Author: Richard Biener <rguenther@suse.de>
Date:   Tue Apr 23 08:39:03 2024 +0200

    tree-optimization/114799 - SLP and patterns

    The following plugs a hole with computing whether a SLP node has any
    pattern stmts which is important to know when we want to replace it
    by a CTOR from external defs.

            PR tree-optimization/114799
            * tree-vect-slp.cc (vect_get_and_check_slp_defs): Properly
            update ->any_pattern when swapping operands.

            * gcc.dg/vect/bb-slp-pr114799.c: New testcase.

[Bug tree-optimization/114799] [13 Regression] ICE: tree check: expected class 'type', have 'exceptional' (error_mark) in useless_type_conversion_p, at gimple-expr.cc:85 with -O2 -fno-vect-cost-model since r14-9316

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114799

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P1                          |P2
            Summary|[14 Regression] ICE: tree   |[13 Regression] ICE: tree
                   |check: expected class       |check: expected class
                   |'type', have 'exceptional'  |'type', have 'exceptional'
                   |(error_mark) in             |(error_mark) in
                   |useless_type_conversion_p,  |useless_type_conversion_p,
                   |at gimple-expr.cc:85 with   |at gimple-expr.cc:85 with
                   |-O2  -fno-vect-cost-model   |-O2  -fno-vect-cost-model
                   |since r14-9316              |since r14-9316
      Known to work|                            |14.0
   Target Milestone|14.0                        |13.3
      Known to fail|14.0                        |

--- Comment #9 from Richard Biener <rguenth at gcc dot gnu.org> ---
Will backport to 13 at least.

[Bug tree-optimization/114799] [13 Regression] ICE: tree check: expected class 'type', have 'exceptional' (error_mark) in useless_type_conversion_p, at gimple-expr.cc:85 with -O2 -fno-vect-cost-model since r14-9316

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114799

--- Comment #10 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-13 branch has been updated by Richard Biener
<rguenth@gcc.gnu.org>:

https://gcc.gnu.org/g:026ecb914d3d84c6e803cedb8b1677d3e7ddd60f

commit r13-8698-g026ecb914d3d84c6e803cedb8b1677d3e7ddd60f
Author: Richard Biener <rguenther@suse.de>
Date:   Tue Apr 23 08:39:03 2024 +0200

    tree-optimization/114799 - SLP and patterns

    The following plugs a hole with computing whether a SLP node has any
    pattern stmts which is important to know when we want to replace it
    by a CTOR from external defs.

            PR tree-optimization/114799
            * tree-vect-slp.cc (vect_get_and_check_slp_defs): Properly
            update ->any_pattern when swapping operands.

            * gcc.dg/vect/bb-slp-pr114799.c: New testcase.

    (cherry picked from commit 18e8e55487238237f37f621668fdee316624981a)

[Bug tree-optimization/114799] [13 Regression] ICE: tree check: expected class 'type', have 'exceptional' (error_mark) in useless_type_conversion_p, at gimple-expr.cc:85 with -O2 -fno-vect-cost-model since r14-9316

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114799

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
      Known to fail|                            |13.2.0
             Status|ASSIGNED                    |RESOLVED

--- Comment #11 from Richard Biener <rguenth at gcc dot gnu.org> ---
Fixed for GCC13+.