[Bug modula2/114807] New: badpointer3.mod causes an ICE

[Bug modula2/114807] New: badpointer3.mod causes an ICE

[gaius at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114807

            Bug ID: 114807
           Summary: badpointer3.mod causes an ICE
           Product: gcc
           Version: 14.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: modula2
          Assignee: gaius at gcc dot gnu.org
          Reporter: gaius at gcc dot gnu.org
  Target Milestone: ---

The testsuite code: gcc/testsuite/gm2/pim/fail/badpointer3.mod causes an ICE.

$ gm2 badpointer3.mod 
cc1gm2: internal compiler error: assert failed
0x841537 m2linemap_internal_error
        ../../gcc/m2/gm2-gcc/m2linemap.cc:253
0x90c62b M2Emit_InternalError
        m2/gm2-compiler-boot/M2Emit.c:102
0x87056b M2Error_InternalError
        m2/gm2-compiler-boot/M2Error.c:2652
0x86e2ff M2Debug_Assert
        m2/gm2-compiler-boot/M2Debug.c:63
0x8c7f07 SymbolTable_CopyConstString
        m2/gm2-compiler-boot/SymbolTable.c:10522
0x8a0b6f MoveWithMode
        m2/gm2-compiler-boot/M2Quads.c:7084
0x8a0b6f doBuildAssignment
        m2/gm2-compiler-boot/M2Quads.c:7234

[Bug modula2/114807] badpointer3.mod causes an ICE

[gaius at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114807

Gaius Mulley <gaius at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |ASSIGNED
     Ever confirmed|0                           |1
   Last reconfirmed|                            |2024-04-22

--- Comment #1 from Gaius Mulley <gaius at gcc dot gnu.org> ---
Confirmed.

[Bug modula2/114807] badpointer3.mod causes an ICE

[gaius at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114807

--- Comment #2 from Gaius Mulley <gaius at gcc dot gnu.org> ---
Created attachment 58009
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=58009&action=edit
Proposed fix

After the proposed patch fix is applied the cc1gm2 behaviour changes to:

$ gm2 -g -c badpointer3.mod 
badpointer3.mod:18:14: error: In procedure ‘foo’: 1st parameter type failure
between actual parameter type ‘Hello’ and the formal type ‘s’
   18 |    testproc (Hello)
      |              ^~~~~
badpointer3.mod:18:14: error: ‘Hello’ and ‘s’ are incompatible as formal and
actual procedure parameters

[Bug modula2/114807] badpointer3.mod causes an ICE

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114807

--- Comment #3 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Gaius Mulley <gaius@gcc.gnu.org>:

https://gcc.gnu.org/g:b0469e35dbcc9a93a2cb50e3c0445edc3db174be

commit r14-10077-gb0469e35dbcc9a93a2cb50e3c0445edc3db174be
Author: Gaius Mulley <gaiusmod2@gmail.com>
Date:   Mon Apr 22 18:19:32 2024 +0100

    PR modula2/114807 badpointer3.mod causes an ICE

    This patch fixes an ICE caused when a constant string
    is built and attempted to be passed into a procedure with
    an opaque type.

    gcc/m2/ChangeLog:

            PR modula2/114807
            * gm2-compiler/M2Check.mod (checkUnbounded): Remove unused
            local variables.
            (constCheckMeta): Include check for IsReallyPointer in the
            failure case.
            * gm2-compiler/M2Quads.mod (MoveWithMode): Remove CopyConstString.
            * gm2-compiler/SymbolTable.def (IsHiddenReallyPointer): Export.
            * gm2-compiler/SymbolTable.mod (SkipHiddenType): Remove.
            (IsReallyPointer): Include IsHiddenReallyPointer test.

    gcc/testsuite/ChangeLog:

            PR modula2/114807
            * gm2/pim/fail/badproctype.mod: Change MYSHORTREAL
            to SHORTREAL.
            * gm2/pim/fail/badprocbool.mod: New test.
            * gm2/pim/fail/badproccard.mod: New test.
            * gm2/pim/fail/badprocint.mod: New test.
            * gm2/pim/fail/badprocint2.mod: New test.
            * gm2/pim/pass/goodproccard2.mod: New test.
            * gm2/pim/pass/goodprocint.mod: New test.
            * gm2/pim/pass/goodprocint3.mod: New test.
            * gm2/pim/run/pass/genconststr.mod: New test.

    Signed-off-by: Gaius Mulley <gaiusmod2@gmail.com>

[Bug modula2/114807] badpointer3.mod causes an ICE

[gaius at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114807

Gaius Mulley <gaius at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #4 from Gaius Mulley <gaius at gcc dot gnu.org> ---
Closed now the patch has been applied.