[Bug modula2/114811] New: iso/fail/badexpression.mod and iso/fail/badexpression2.mod ICE

[Bug modula2/114811] New: iso/fail/badexpression.mod and iso/fail/badexpression2.mod ICE

[gaius at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114811

            Bug ID: 114811
           Summary: iso/fail/badexpression.mod and
                    iso/fail/badexpression2.mod ICE
           Product: gcc
           Version: 14.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: modula2
          Assignee: gaius at gcc dot gnu.org
          Reporter: gaius at gcc dot gnu.org
  Target Milestone: ---

Following on from PR 114807 it appears that gm2-torture.exp is reporting a fail
case ICE as a positive result.

[Bug modula2/114811] iso/fail/badexpression.mod and iso/fail/badexpression2.mod ICE

[gaius at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114811

--- Comment #1 from Gaius Mulley <gaius at gcc dot gnu.org> ---
Created attachment 58012
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=58012&action=edit
Proposed fix

This patch fixes gm2-torture.exp to detect internal compiler error as a
negative result and also provides a bug fix to M2GenGCC.mod:FoldBinarySet. 
FoldBinarySet must only check types if the
operands have been resolved.  This ICE is seen when a string is attempted to be
included into a set.  See gcc/testsuite/gm2/iso/fail/badexpression2.mod.

[Bug modula2/114811] iso/fail/badexpression.mod and iso/fail/badexpression2.mod ICE

[gaius at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114811

Gaius Mulley <gaius at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
     Ever confirmed|0                           |1
   Last reconfirmed|                            |2024-04-22
             Status|UNCONFIRMED                 |ASSIGNED

--- Comment #2 from Gaius Mulley <gaius at gcc dot gnu.org> ---
Confirmed.

[Bug modula2/114811] iso/fail/badexpression.mod and iso/fail/badexpression2.mod ICE

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114811

--- Comment #3 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Gaius Mulley <gaius@gcc.gnu.org>:

https://gcc.gnu.org/g:b909daa5b67317e46543a7b2ed76e82298645cf6

commit r14-10080-gb909daa5b67317e46543a7b2ed76e82298645cf6
Author: Gaius Mulley <gaiusmod2@gmail.com>
Date:   Mon Apr 22 20:34:11 2024 +0100

    PR modula2/114811 string set incl ICE bugfix

    This patch corrects gm2-torture.exp to recognize an ICE
    in the fail case as a negative result.  The patch also fixes
    FoldBinarySet so that the types are only checked once the operands
    have been resolved.  Without this patch
    gcc/testsuite/gm2/iso/fail/badexpression2.mod would cause an ICE.

    gcc/m2/ChangeLog:

            PR modula2/114811
            * gm2-compiler/M2GenGCC.mod (FoldBinarySet): Add condition
            checking to ensure op2 and op3 are fully resolved before
            type checking is performed.

    gcc/testsuite/ChangeLog:

            PR modula2/114811
            * lib/gm2-torture.exp: Correct regexp checking for internal
            compiler error strings in compiler output.

    Signed-off-by: Gaius Mulley <gaiusmod2@gmail.com>

[Bug modula2/114811] iso/fail/badexpression.mod and iso/fail/badexpression2.mod ICE

[gaius at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114811

Gaius Mulley <gaius at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #4 from Gaius Mulley <gaius at gcc dot gnu.org> ---
Closing now the patch has been applied.