[Bug middle-end/114975] New: [AVR] Using popcounthi2 for 8-bit values despit popcountqi2

[Bug middle-end/114975] New: [AVR] Using popcounthi2 for 8-bit values despit popcountqi2

[gjl at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114975

            Bug ID: 114975
           Summary: [AVR] Using popcounthi2 for 8-bit values despit
                    popcountqi2
           Product: gcc
           Version: 14.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: middle-end
          Assignee: unassigned at gcc dot gnu.org
          Reporter: gjl at gcc dot gnu.org
  Target Milestone: ---

C test case

typedef __UINT8_TYPE__ uint8_t;

uint8_t use_pop (uint8_t x)
{
    return __builtin_popcount (x);
}

compiles with

$ avr-gcc pop.c -Os -S

to:

use_pop:
        ldi r25,0
        rcall __popcounthi2
        ret

        .ident  "GCC: (GNU) 14.0.1 20240421 (experimental)"

despite libgcc providing __popcountqi2.

I am not even sure which component is supposed to treat this.  The tree
optimizers do only __builtin_popcount, and as there's nothing like popcount_u8
they cannot do anything about it.  So blaming the middle-end for now.

[Bug middle-end/114975] [AVR] Using popcounthi2 for 8-bit values despite popcountqi2

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114975

--- Comment #1 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Georg-Johann Lay <gjl@gcc.gnu.org>:

https://gcc.gnu.org/g:c8f4bbb824fafecf021a802324cd79e64b03b947

commit r15-317-gc8f4bbb824fafecf021a802324cd79e64b03b947
Author: Georg-Johann Lay <avr@gjlay.de>
Date:   Tue May 7 19:39:55 2024 +0200

    AVR: target/114975 - Add combine-pattern for __popcountqi2.

            PR target/114975
    gcc/
            * config/avr/avr.md: Add combine pattern for
            8-bit popcount detection.

    gcc/testsuite/
            * gcc.target/avr/pr114975-popcount.c: New test.

[Bug middle-end/114975] [AVR] Using popcounthi2 for 8-bit values despite popcountqi2

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114975

--- Comment #2 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Georg-Johann Lay <gjl@gcc.gnu.org>:

https://gcc.gnu.org/g:41bc359c322d45ec1adfb51f7a45c7ef02ce6ca9

commit r15-318-g41bc359c322d45ec1adfb51f7a45c7ef02ce6ca9
Author: Georg-Johann Lay <avr@gjlay.de>
Date:   Tue May 7 19:42:30 2024 +0200

    AVR: target/114975 - Add combine-pattern for __parityqi2.

            PR target/114975
    gcc/
            * config/avr/avr.md: Add combine pattern for
            8-bit parity detection.

    gcc/testsuite/
            * gcc.target/avr/pr114975-parity.c: New test.

[Bug target/114975] [AVR] Using popcounthi2 for 8-bit values despite popcountqi2

[gjl at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114975

Georg-Johann Lay <gjl at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |FIXED
          Component|middle-end                  |target
   Target Milestone|---                         |15.0

--- Comment #3 from Georg-Johann Lay <gjl at gcc dot gnu.org> ---
Fixed in v15.

[Bug target/114975] [AVR] Using popcounthi2 for 8-bit values despite popcountqi2

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114975

--- Comment #4 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-14 branch has been updated by Georg-Johann Lay
<gjl@gcc.gnu.org>:

https://gcc.gnu.org/g:4ef09dd8ce8866e4f64dd918890c97a67af8fd15

commit r14-10187-g4ef09dd8ce8866e4f64dd918890c97a67af8fd15
Author: Georg-Johann Lay <avr@gjlay.de>
Date:   Tue May 7 19:39:55 2024 +0200

    AVR: target/114975 - Add combine-pattern for __popcountqi2.

            PR target/114975
    gcc/
            * config/avr/avr.md: Add combine pattern for
            8-bit popcount detection.

    gcc/testsuite/
            * gcc.target/avr/pr114975-popcount.c: New test.

    (cherry picked from commit c8f4bbb824fafecf021a802324cd79e64b03b947)

[Bug target/114975] [AVR] Using popcounthi2 for 8-bit values despite popcountqi2

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114975

--- Comment #5 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-14 branch has been updated by Georg-Johann Lay
<gjl@gcc.gnu.org>:

https://gcc.gnu.org/g:bbb76ac0a06ae3a469f2acc2d5d63e63160bd9e5

commit r14-10188-gbbb76ac0a06ae3a469f2acc2d5d63e63160bd9e5
Author: Georg-Johann Lay <avr@gjlay.de>
Date:   Tue May 7 19:42:30 2024 +0200

    AVR: target/114975 - Add combine-pattern for __parityqi2.

            PR target/114975
    gcc/
            * config/avr/avr.md: Add combine pattern for
            8-bit parity detection.

    gcc/testsuite/
            * gcc.target/avr/pr114975-parity.c: New test.

    (cherry picked from commit 41bc359c322d45ec1adfb51f7a45c7ef02ce6ca9)

[Bug target/114975] [AVR] Using popcounthi2 for 8-bit values despite popcountqi2

[gjl at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114975

Georg-Johann Lay <gjl at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|15.0                        |14.2

--- Comment #6 from Georg-Johann Lay <gjl at gcc dot gnu.org> ---
Fixed in v14.2+