[Bug c++/19351] operator new[] can return heap blocks which are too small

[Bug c++/19351] operator new[] can return heap blocks which are too small

[fw at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19351

Florian Weimer <fw at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fw at gcc dot gnu.org

--- Comment #22 from Florian Weimer <fw at gcc dot gnu.org> 2011-01-22 20:15:08 UTC ---
New patch posted: http://gcc.gnu.org/ml/gcc-patches/2011-01/msg01593.html

[Bug c++/19351] operator new[] can return heap blocks which are too small

[redi at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19351

Jonathan Wakely <redi at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |redi at gcc dot gnu.org

--- Comment #23 from Jonathan Wakely <redi at gcc dot gnu.org> 2011-05-24 12:31:34 UTC ---
Florian, your patch seems to have gone unreviewed, could you ping it?

GCC is getting (fairly) criticised on the LLVM blog about this ;)

[Bug c++/19351] operator new[] can return heap blocks which are too small

[fw at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19351

--- Comment #24 from Florian Weimer <fw at gcc dot gnu.org> 2011-05-24 19:54:47 UTC ---
(In reply to comment #23)
> Florian, your patch seems to have gone unreviewed, could you ping it?

Jason reviewed it and Ian, too (off-list).  I haven't yet gotten around to
incorporating their feedback.  I'm also not sure if I'm qualified to tackle the
optimization requests.

[Bug c++/19351] [DR 624] operator new[] can return heap blocks which are too small

[redi at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19351

Jonathan Wakely <redi at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|operator new[] can return   |[DR 624] operator new[] can
                   |heap blocks which are too   |return heap blocks which
                   |small                       |are too small
           Severity|enhancement                 |normal

--- Comment #25 from Jonathan Wakely <redi at gcc dot gnu.org> 2012-02-07 21:33:00 UTC ---
since an exception is now required this is not an enhancement

[Bug c++/19351] [DR 624] operator new[] can return heap blocks which are too small

[fweimer at redhat dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19351

Florian Weimer <fweimer at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fweimer at redhat dot com

--- Comment #26 from Florian Weimer <fweimer at redhat dot com> 2012-07-17 09:05:22 UTC ---
Current proposed patch: http://gcc.gnu.org/ml/gcc-patches/2012-06/msg01689.html

[Bug c++/19351] [DR 624] operator new[] can return heap blocks which are too small

[fw at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19351

--- Comment #27 from Florian Weimer <fw at gcc dot gnu.org> 2012-08-20 21:13:29 UTC ---
Author: fw
Date: Mon Aug 20 21:13:23 2012
New Revision: 190546

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=190546
Log:
Fix PR C++/19351: integer overflow in operator new[]

2012-08-20  Florian Weimer  <fweimer@redhat.com>

    PR c++/19351
    * call.c (build_operator_new_call): Add size_check argument and
    evaluate it.
    * cp-tree.h (build_operator_new_call): Adjust declaration.
    * init.c (build_new_1): Compute array size check and apply it.

2012-08-10  Florian Weimer  <fweimer@redhat.com>

    PR c++/19351
    * g++.dg/init/new38.C: New test.
    * g++.dg/init/new39.C: New test.

Added:
    trunk/gcc/testsuite/g++.dg/init/new38.C
    trunk/gcc/testsuite/g++.dg/init/new39.C
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/cp/call.c
    trunk/gcc/cp/cp-tree.h
    trunk/gcc/cp/init.c
    trunk/gcc/testsuite/ChangeLog

[Bug c++/19351] [DR 624] operator new[] can return heap blocks which are too small

[fw at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19351

Florian Weimer <fw at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED
         AssignedTo|unassigned at gcc dot       |fweimer at redhat dot com
                   |gnu.org                     |
   Target Milestone|---                         |4.8.0

--- Comment #28 from Florian Weimer <fw at gcc dot gnu.org> 2012-08-20 21:23:09 UTC ---
This is the best we can do without an ABI change.  (Expanding inline the code
to throw std::bad_array_new_length, as required by C++11, is a bit too messy.)

[Bug c++/19351] [DR 624] operator new[] can return heap blocks which are too small

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19351

--- Comment #29 from Jakub Jelinek <jakub at gcc dot gnu.org> 2012-10-01 08:12:07 UTC ---
Author: jakub
Date: Mon Oct  1 08:12:01 2012
New Revision: 191891

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=191891
Log:
Move PR c++/19351 ChangeLog entry to correct ChangeLog.

Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/cp/ChangeLog

[Bug c++/19351] [DR 624] operator new[] can return heap blocks which are too small

[jackie.rosen at hushmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19351

Jackie Rosen <jackie.rosen at hushmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jackie.rosen at hushmail dot com

--- Comment #30 from Jackie Rosen <jackie.rosen at hushmail dot com> ---
*** Bug 260998 has been marked as a duplicate of this bug. ***
Seen from the domain http://volichat.com
Marked for reference. Resolved as fixed @bugzilla.