[Bug fortran/26766] [F2003] Recursive I/O still (again) broken

[Bug fortran/26766] [F2003] Recursive I/O still (again) broken

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=26766

--- Comment #10 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by H.J. Lu <hjl@gcc.gnu.org>:

https://gcc.gnu.org/g:4a5e71f2348adcc49939804889d9f1a64d97005a

commit r12-6006-g4a5e71f2348adcc49939804889d9f1a64d97005a
Author: H.J. Lu <hjl.tools@gmail.com>
Date:   Sat Nov 13 06:11:41 2021 -0800

    Sync with binutils: Support the PGO build for binutils+gdb

    Sync with binutils for building binutils with LTO:

    1dbde357be3 Add missing changes to Makefile.tpl
    af019bfde9b Support the PGO build for binutils+gdb

    Add the --enable-pgo-build[=lto] configure option.  When binutils+gdb
    is not built together with GCC, --enable-pgo-build enables the PGO build:

    1. First build with -fprofile-generate.
    2. Use "make maybe-check-*" to generate profiling data and pass -i to make
    to ignore errors when generating profiling data.
    3. Use "make clean" to remove the previous build.
    4. Rebuild with -fprofile-use.

    With --enable-pgo-build=lto, -flto=jobserver -ffat-lto-objects are used
    together with -fprofile-generate and -fprofile-use.  Add '+' to the command
    line for recursive make to support -flto=jobserver -ffat-lto-objects.

    NB: --enable-pgo-build=lto enables the PGO build with LTO while
    --enable-lto enables LTO support in toolchain.

            BZ binutils/26766
            * Makefile.tpl (BUILD_CFLAGS): New.
            (CFLAGS): Append $(BUILD_CFLAGS).
            (CXXFLAGS): Likewise.
            (PGO_BUILD_GEN_FLAGS_TO_PASS): New.
            (PGO_BUILD_TRAINING_CFLAGS): Likewise.
            (PGO_BUILD_TRAINING_CXXFLAGS): Likewise.
            (PGO_BUILD_TRAINING_FLAGS_TO_PASS): Likewise.
            (PGO_BUILD_TRAINING_MFLAGS): Likewise.
            (PGO_BUILD_USE_FLAGS_TO_PASS): Likewise.
            (PGO-TRAINING-TARGETS): Likewise.
            (PGO_BUILD_TRAINING): Likewise.
            (all): Add '+' to the command line for recursive make.  Support
            the PGO build.
            * configure.ac: Add --enable-pgo-build[=lto].
            AC_SUBST PGO_BUILD_GEN_CFLAGS, PGO_BUILD_USE_CFLAGS and
            PGO_BUILD_LTO_CFLAGS.  Enable the PGO build in Makefile.
            * Makefile.in: Regenerated.
            * configure: Likewise.

[Bug fortran/26766] [F2003] Recursive I/O still (again) broken

[jvdelisle at gcc dot gnu dot org]

------- Comment #9 from jvdelisle at gcc dot gnu dot org  2006-04-17 04:38 -------
Fixed on 4.1 and trunk


-- 

jvdelisle at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=26766

[Bug fortran/26766] [F2003] Recursive I/O still (again) broken

[jvdelisle at gcc dot gnu dot org]

------- Comment #8 from jvdelisle at gcc dot gnu dot org  2006-04-17 04:34 -------
Subject: Bug 26766

Author: jvdelisle
Date: Mon Apr 17 04:33:59 2006
New Revision: 113003

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=113003
Log:
2006-04-16  Jerry DeLisle  <jvdelisle@gcc.gnu.org>

        PR libgfortran/26766
        * gfortran.dg/write_recursive.f90: New test.

Added:
    branches/gcc-4_1-branch/gcc/testsuite/gfortran.dg/write_recursive.f90
Modified:
    branches/gcc-4_1-branch/gcc/testsuite/ChangeLog


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=26766

[Bug fortran/26766] [F2003] Recursive I/O still (again) broken

[jvdelisle at gcc dot gnu dot org]

------- Comment #7 from jvdelisle at gcc dot gnu dot org  2006-04-17 04:31 -------
Subject: Bug 26766

Author: jvdelisle
Date: Mon Apr 17 04:31:18 2006
New Revision: 113002

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=113002
Log:
2006-04-16  Jerry DeLisle  <jvdelisle@gcc.gnu.org>

        PR libgfortran/26766
        * io/io.h: Add bit to identify associated unit as internal.
        * io/unit.c (get_external_unit): Renamed the find_unit_1 function to
        reflect the external unit functionality vs internal unit.
        (get_internal_unit): New function to allocate and initialize an
internal
        unit structure.
        (get_unit): Use get_internal_unit and get_external_unit.
        (is_internal_unit): Revised to use new bit added in io.h.
        * io/transfer.c (data_transfer_init): Fix line width.
        (st_read_done): Free memory allocated for internal unit.
        (st_write_done): Add test to only flush and truncate when not an
        internal unit.  Free memory allocated for internal unit.

Modified:
    branches/gcc-4_1-branch/libgfortran/ChangeLog
    branches/gcc-4_1-branch/libgfortran/io/io.h
    branches/gcc-4_1-branch/libgfortran/io/transfer.c
    branches/gcc-4_1-branch/libgfortran/io/unit.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=26766

[Bug fortran/26766] [F2003] Recursive I/O still (again) broken

[jvdelisle at gcc dot gnu dot org]

------- Comment #6 from jvdelisle at gcc dot gnu dot org  2006-04-13 06:30 -------
Subject: Bug 26766

Author: jvdelisle
Date: Thu Apr 13 06:30:04 2006
New Revision: 112915

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=112915
Log:
2006-04-12  Jerry DeLisle  <jvdelisle@gcc.gnu.org>

        PR libgfortran/26766
        * gfortran.dg/write_recursive.f90: New test.

Added:
    trunk/gcc/testsuite/gfortran.dg/write_recursive.f90
Modified:
    trunk/gcc/testsuite/ChangeLog


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=26766

[Bug fortran/26766] [F2003] Recursive I/O still (again) broken

[jvdelisle at gcc dot gnu dot org]

------- Comment #5 from jvdelisle at gcc dot gnu dot org  2006-04-13 06:25 -------
Subject: Bug 26766

Author: jvdelisle
Date: Thu Apr 13 06:24:58 2006
New Revision: 112914

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=112914
Log:
2006-04-12  Jerry DeLisle  <jvdelisle@gcc.gnu.org>

        PR libgfortran/26766
        * io/io.h: Add bit to identify associated unit as internal.
        * io/unit.c (get_external_unit): Renamed the find_unit_1 function to
        reflect the external unit functionality vs internal unit.
        (get_internal_unit): New function to allocate and initialize an
internal
        unit structure.
        (get_unit): Use get_internal_unit and get_external_unit.
        (is_internal_unit): Revised to use new bit added in io.h.
        * io/transfer.c (data_transfer_init): Fix line width.
        (st_read_done): Free memory allocated for internal unit.
        (st_write_done): Add test to only flush and truncate when not an
        internal unit.  Free memory allocated for internal unit.

Modified:
    trunk/libgfortran/ChangeLog
    trunk/libgfortran/io/io.h
    trunk/libgfortran/io/transfer.c
    trunk/libgfortran/io/unit.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=26766

[Bug fortran/26766] [F2003] Recursive I/O still (again) broken

[patchapp at dberlin dot org]

------- Comment #4 from patchapp at dberlin dot org  2006-04-07 04:00 -------
Subject: Bug number PR26766

A patch for this bug has been added to the patch tracker.
The mailing list url for the patch is
http://gcc.gnu.org/ml/gcc-patches/2006-04/msg00249.html


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=26766

[Bug fortran/26766] [F2003] Recursive I/O still (again) broken

[jvdelisle at gcc dot gnu dot org]

------- Comment #3 from jvdelisle at gcc dot gnu dot org  2006-03-24 02:06 -------
I think I have a fix for this.  The internal_unit is a single static variable
declared in unit.c.  So when we have recursive calls to internal IO we are
stepping on our own feet.

The dtp structure also contains a unit structure.  If we use this structure
instead, there will be an independent internal unit for each internal string or
character array we do I/O with.

I will see if I can work up a patch in the next few weeks.


-- 

jvdelisle at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |jvdelisle at gcc dot gnu dot
                   |dot org                     |org
             Status|NEW                         |ASSIGNED
   Last reconfirmed|2006-03-20 17:20:50         |2006-03-24 02:06:36
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=26766

[Bug fortran/26766] [F2003] Recursive I/O still (again) broken

[jvdelisle at gcc dot gnu dot org]

------- Comment #2 from jvdelisle at gcc dot gnu dot org  2006-03-21 06:05 -------
Looking at -fdump-tree-original, should the internal unit descriptors in foo
and in main have the same value?  

foo (__result, .__result, i)
{
  if (*i < 0)
    {
      _gfortran_copy_string (4, __result, 4, "1234");
    }
  else
    {
      {
        struct __st_parameter_dt dt_parm.0;

        dt_parm.0.common.filename = "pr26766.f90";
        dt_parm.0.common.line = 15;
        dt_parm.0.internal_unit = (char *) __result;
        dt_parm.0.internal_unit_len = 4;
        dt_parm.0.internal_unit_desc = 0B;    <------ here -------
        dt_parm.0.common.unit = 0;
        dt_parm.0.format = "(i4.4)";
        dt_parm.0.format_len = 6;
        dt_parm.0.common.flags = 20480;
        _gfortran_st_write (&dt_parm.0);
        _gfortran_transfer_integer (&dt_parm.0, (int4 *) i, 4);
        _gfortran_st_write_done (&dt_parm.0);
      }
    }


MAIN__ ()
{
  char str[1:4];
  static void foo (char[1:4] &, int4, int4 &);

  _gfortran_set_std (70, 127, 0);
  {
    struct __st_parameter_dt dt_parm.1;

    dt_parm.1.common.filename = "pr26766.f90";
    dt_parm.1.common.line = 4;
    dt_parm.1.internal_unit = &str;
    dt_parm.1.internal_unit_len = 4;
    dt_parm.1.internal_unit_desc = 0B;   <------ and Here -------
    dt_parm.1.common.unit = 0;
    dt_parm.1.format = "(a)";
    dt_parm.1.format_len = 3;
    dt_parm.1.common.flags = 20480;
    _gfortran_st_write (&dt_parm.1);
    {
      char str.2[4];
      int4 C.906 = 1234;

      foo ((char[1:4] *) &str.2, 4, &C.906);
      _gfortran_transfer_character (&dt_parm.1, (char[1:4] *) &str.2, 4);
    }
    _gfortran_st_write_done (&dt_parm.1);
  }
}


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=26766

[Bug fortran/26766] [F2003] Recursive I/O still (again) broken

[pinskia at gcc dot gnu dot org]

------- Comment #1 from pinskia at gcc dot gnu dot org  2006-03-20 17:20 -------
Confirmed.


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|                            |20585
              nThis|                            |
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1
   GCC host triplet|i686-pc-cygwin              |
   Last reconfirmed|0000-00-00 00:00:00         |2006-03-20 17:20:50
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=26766