[Bug c++/30060] Error/warning on invalid code (duplicate identifier for enum/class) should be more specific

[Bug c++/30060] Error/warning on invalid code (duplicate identifier for enum/class) should be more specific

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=30060

--- Comment #4 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
clang gives a much better diagnostic for sure:
<source>:10:20: error: must use 'class' tag to refer to type 'foo' in this
scope
        foo *a=new foo;
                   ^
                   class 
<source>:2:9: note: class 'foo' is hidden by a non-type declaration of 'foo'
here
        foo = 1
        ^
<source>:10:20: error: allocation of incomplete type 'class foo'
        foo *a=new foo;
                   ^~~
<source>:10:20: note: forward declaration of 'foo'
<source>:10:14: error: use of undeclared identifier 'a'
        foo *a=new foo;
             ^

[Bug c++/30060] Error/warning on invalid code (duplicate identifier for enum/class) should be more specific

[bangerth at dealii dot org]

------- Comment #3 from bangerth at dealii dot org  2006-12-04 16:11 -------
Confirmed. While there may not be much that can be done at the place
where the current error is reported, the warning is definitely a valid
request.

W.


-- 

bangerth at dealii dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1
           Keywords|                            |diagnostic
   Last reconfirmed|0000-00-00 00:00:00         |2006-12-04 16:11:48
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30060

[Bug c++/30060] Error/warning on invalid code (duplicate identifier for enum/class) should be more specific

[bero at arklinux dot org]

------- Comment #2 from bero at arklinux dot org  2006-12-03 19:05 -------
True, but the warning bit (test.cpp:2: warning: declaration of enum value 'foo'
shadows class 'foo') should be doable (and would make the rest much easier to
spot).


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30060

[Bug c++/30060] Error/warning on invalid code (duplicate identifier for enum/class) should be more specific

[pinskia at gcc dot gnu dot org]

------- Comment #1 from pinskia at gcc dot gnu dot org  2006-12-03 18:56 -------
Actually I think the error is clear once you remember * is also multiplication.
so we have

foo * a = new foo;

Also I doubt we can improve the error message here.

Cameau online gives basically the same error message:

"ComeauTest.c", line 10: error: identifier "a" is undefined
          foo *a=new foo;
               ^

"ComeauTest.c", line 10: error: expected a type specifier
          foo *a=new foo;
                     ^


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30060