[Bug ada/30827] New: [Ada] GNAT.compiler_version problem for official releases?

[Bug ada/30827] New: [Ada] GNAT.compiler_version problem for official releases?

[laurent at guerby dot net]

The following prints some garbage characters for GCC 4.0.x and GCC 4.1.x on
x86-linux (for various x, I believe all official GCC releases are affected).

with Ada.Text_IO; use Ada.Text_IO;
with GNAT.compiler_version;
procedure P is
   package V is new GNAT.compiler_version;
begin
   Put_Line ("compiled with GNAT " & V.version);
end P;

Example of output:

compiled with GNAT GNAT Version:
4.1.2_ada_p�q\x14՘y>�j�k���}��Kj

An extract of b~p.ads generated by the binder:

   GNAT_Version : constant String :=
                    "GNAT Version: 4.1.2";

And ada/g-comvers.adb expects a closing parenthese:

   function Version return String is
   begin
      --  Search for terminating right paren

      for J in Ver_Prefix'Length + 1 .. GNAT_Version'Last loop
         if GNAT_Version (J) = ')' then
            return GNAT_Version (Ver_Prefix'Length + 1 .. J);
         end if;
      end loop;

      --  This should not happen (no right paren found)

      return GNAT_Version;
   end Version;

We need a way to properly pass the length of the version string, any
suggestion?


-- 
           Summary: [Ada] GNAT.compiler_version problem for official
                    releases?
           Product: gcc
           Version: unknown
            Status: UNCONFIRMED
          Keywords: wrong-code
          Severity: normal
          Priority: P3
         Component: ada
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: laurent at guerby dot net


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30827

[Bug ada/30827] [Ada] GNAT.compiler_version problem for official releases?

[abo dot pignard at wanadoo dot fr]

------- Comment #1 from abo dot pignard at wanadoo dot fr  2007-10-14 10:14 -------
It outputs:
compiled with GNAT GPL 2007 (20070402-41)
with:
$ gcc -v
Using built-in specs.
Target: powerpc-apple-darwin8.9.0
Configured with: ../src/configure
--prefix=/Users/pascal/Documents/Extraction/070521/gnat
--enable-languages=c,ada --disable-nls --disable-libada --disable-checking
--disable-libssp --disable-libgomp --disable-libgcj
Thread model: posix
gcc version 4.1.3 20070403 for GNAT GPL 2007 (20070402)


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30827

[Bug ada/30827] [Ada] GNAT.compiler_version problem for official releases?

[sam at gcc dot gnu dot org]

-- 

sam at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |sam at gcc dot gnu dot org
                   |dot org                     |
             Status|UNCONFIRMED                 |ASSIGNED
     Ever Confirmed|0                           |1
   Last reconfirmed|0000-00-00 00:00:00         |2008-08-17 14:17:46
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30827

[Bug ada/30827] [Ada] GNAT.compiler_version problem for official releases?

[sam at gcc dot gnu dot org]

------- Comment #3 from sam at gcc dot gnu dot org  2008-08-18 09:10 -------
Fixed in SVN trunk.


-- 

sam at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|---                         |4.4.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30827

[Bug ada/30827] [Ada] GNAT.compiler_version problem for official releases?

[sam at gcc dot gnu dot org]

------- Comment #2 from sam at gcc dot gnu dot org  2008-08-18 09:10 -------
Subject: Bug 30827

Author: sam
Date: Mon Aug 18 09:09:24 2008
New Revision: 139192

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=139192
Log:
2008-08-18  Samuel Tardieu  <sam@rfc1149.net>
            Robert Dewar  <dewar@adacore.com>
    gcc/ada/
        PR ada/30827
        * bindgen.adb (Gen_Output_File_Ada): Zero-terminate the
        version string.
        Move comment in the right place.
        * g-comver.adb (Version): Look for a zero-termination in
        addition to a closing parenthesis.

2008-08-18  Robert Dewar  <dewar@adacore.com>
    gcc/testsuite/
        PR ada/30827
        * gnat.dg/test_version.adb: New.

Added:
    trunk/gcc/testsuite/gnat.dg/test_version.adb
Modified:
    trunk/gcc/ada/ChangeLog
    trunk/gcc/ada/bindgen.adb
    trunk/gcc/ada/g-comver.adb
    trunk/gcc/testsuite/ChangeLog


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30827

[Bug ada/30827] [Ada] GNAT.compiler_version problem for official releases?

[ebotcazou at gcc dot gnu dot org]

------- Comment #4 from ebotcazou at gcc dot gnu dot org  2008-11-29 10:33 -------
Subject: Bug 30827

Author: ebotcazou
Date: Sat Nov 29 10:31:53 2008
New Revision: 142274

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=142274
Log:
        PR ada/30827
        * g-comver.adb (Ver_Len_Max): Fix inconsistency.

Modified:
    trunk/gcc/ada/ChangeLog
    trunk/gcc/ada/g-comver.adb
    trunk/gcc/testsuite/ChangeLog
    trunk/gcc/testsuite/gnat.dg/test_version.adb


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30827