[Bug driver/33980] Precompiled header file not removed on error

[Bug driver/33980] Precompiled header file not removed on error

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=33980

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
          Component|pch                         |driver
           Assignee|unassigned at gcc dot gnu.org      |pinskia at gcc dot gnu.org

--- Comment #5 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
I think I have a simple patch for this.

[Bug driver/33980] Precompiled header file not removed on error

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=33980

--- Comment #6 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Created attachment 55114
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=55114&action=edit
Patch which I am testing

[Bug driver/33980] Precompiled header file not removed on error

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=33980

--- Comment #7 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The trunk branch has been updated by Andrew Pinski <pinskia@gcc.gnu.org>:

https://gcc.gnu.org/g:cddb6dd6668843db351807ab8d2ff7440109f39a

commit r14-1000-gcddb6dd6668843db351807ab8d2ff7440109f39a
Author: Andrew Pinski <apinski@marvell.com>
Date:   Fri May 19 06:12:49 2023 +0000

    Fix driver/33980: Precompiled header file not removed on error

    So the problem here is that in the spec files, we were not marking the pch
    output file to be removed on error.
    The way to fix this is to mark the --output-pch argument as the output
    file argument.
    For the C++ specs file, we had to move around where the %V was located
    such that it would be after the %w marker as %V marker clears the
outputfiles.

    OK? Bootstrapped and tested on x86_64-linux-gnu.

    gcc/cp/ChangeLog:

            PR driver/33980
            * lang-specs.h ("@c++-header"): Add %w after
            the --output-pch.
            ("@c++-system-header"): Likewise.
            ("@c++-user-header"): Likewise.

    gcc/ChangeLog:

            PR driver/33980
            * gcc.cc (default_compilers["@c-header"]): Add %w
            after the --output-pch.

[Bug driver/33980] Precompiled header file not removed on error

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=33980

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
   Target Milestone|---                         |14.0
             Status|ASSIGNED                    |RESOLVED

--- Comment #8 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Fixed finally.