public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug middle-end/35290] Missing dead store elimination
[not found] <bug-35290-4@http.gcc.gnu.org/bugzilla/>
@ 2010-11-09 23:11 ` xinliangli at gmail dot com
2010-11-09 23:22 ` [Bug tree-optimization/35290] " pinskia at gcc dot gnu.org
` (2 subsequent siblings)
3 siblings, 0 replies; 4+ messages in thread
From: xinliangli at gmail dot com @ 2010-11-09 23:11 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35290
--- Comment #2 from davidxl <xinliangli at gmail dot com> 2010-11-09 23:11:38 UTC ---
This seems resolved in trunk gcc.
David
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Bug tree-optimization/35290] Missing dead store elimination
[not found] <bug-35290-4@http.gcc.gnu.org/bugzilla/>
2010-11-09 23:11 ` [Bug middle-end/35290] Missing dead store elimination xinliangli at gmail dot com
@ 2010-11-09 23:22 ` pinskia at gcc dot gnu.org
2010-11-10 12:32 ` rguenth at gcc dot gnu.org
2014-09-05 10:58 ` glisse at gcc dot gnu.org
3 siblings, 0 replies; 4+ messages in thread
From: pinskia at gcc dot gnu.org @ 2010-11-09 23:22 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35290
Andrew Pinski <pinskia at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Keywords| |TREE
Last reconfirmed|2008-02-22 10:48:57 |2010-11-09 10:48:57
Component|middle-end |tree-optimization
--- Comment #3 from Andrew Pinski <pinskia at gcc dot gnu.org> 2010-11-09 23:21:50 UTC ---
The tree level DSE does not do it though. The RTL level has been fixed since
the DF branch was merged in.
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Bug tree-optimization/35290] Missing dead store elimination
[not found] <bug-35290-4@http.gcc.gnu.org/bugzilla/>
2010-11-09 23:11 ` [Bug middle-end/35290] Missing dead store elimination xinliangli at gmail dot com
2010-11-09 23:22 ` [Bug tree-optimization/35290] " pinskia at gcc dot gnu.org
@ 2010-11-10 12:32 ` rguenth at gcc dot gnu.org
2014-09-05 10:58 ` glisse at gcc dot gnu.org
3 siblings, 0 replies; 4+ messages in thread
From: rguenth at gcc dot gnu.org @ 2010-11-10 12:32 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35290
Richard Guenther <rguenth at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
AssignedTo|unassigned at gcc dot |rguenth at gcc dot gnu.org
|gnu.org |
--- Comment #4 from Richard Guenther <rguenth at gcc dot gnu.org> 2010-11-10 12:32:16 UTC ---
Well, it's not working on the tree level to make it cheaper:
/* We deliberately stop on clobbering statements and not only on
killing ones to make walking cheaper. Otherwise we can just
continue walking until both stores have equal reference trees. */
while (!stmt_may_clobber_ref_p (temp, gimple_assign_lhs (stmt)));
changing that to
while (!stmt_kills_ref_p (temp, gimple_assign_lhs (stmt)));
will make it work (and slower).
Also needs (possibly unsafe in general if used cross loop iteration)
Index: gcc/tree-ssa-alias.c
===================================================================
--- gcc/tree-ssa-alias.c (revision 166526)
+++ gcc/tree-ssa-alias.c (working copy)
@@ -1577,7 +1577,12 @@ stmt_kills_ref_p_1 (gimple stmt, ao_ref
base = get_ref_base_and_extent (lhs, &offset, &size, &max_size);
/* We can get MEM[symbol: sZ, index: D.8862_1] here,
so base == ref->base does not always hold. */
- if (base == ref->base)
+ if (base == ref->base
+ || (TREE_CODE (base) == MEM_REF
+ && TREE_CODE (ref->base) == MEM_REF
+ && TREE_OPERAND (base, 0) == TREE_OPERAND (ref->base, 0)
+ && tree_int_cst_equal (TREE_OPERAND (base, 1),
+ TREE_OPERAND (ref->base, 1))))
{
/* For a must-alias check we need to be able to constrain
the accesses properly. */
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Bug tree-optimization/35290] Missing dead store elimination
[not found] <bug-35290-4@http.gcc.gnu.org/bugzilla/>
` (2 preceding siblings ...)
2010-11-10 12:32 ` rguenth at gcc dot gnu.org
@ 2014-09-05 10:58 ` glisse at gcc dot gnu.org
3 siblings, 0 replies; 4+ messages in thread
From: glisse at gcc dot gnu.org @ 2014-09-05 10:58 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=35290
Marc Glisse <glisse at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
CC| |glisse at gcc dot gnu.org
Resolution|--- |FIXED
Target Milestone|--- |5.0
--- Comment #5 from Marc Glisse <glisse at gcc dot gnu.org> ---
This was fixed on trunk recently by Richard.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-09-05 10:58 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <bug-35290-4@http.gcc.gnu.org/bugzilla/>
2010-11-09 23:11 ` [Bug middle-end/35290] Missing dead store elimination xinliangli at gmail dot com
2010-11-09 23:22 ` [Bug tree-optimization/35290] " pinskia at gcc dot gnu.org
2010-11-10 12:32 ` rguenth at gcc dot gnu.org
2014-09-05 10:58 ` glisse at gcc dot gnu.org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).