[Bug tree-optimization/37145] [4.4 Regression] XFAILs from PRE rewrite

[Bug tree-optimization/37145] [4.4 Regression] XFAILs from PRE rewrite

[rguenth at gcc dot gnu dot org]

------- Comment #1 from rguenth at gcc dot gnu dot org  2008-08-17 20:08 -------
Mine.


-- 

rguenth at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |rguenth at gcc dot gnu dot
                   |dot org                     |org
             Status|UNCONFIRMED                 |ASSIGNED
     Ever Confirmed|0                           |1
   Last reconfirmed|0000-00-00 00:00:00         |2008-08-17 20:08:17
               date|                            |
   Target Milestone|---                         |4.4.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37145

[Bug tree-optimization/37145] New: [4.4 Regression] XFAILs from PRE rewrite

[rguenth at gcc dot gnu dot org]

We still would have

FAIL: gcc.dg/tree-ssa/ssa-fre-7.c scan-tree-dump-times fre "Inserted pretmp" 1
FAIL: gcc.dg/tree-ssa/ssa-fre-7.c scan-tree-dump-times fre "Replaced a.u.f with
pretmp" 3
FAIL: gcc.dg/tree-ssa/ssa-fre-7.c scan-tree-dump-times fre "Replaced a.u.k with
j" 1
FAIL: gcc.dg/tree-ssa/ssa-fre-7.c scan-tree-dump fre "=
VIEW_CONVERT_EXPR<float>\\(j_"
FAIL: gcc.dg/tree-ssa/ssa-fre-7.c scan-tree-dump optimized "return j"
FAIL: gcc.dg/tree-ssa/ssa-fre-8.c scan-tree-dump-times fre "Replaced u.f with
pretmp" 2
FAIL: gcc.dg/tree-ssa/ssa-fre-8.c scan-tree-dump-times fre "Inserted pretmp" 2
FAIL: gcc.dg/tree-ssa/ssa-fre-9.c scan-tree-dump-times fre "Eliminated: 1" 2
FAIL: gcc.dg/tree-ssa/ssa-fre-9.c scan-tree-dump-times fre "Insertions: 1" 2
FAIL: gcc.dg/tree-ssa/ssa-pre-15.c scan-tree-dump optimized "= 0;"

but they were XFAILed with

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=138005
Log:
2008-07-20  Daniel Berlin  <dberlin@dberlin.org>

        * gcc.dg/tree-ssa/ssa-fre-7.c: XFAIL.
        * gcc.dg/tree-ssa/ssa-fre-8.c: Ditto.
        * gcc.dg/tree-ssa/ssa-fre-9.c: Ditto.
        * gcc.dg/tree-ssa/ssa-fre-13.c: Ditto.
        * gcc.dg/tree-ssa/ssa-fre-14.c: Ditto.
        * gcc.dg/tree-ssa/ssa-fre-17.c: Ditto.
        * gcc.dg/tree-ssa/ssa-pre-15.c: Ditto.
        * gcc.dg/tree-ssa/loadpre1.c: PASS.


-- 
           Summary: [4.4 Regression] XFAILs from PRE rewrite
           Product: gcc
           Version: 4.4.0
            Status: UNCONFIRMED
          Keywords: missed-optimization, xfail
          Severity: normal
          Priority: P3
         Component: tree-optimization
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: rguenth at gcc dot gnu dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37145

[Bug tree-optimization/37145] [4.4 Regression] XFAILs from PRE rewrite

[rguenth at gcc dot gnu dot org]

-- 

rguenth at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P2


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37145

[Bug tree-optimization/37145] [4.4 Regression] XFAILs from PRE rewrite

[rguenth at gcc dot gnu dot org]

------- Comment #2 from rguenth at gcc dot gnu dot org  2008-09-22 11:54 -------
Technically gcc.dg/tree-ssa/ssa-fre-10.c also fails (or rather it doesn't
properly test for what it is supposed to).


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37145

[Bug tree-optimization/37145] [4.4 Regression] XFAILs from PRE rewrite

[rguenth at gcc dot gnu dot org]

------- Comment #3 from rguenth at gcc dot gnu dot org  2008-09-22 11:54 -------
Subject: Bug 37145

Author: rguenth
Date: Mon Sep 22 11:53:29 2008
New Revision: 140547

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=140547
Log:
2008-09-22  Richard Guenther  <rguenther@suse.de>

        PR tree-optimization/37145
        * tree-ssa-pre.c (fully_constant_expression): Simplify builtin calls.
        (phi_translate_1): Constant fold references.

        * gcc.dg/tree-ssa/ssa-pre-15.c: Remove XFAIL.

Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/testsuite/ChangeLog
    trunk/gcc/testsuite/gcc.dg/tree-ssa/ssa-pre-15.c
    trunk/gcc/tree-ssa-pre.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37145

[Bug tree-optimization/37145] [4.4 Regression] XFAILs from PRE rewrite, SCCVN union optimization disabled

[rguenth at gcc dot gnu dot org]

------- Comment #4 from rguenth at gcc dot gnu dot org  2008-09-22 12:22 -------
All XFAILs left are due to the SCCVN union value-numbering optimization being
disabled:

#if FIXME
          /* If this is a reference to a union member, record the union
             member size as operand.  Do so only if we are doing
             expression insertion (during FRE), as PRE currently gets
             confused with this.  */
          if (may_insert
              && TREE_CODE (DECL_CONTEXT (TREE_OPERAND (ref, 1))) == UNION_TYPE
              && integer_zerop (DECL_FIELD_OFFSET (TREE_OPERAND (ref, 1)))
              && integer_zerop (DECL_FIELD_BIT_OFFSET (TREE_OPERAND (ref, 1))))
            temp.op0 = TYPE_SIZE (TREE_TYPE (TREE_OPERAND (ref, 1)));
          else
#endif

if you simply enable it it miscompiles GCC.  The testsuites of all languages
are clean though.


-- 

rguenth at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[4.4 Regression] XFAILs from|[4.4 Regression] XFAILs from
                   |PRE rewrite                 |PRE rewrite, SCCVN union
                   |                            |optimization disabled


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37145

[Bug tree-optimization/37145] [4.4 Regression] XFAILs from PRE rewrite, SCCVN union optimization disabled

[rguenth at gcc dot gnu dot org]

------- Comment #5 from rguenth at gcc dot gnu dot org  2008-09-22 19:17 -------
Fixed.


-- 

rguenth at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37145

[Bug tree-optimization/37145] [4.4 Regression] XFAILs from PRE rewrite, SCCVN union optimization disabled

[rguenth at gcc dot gnu dot org]

------- Comment #6 from rguenth at gcc dot gnu dot org  2008-09-22 19:17 -------
Subject: Bug 37145

Author: rguenth
Date: Mon Sep 22 19:15:43 2008
New Revision: 140562

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=140562
Log:
2008-09-22  Richard Guenther  <rguenther@suse.de>

        PR tree-optimization/37145
        * tree-ssa-sccvn.c (copy_reference_ops_from_ref): Re-enable
        value-numbering union accesses with their offset and size only.
        (visit_reference_op_load): Fix simplification of inserted conversions.
        * tree-ssa-pre.c (find_or_generate_expression): Do not
        recursively generate expressions if running FRE.

        * gcc.c-torture/compile/20080922-1.c: New testcase.
        * gcc.dg/tree-ssa/ssa-fre-7.c: Remove XFAIL.
        * gcc.dg/tree-ssa/ssa-fre-8.c: Likewise.
        * gcc.dg/tree-ssa/ssa-fre-9.c: Likewise.

Added:
    trunk/gcc/testsuite/gcc.c-torture/compile/20080922-1.c
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/testsuite/ChangeLog
    trunk/gcc/testsuite/gcc.dg/tree-ssa/ssa-fre-7.c
    trunk/gcc/testsuite/gcc.dg/tree-ssa/ssa-fre-8.c
    trunk/gcc/testsuite/gcc.dg/tree-ssa/ssa-fre-9.c
    trunk/gcc/tree-ssa-pre.c
    trunk/gcc/tree-ssa-sccvn.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37145