[Bug c++/43167] Warnings should not be disabled when instantiating templates defined in system headers

[Bug c++/43167] Warnings should not be disabled when instantiating templates defined in system headers

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=43167

Jonathan Wakely <redi at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |redboltz at gmail dot com

--- Comment #21 from Jonathan Wakely <redi at gcc dot gnu.org> ---
*** Bug 95765 has been marked as a duplicate of this bug. ***

[Bug c++/43167] Warnings should not be disabled when instantiating templates defined in system headers

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=43167

Jonathan Wakely <redi at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jlame646 at gmail dot com

--- Comment #22 from Jonathan Wakely <redi at gcc dot gnu.org> ---
*** Bug 114237 has been marked as a duplicate of this bug. ***

[Bug c++/43167] Warnings should not be disabled when instantiating templates defined in system headers

[redi at gcc dot gnu dot org]

------- Comment #14 from redi at gcc dot gnu dot org  2010-04-21 19:02 -------
Bug 43820 shows cases where libstdc++ was *relying* on the front-end issuing
warnings about calling delete with a pointer to incomplete types.  I'm going to
change the library code to handle it instead, but it's an extra data point
related to this bug


-- 

redi at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |redi at gcc dot gnu dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43167

[Bug c++/43167] Warnings should not be disabled when instantiating templates defined in system headers

[ian at airs dot com]

------- Comment #13 from ian at airs dot com  2010-02-25 00:17 -------
Paolo: It is definitely a complicated case, the concern about false positives
is entirely valid.  This leads us to introducing more command line options,
plus getting #pragma GCC diagnostic to work.  I'm not sure what the best
solution is.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43167

[Bug c++/43167] Warnings should not be disabled when instantiating templates defined in system headers

[manu at gcc dot gnu dot org]

------- Comment #12 from manu at gcc dot gnu dot org  2010-02-24 23:20 -------
(In reply to comment #11)
> Note this is much better than what it was in 4.3 where std::vector<long> was
> shown as:
> std::vector<long int, std::allocator<long int> > >

That part looks better GCC, however, in the context information, the clang
output is far clearer.

Why we print the file with no location info just above the "In function"?


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43167

[Bug c++/43167] Warnings should not be disabled when instantiating templates defined in system headers

[pinskia at gcc dot gnu dot org]

------- Comment #11 from pinskia at gcc dot gnu dot org  2010-02-24 23:00 -------
Note this is much better than what it was in 4.3 where std::vector<long> was
shown as:
std::vector<long int, std::allocator<long int> > >


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |diagnostic


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43167

[Bug c++/43167] Warnings should not be disabled when instantiating templates defined in system headers

[pinskia at gcc dot gnu dot org]

------- Comment #10 from pinskia at gcc dot gnu dot org  2010-02-24 22:56 -------
looks like the terminial is wrapping funny.


In file included from
/home/apinski/local-gcc/lib/gcc/x86_64-unknown-linux-gnu/4.5.0/../../../../include/c++/4.5.0/numeric:62:0,
                 from t.cc:2:
/home/apinski/local-gcc/lib/gcc/x86_64-unknown-linux-gnu/4.5.0/../../../../include/c++/4.5.0/bits/stl_numeric.h:
In function '_Tp std::accumulate(_InputIterator, _InputIterator, _Tp) [with
_InputIterator = __gnu_cxx::__normal_iterator<const long int*, std::vector<long
int> >, _Tp = int]':
t.cc:6:57:   instantiated from here
/home/apinski/local-gcc/lib/gcc/x86_64-unknown-linux-gnu/4.5.0/../../../../include/c++/4.5.0/bits/stl_numeric.h:123:2:
warning: conversion to 'int' from 'long int' may alter its value


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43167

[Bug c++/43167] Warnings should not be disabled when instantiating templates defined in system headers

[manu at gcc dot gnu dot org]

------- Comment #9 from manu at gcc dot gnu dot org  2010-02-24 22:52 -------
(In reply to comment #7)
> I don't know about icc, but see also http://llvm.org/PR6418 .

Out of curiosity. Is it really the output of g++ so messy compared with clang,
or is it an artifact of copy+paste from the console?

It looks totally broken (printing "In function" after filename?)


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43167

[Bug c++/43167] Warnings should not be disabled when instantiating templates defined in system headers

[paolo dot carlini at oracle dot com]

------- Comment #8 from paolo dot carlini at oracle dot com  2010-02-24 22:47 -------
ICC doesn't warn (emits another spurious warning, by the way, which has nothing
to do with this issue). More generally, compilers using the EDG front-end, eg,
Comeau, apparently do not warn at the most strict diagnostic level. Likewise
SunStudio. I'm not saying we cannot do better, just, seems a pretty
sophisticated goal, and really, in my opinion, we should be *very* careful with
false positive, because normally it's unacceptable to emit warnings about
internal details of the implementation.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43167

[Bug c++/43167] Warnings should not be disabled when instantiating templates defined in system headers

[ian at airs dot com]

------- Comment #7 from ian at airs dot com  2010-02-24 22:33 -------
I don't know about icc, but see also http://llvm.org/PR6418 .


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43167

[Bug c++/43167] Warnings should not be disabled when instantiating templates defined in system headers

[paolo dot carlini at oracle dot com]

------- Comment #6 from paolo dot carlini at oracle dot com  2010-02-24 21:43 -------
Out of curiosity: what happens with ICC? (normally installed with the system
libstdc++ as C++ run-time)?


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43167

[Bug c++/43167] Warnings should not be disabled when instantiating templates defined in system headers

[ian at airs dot com]

------- Comment #5 from ian at airs dot com  2010-02-24 20:56 -------
The use of long long is irrelevant here.

PR 30500 appears to be about non-dependent types.  So let's make this bug be
about dependent types.  I know that makes it harder, but it seems to me to be
the right thing to do.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43167

[Bug c++/43167] Warnings should not be disabled when instantiating templates defined in system headers

[pinskia at gcc dot gnu dot org]

------- Comment #4 from pinskia at gcc dot gnu dot org  2010-02-24 19:41 -------
>This warning indicates a problem with user code. 

Or is it?  Since long long does not exist in C++03 :).


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43167

[Bug c++/43167] Warnings should not be disabled when instantiating templates defined in system headers

[pinskia at gcc dot gnu dot org]

------- Comment #3 from pinskia at gcc dot gnu dot org  2010-02-24 19:38 -------
Found it, PR 30500 was the exact bug which changed this behavior :).


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43167

[Bug c++/43167] Warnings should not be disabled when instantiating templates defined in system headers

[pinskia at gcc dot gnu dot org]

------- Comment #2 from pinskia at gcc dot gnu dot org  2010-02-24 19:37 -------
PR 36760 is an example where it was asking the opposite way.  I thought there
was more than that bug though.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43167

[Bug c++/43167] Warnings should not be disabled when instantiating templates defined in system headers

[pinskia at gcc dot gnu dot org]

------- Comment #1 from pinskia at gcc dot gnu dot org  2010-02-24 19:35 -------
There was a bug asking the opposite way IIRC.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43167