[Bug fortran/44350] accepts illegal fortran in BLOCK DATA

[Bug fortran/44350] accepts illegal fortran in BLOCK DATA

[zeccav at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44350

Vittorio Zecca <zeccav at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|4.5.0                       |4.8.0

--- Comment #2 from Vittorio Zecca <zeccav at gmail dot com> 2013-04-16 08:50:22 UTC ---
I still have the same bug on gfortran 4.8.0.
This is same as 50516.

[Bug fortran/44350] accepts illegal fortran in BLOCK DATA

[dominiq at lps dot ens.fr]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44350

--- Comment #4 from Dominique d'Humieres <dominiq at lps dot ens.fr> ---
*** Bug 50516 has been marked as a duplicate of this bug. ***

[Bug fortran/44350] accepts illegal fortran in BLOCK DATA

[dominiq at lps dot ens.fr]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44350

--- Comment #5 from Dominique d'Humieres <dominiq at lps dot ens.fr> ---
Also present on trunk (4.9) at revision 203859.

[Bug fortran/44350] accepts illegal fortran in BLOCK DATA

[burnus at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44350

Tobias Burnus <burnus at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |burnus at gcc dot gnu.org

--- Comment #6 from Tobias Burnus <burnus at gcc dot gnu.org> ---
Incomplete draft patch. It probably rejects too much and doesn't permit all
which is listed in comment 1.

--- a/gcc/fortran/parse.c
+++ b/gcc/fortran/parse.c
@@ -2629,4 +2629,19 @@ loop:
          break;
       }
+  else if (gfc_current_state () == COMP_BLOCK_DATA)
+    switch (st)
+      {
+       case ST_ATTR_DECL:
+       case ST_COMMON:
+       case ST_TYPE:
+       case ST_END_BLOCK_DATA:
+         break;
+
+       default:
+         gfc_error ("%s statement is not allowed inside of BLOCK DATA at %C",
+                    gfc_ascii_statement (st));
+         reject_statement ();
+         break;
+      }

   /* If we find a statement that can not be followed by an IMPLICIT statement

[Bug fortran/44350] accepts illegal fortran in BLOCK DATA

[burnus at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44350

--- Comment #7 from Tobias Burnus <burnus at gcc dot gnu.org> ---
Author: burnus
Date: Tue Oct 29 21:48:02 2013
New Revision: 204185

URL: http://gcc.gnu.org/viewcvs?rev=204185&root=gcc&view=rev
Log:
2013-10-29  Tobias Burnus  <burnus@net-b.de>

        PR fortran/44350
        * parse.c (parse_spec): Add C1116 constraint
        check for BLOCK DATA.

2013-10-29  Tobias Burnus  <burnus@net-b.de>

        PR fortran/44350
        * gfortran.dg/blockdata_8.f90: New.


Added:
    trunk/gcc/testsuite/gfortran.dg/blockdata_8.f90
Modified:
    trunk/gcc/fortran/ChangeLog
    trunk/gcc/fortran/parse.c
    trunk/gcc/testsuite/ChangeLog

[Bug fortran/44350] accepts illegal fortran in BLOCK DATA

[burnus at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44350

Tobias Burnus <burnus at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #8 from Tobias Burnus <burnus at gcc dot gnu.org> ---
FIXED on the trunk (4.9).

Thanks for the report!

[Bug fortran/44350] accepts illegal fortran in BLOCK DATA

[burnus at gcc dot gnu dot org]

------- Comment #1 from burnus at gcc dot gnu dot org  2010-06-01 07:39 -------
CONFIRM and no regression. Thanks for the report.

For the block data construct (F2008, 11.3) the compiler shall diagnose the
following constraints:

C1116 (R1120) A block-data specification-part shall contain only definitions of
derived-type definitions and ASYNCHRONOUS, BIND, COMMON, DATA, DIMENSION,
EQUIVALENCE, IMPLICIT, INTRINSIC, PARAMETER, POINTER, SAVE, TARGET, USE,
VOLATILE, and type declaration statements.

C1117 (R1120) A type declaration statement in a block-data specification-part
shall not contain ALLOCATABLE, EXTERNAL, or BIND attribute specifiers.


-- 

burnus at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1
           Keywords|                            |accepts-invalid
   Last reconfirmed|0000-00-00 00:00:00         |2010-06-01 07:39:16
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44350