[Bug fortran/44646] [F2008] Implement DO CONCURRENT

[Bug fortran/44646] [F2008] Implement DO CONCURRENT

[burnus at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44646

--- Comment #1 from Tobias Burnus <burnus at gcc dot gnu.org> 2011-09-05 07:42:29 UTC ---
Parser patch: http://gcc.gnu.org/ml/fortran/2011-09/msg00002.html

TODO as follow up:

* Replace "Sorry" by a real implementation in trans-stmt.c
  Note: Needs support for MASK= as allowed by the for-all header,
  reusing trans_forall will not work - and will generate slow code.

* Implement type-spec support for "forall" and "do concurrent":
  "(integer(8) :: i = 1:5:2)"

* Add documentation to gfc-internal.texi, update gfortran.texi (F2003 status)
  and the wiki

* Try to make use of the constraints for the middle end (optimization,
  autoparallelization), if possible.
  As Cilk+ does something like that, one can piggyback on their effort, either
  after Cilk+ is merged or by forward porting the change from the Cilk+ branch
  to the trunk.
  Cf. http://gcc.gnu.org/ml/gcc/2011-09/msg00021.html
  and http://gcc.gnu.org/ml/gcc/2011-08/msg00279.html

* Optionally (-fdo-concurrent=...?), parallelize the loop (e.g. by adding
  OpenMP pragmas).

[Bug fortran/44646] [F2008] Implement DO CONCURRENT

[burnus at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44646

--- Comment #2 from Tobias Burnus <burnus at gcc dot gnu.org> 2011-09-06 08:28:50 UTC ---
(In reply to comment #1)
> TODO as follow up:
> 
> * Replace "Sorry" by a real implementation in trans-stmt.c

Patch: http://gcc.gnu.org/ml/fortran/2011-09/msg00005.html


> * Implement type-spec support for "forall" and "do concurrent":
>   "(integer(8) :: i = 1:5:2)"

See F2008, "16.4 Statement and construct entities" (esp. paragraph 5 and 6) for
the semantic [and R752/C735 for the syntax].

[Bug fortran/44646] [F2008] Implement DO CONCURRENT

[burnus at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44646

--- Comment #3 from Tobias Burnus <burnus at gcc dot gnu.org> 2011-09-08 06:38:17 UTC ---
Author: burnus
Date: Thu Sep  8 06:38:13 2011
New Revision: 178677

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=178677
Log:
gcc/fortran/
2011-09-08  Tobias Burnus  <burnus@net-b.de>

        PR fortran/44646
        * decl.c (gfc_match_entry, gfc_match_end): Handle
        * COMP_DO_CONCURRENT.
        * dump-parse-tree.c (show_code_node): Handle EXEC_DO_CONCURRENT.
        * gfortran.h (gfc_exec_op): Add EXEC_DO_CONCURRENT.
        * match.c (gfc_match_critical, match_exit_cycle,
        * gfc_match_stopcode,
        lock_unlock_statement, sync_statement, gfc_match_allocate,
        gfc_match_deallocate, gfc_match_return): Add DO CONCURRENT diagnostic.
        (gfc_match_do): Match DO CONCURRENT.
        (match_derived_type_spec, match_type_spec, gfc_free_forall_iterator,
        match_forall_iterator, match_forall_header, match_simple_forall,
        gfc_match_forall): Move up in the file.
        * parse.c (check_do_closure, parse_do_block): Handle do
        * concurrent.
        * parse.h (gfc_compile_state): Add COMP_DO_CONCURRENT.
        * resolve.c (do_concurrent_flag): New global variable.
        (resolve_function, pure_subroutine, resolve_branch,
        gfc_resolve_blocks, resolve_code, resolve_types): Add do concurrent
        diagnostic.
        * st.c (gfc_free_statement): Handle EXEC_DO_CONCURRENT.
        * trans-stmt.c (gfc_trans_do_concurrent): New function.
        (gfc_trans_forall_1): Handle do concurrent.
        * trans-stmt.h (gfc_trans_do_concurrent): New function
        * prototype.
        * trans.c (trans_code): Call it.
        * frontend-passes.c (gfc_code_walker): Handle
        * EXEC_DO_CONCURRENT.

gcc/testsuite/
2011-09-08  Tobias Burnus  <burnus@net-b.de>

        PR fortran/44646
        * gfortran.dg/do_concurrent_1.f90: New.
        * gfortran.dg/do_concurrent_2.f90: New.


Added:
    trunk/gcc/testsuite/gfortran.dg/do_concurrent_1.f90
    trunk/gcc/testsuite/gfortran.dg/do_concurrent_2.f90
Modified:
    trunk/gcc/fortran/ChangeLog
    trunk/gcc/fortran/decl.c
    trunk/gcc/fortran/dump-parse-tree.c
    trunk/gcc/fortran/frontend-passes.c
    trunk/gcc/fortran/gfortran.h
    trunk/gcc/fortran/match.c
    trunk/gcc/fortran/parse.c
    trunk/gcc/fortran/parse.h
    trunk/gcc/fortran/resolve.c
    trunk/gcc/fortran/st.c
    trunk/gcc/fortran/trans-stmt.c
    trunk/gcc/fortran/trans-stmt.h
    trunk/gcc/fortran/trans.c
    trunk/gcc/testsuite/ChangeLog

[Bug fortran/44646] [F2008] Implement DO CONCURRENT

[burnus at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44646

--- Comment #4 from Tobias Burnus <burnus at gcc dot gnu.org> ---
Now that Aldy's/Jakub's OMP_SIMD patch (backend only) is in, r202029, - we can
use it to annotate DO CONCURRENT loops. (The semantics should be the same - and
match vector length of infinity.)

For the usage, see also gomp-4_0-branch or the Cilk branches.

[Bug fortran/44646] [F2008] Implement DO CONCURRENT

[burnus at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44646

--- Comment #5 from Tobias Burnus <burnus at gcc dot gnu.org> ---
Author: burnus
Date: Thu Oct 24 16:30:22 2013
New Revision: 204023

URL: http://gcc.gnu.org/viewcvs?rev=204023&root=gcc&view=rev
Log:
2013-10-24  Tobias Burnus  <burnus@net-b.de>

        PR fortran/44646
        * trans-stmt.c (struct forall_info): Add do_concurrent field.
        (gfc_trans_forall_1): Set it for do concurrent.
        (gfc_trans_forall_loop): Mark those as annot_expr_ivdep_kind.

2013-10-24  Tobias Burnus  <burnus@net-b.de>

        PR fortran/44646
        * gfortran.dg/vect/vect-do-concurrent-1.f90: New.


Added:
    trunk/gcc/testsuite/gfortran.dg/vect/vect-do-concurrent-1.f90
Modified:
    trunk/gcc/fortran/ChangeLog
    trunk/gcc/fortran/trans-stmt.c
    trunk/gcc/testsuite/ChangeLog

[Bug fortran/44646] [F2008] Implement DO CONCURRENT

[burnus at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44646

--- Comment #6 from Tobias Burnus <burnus at gcc dot gnu.org> ---
(In reply to Tobias Burnus from comment #1)
> TODO as follow up:
> * Implement type-spec support for "forall" and "do concurrent":
>   "(integer(8) :: i = 1:5:2)"
> 
> * Try to make use of the constraints for the middle end

That has now been implemented (comment 5) using ANNOTATE_EXPR's
annot_expr_ivdep_kind (r204021, PR33426).

> * Optionally (-fdo-concurrent=...?), parallelize the loop (e.g. by adding
>   OpenMP pragmas or using Cilk).

[Bug fortran/44646] [F2008] Implement DO CONCURRENT

[tkoenig at gcc dot gnu dot org]

-- 

tkoenig at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tkoenig at gcc dot gnu dot
                   |                            |org
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1
   Last reconfirmed|0000-00-00 00:00:00         |2010-06-23 20:42:48
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44646