[Bug c/44949] extend Wparentheses from & to &=

[Bug c/44949] extend Wparentheses from & to &=

[marc.glisse at normalesup dot org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44949

--- Comment #1 from Marc Glisse <marc.glisse at normalesup dot org> 2011-08-06 20:49:40 UTC ---
Created attachment 24935
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=24935
hack

It is an easy enough hack to call the Wparentheses code for &= and others (the
warning says "&" instead of "&=", it isn't a clean patch) so I can test on real
code. And it seems painful. It warns on code like: a |= b & c; where it is
quite clear we could never intend (a|=b)&c;. Restricting the warning to the
case where the result of the expression is used should improve things, except
that I don't know how to access that information...

[Bug c/44949] extend Wparentheses from & to &=

[gsmecher at threespeedlogic dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=44949

Graeme Smecher <gsmecher at threespeedlogic dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |gsmecher at threespeedlogic dot co
                   |                            |m

--- Comment #3 from Graeme Smecher <gsmecher at threespeedlogic dot com> ---
Another instance of this bug in the wild, and some encouragement to fix it:

  if(a /= b) {} // whoops - no warning, but highly suspicious

The "/=" corresponds to the inequality operators in several other languages (at
least: ADA, VHDL, Erlang, Fortran). It's a fairly easy typo to make when
switching between them and can be hard to spot when under-caffeinated.