[Bug bootstrap/45372] warning coverage.c assigns -1 to unsigned, suggest -1u

[Bug bootstrap/45372] warning coverage.c assigns -1 to unsigned, suggest -1u

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=45372

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
   Target Milestone|---                         |4.7.0
             Status|UNCONFIRMED                 |RESOLVED

--- Comment #4 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Warnings during the first stage will not always be correct.


Anyways this has been fixed since r0-108388 which changes the code a lot and
removed the assignment.
So all fixed for GCC 4.7.0.

[Bug bootstrap/45372] New: warning coverage.c assigns -1 to unsigned, suggest -1u

[jay dot krell at cornell dot edu]

just a warning, not an error
bootstrapping from non-gcc


"/home/jay/src/gcc-4.5.1/gcc/coverage.c", line 174: warning: initializer does
not fit or is out of range: -1
"/home/jay/src/gcc-4.5.1/gcc/coverage.c", line 330: warning: initializer does
not fit or is out of range: -1


-bash-3.00$ uname -a
SunOS ssol 5.10 Generic_139555-08 sun4u sparc SUNW,Sun-Blade-100


 /home/jay/src/gcc-4.5.1/configure \
        -disable-shared \
        -target=sparc64-sun-solaris2.10 \
        -with-mpfr=/home/jay \
        -disable-nls \
        -prefix=/home/jay \
        -disable-bootstrap \
        -with-as=/usr/ccs/bin/as


read_counts_file (void)
...
gcov_unsigned_t checksum = -1;  # line 174


gcov_type *
get_coverage_counts
...
gcov_unsigned_t checksum = -1; # line 330


bootstrap from:

-bash-3.00$ cc -V
cc: Sun C 5.9 SunOS_sparc Patch 124867-01 2007/07/12
usage: cc [ options] files.  Use 'cc -flags' for details


-1u gives no warning.
nor does (unsigned)-1
nor does, I suspect, (gcov_unsigned_t)-1


-- 
           Summary: warning coverage.c assigns -1 to unsigned, suggest -1u
           Product: gcc
           Version: 4.5.1
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: bootstrap
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: jay dot krell at cornell dot edu


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45372

[Bug bootstrap/45372] warning coverage.c assigns -1 to unsigned, suggest -1u

[jay dot krell at cornell dot edu]

------- Comment #1 from jay dot krell at cornell dot edu  2010-08-21 22:13 -------
clarification, where I assert what gives no warning, I was just testing with
like:

-bash-3.00$ cat 1.c
unsigned a = (unsigned)-1;
unsigned b = (0u - 1u);

I didn't yet test changing coverage.c.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45372

[Bug bootstrap/45372] warning coverage.c assigns -1 to unsigned, suggest -1u

[schwab at linux-m68k dot org]

------- Comment #2 from schwab at linux-m68k dot org  2010-08-22 08:16 -------
Assigning -1 to an unsigned type is always safe.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45372

[Bug bootstrap/45372] warning coverage.c assigns -1 to unsigned, suggest -1u

[jay dot krell at cornell dot edu]

------- Comment #3 from jay dot krell at cornell dot edu  2010-08-22 08:56 -------
Best imho to put in the cast to quash the warning.
To be warning free -- esp. given how close you already are.
Sometimes I think warning-free across a range of compilers is untenable.
But you are in fact already very close.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45372