[Bug lto/47334] New: g++.dg/torture/pr31863.C -O2 -flto FAILs without visibility

[Bug lto/47334] New: g++.dg/torture/pr31863.C -O2 -flto FAILs without visibility

[ro at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47334

           Summary: g++.dg/torture/pr31863.C -O2 -flto FAILs without
                    visibility
           Product: gcc
           Version: 4.6.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: lto
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: ro@gcc.gnu.org
              Host: *-*-solaris2.[89], mips-sgi-irix6.5
            Target: *-*-solaris2.[89], mips-sgi-irix6.5
             Build: *-*-solaris2.[89], mips-sgi-irix6.5


On platforms without visibility support, g++.dg/torture/pr31863.C  -O2 -flto
FAILs:

FAIL: g++.dg/torture/pr31863.C  -O2 -flto  (test for excess errors)
Excess errors:
lto1: warning: visibility attribute not supported in this configuration;
ignored [-Wattributes]
[...]

LTO tests using lto.exp prune this message, but here it is not.

[Bug lto/47334] g++.dg/torture/pr31863.C -O2 -flto FAILs without visibility

[ro at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47334

Rainer Orth <ro at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2011.03.23 12:15:19
                 CC|                            |dnovillo at google dot com,
                   |                            |rguenther at suse dot de
   Target Milestone|---                         |4.7.0
     Ever Confirmed|0                           |1

--- Comment #1 from Rainer Orth <ro at gcc dot gnu.org> 2011-03-23 12:15:19 UTC ---
While I'm considering how to apply the prunes from lto.exp (lto_prune_warns) to
tests not yet using lto.exp, I've got a more fundamental question: what's the
point of trying to use visibility support on targets that don't support that
and
later pruning the resulting warning?  It seems far more sensible to me not to
try
this in the first place and thus avoid the resulting mess.

[Bug lto/47334] g++.dg/torture/pr31863.C -O2 -flto FAILs without visibility

[rguenther at suse dot de]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47334

--- Comment #2 from rguenther at suse dot de <rguenther at suse dot de> 2011-03-23 12:20:39 UTC ---
On Wed, 23 Mar 2011, ro at gcc dot gnu.org wrote:

> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47334
> 
> Rainer Orth <ro at gcc dot gnu.org> changed:
> 
>            What    |Removed                     |Added
> ----------------------------------------------------------------------------
>              Status|UNCONFIRMED                 |NEW
>    Last reconfirmed|                            |2011.03.23 12:15:19
>                  CC|                            |dnovillo at google dot com,
>                    |                            |rguenther at suse dot de
>    Target Milestone|---                         |4.7.0
>      Ever Confirmed|0                           |1
> 
> --- Comment #1 from Rainer Orth <ro at gcc dot gnu.org> 2011-03-23 12:15:19 UTC ---
> While I'm considering how to apply the prunes from lto.exp (lto_prune_warns) to
> tests not yet using lto.exp, I've got a more fundamental question: what's the
> point of trying to use visibility support on targets that don't support that
> and
> later pruning the resulting warning?  It seems far more sensible to me not to
> try
> this in the first place and thus avoid the resulting mess.

Of course.

[Bug lto/47334] g++.dg/torture/pr31863.C -O2 -flto FAILs without visibility

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47334

Richard Guenther <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.7.0                       |---

[Bug lto/47334] g++.dg/torture/pr31863.C -O2 -flto FAILs without visibility

[ro at CeBiTec dot Uni-Bielefeld.DE]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47334

--- Comment #3 from ro at CeBiTec dot Uni-Bielefeld.DE <ro at CeBiTec dot Uni-Bielefeld.DE> ---
This issue now causes new failures on Solaris 9 with Sun as:

FAIL: gcc.dg/atomic/c11-atomic-exec-1.c  -O2 -flto  (test for excess errors)

Excess errors:
/vol/gcc/src/hg/trunk/local/gcc/testsuite/gcc.dg/atomic/c11-atomic-exec-1.c:81:1
: warning: visibility attribute not supported in this configuration; ignored
[-W
attributes]
lto1: warning: visibility attribute not supported in this configuration;
ignored
 [-Wattributes]

FAIL: gcc.dg/atomic/c11-atomic-exec-2.c  -O2 -flto  (test for excess errors)
FAIL: gcc.dg/atomic/c11-atomic-exec-3.c  -O2 -flto  (test for excess errors)
FAIL: gcc.dg/atomic/c11-atomic-exec-4.c  -O2 -flto  (test for excess errors)

    Rainer

[Bug middle-end/47334] g++.dg/torture/pr31863.C -O2 -flto FAILs without visibility

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=47334

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|lto                         |middle-end
           See Also|                            |https://gcc.gnu.org/bugzill
                   |                            |a/show_bug.cgi?id=54314

--- Comment #4 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
I wonder if we should emit the warning for visibility not being supported in a
different location rather than while creating the assembly in varasm.c.
The C++ front-end sets DECL_VISIBILITY hidden even on non-user code.

[Bug middle-end/47334] g++.dg/torture/pr31863.C -O2 -flto FAILs without visibility

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=47334

--- Comment #5 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Can someone test the patch in
https://gcc.gnu.org/bugzilla/attachment.cgi?id=52057 ?

[Bug testsuite/47334] g++.dg/torture/pr31863.C -O2 -flto FAILs without visibility

[fxcoudert at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=47334

Francois-Xavier Coudert <fxcoudert at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |12.0
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #6 from Francois-Xavier Coudert <fxcoudert at gcc dot gnu.org> ---
Fixed by
https://gcc.gnu.org/git/?p=gcc.git;a=commit;h=05edf6c470ae0ab50d42f16e78e476dbcc774842

[Bug testsuite/47334] g++.dg/torture/pr31863.C -O2 -flto FAILs without visibility

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=47334

--- Comment #7 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-11 branch has been updated by Martin Liska
<marxin@gcc.gnu.org>:

https://gcc.gnu.org/g:65b768fdb1ad302a6537119305317f413bfcbe0e

commit r11-10455-g65b768fdb1ad302a6537119305317f413bfcbe0e
Author: Francois-Xavier Coudert <fxcoudert@gcc.gnu.org>
Date:   Mon Dec 27 01:13:59 2021 +0100

    LTO: Prune some warnings in the testsuite

    Warnings like:

        warning: using serial compilation of 2 LTRANS jobs
        warning: visibility attribute not supported in this configuration;
ignored\[^\n\]*" $text "" text

    are pruned by lto.exp, but not for LTO testcases when run in other parts
    of the testsuite. They will be, now.

    gcc/testsuite/ChangeLog:

            PR testsuite/47334
            PR testsuite/103823
            * lib/prune.exp: Prune some warnings related to LTO and
            visibility.

    (cherry picked from commit 05edf6c470ae0ab50d42f16e78e476dbcc774842)

[Bug testsuite/47334] g++.dg/torture/pr31863.C -O2 -flto FAILs without visibility

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=47334

--- Comment #8 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-10 branch has been updated by Martin Liska
<marxin@gcc.gnu.org>:

https://gcc.gnu.org/g:7097d2aafcae4b1cb89c28ff4fd4af18df9a2cef

commit r10-11152-g7097d2aafcae4b1cb89c28ff4fd4af18df9a2cef
Author: Francois-Xavier Coudert <fxcoudert@gcc.gnu.org>
Date:   Mon Dec 27 01:13:59 2021 +0100

    LTO: Prune some warnings in the testsuite

    Warnings like:

        warning: using serial compilation of 2 LTRANS jobs
        warning: visibility attribute not supported in this configuration;
ignored\[^\n\]*" $text "" text

    are pruned by lto.exp, but not for LTO testcases when run in other parts
    of the testsuite. They will be, now.

    gcc/testsuite/ChangeLog:

            PR testsuite/47334
            PR testsuite/103823
            * lib/prune.exp: Prune some warnings related to LTO and
            visibility.

    (cherry picked from commit 05edf6c470ae0ab50d42f16e78e476dbcc774842)