[Bug middle-end/50638] New: [4.7 Regression] emulated TLS fails

[Bug middle-end/50638] New: [4.7 Regression] emulated TLS fails

[iains at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=50638

             Bug #: 50638
           Summary: [4.7 Regression] emulated TLS fails
    Classification: Unclassified
           Product: gcc
           Version: 4.7.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: middle-end
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: iains@gcc.gnu.org
                CC: matz@gcc.gnu.org
              Host: i686-apple-darwin9
            Target: i686-apple-darwin9
             Build: i686-apple-darwin9


large number (hundreds, across languages)of emulated TLS tests fail/problem
exposed from r179618

http://gcc.gnu.org/ml/gcc-cvs/2011-10/msg00212.html

---
e.g. 
FAIL: gcc.dg/tls/nonpic-1.c (internal compiler error)

====

GNU C (GCC) version 4.7.0 20111006 (experimental) [trunk revision 179619]
(i686-apple-darwin9)
        compiled by GNU C version 4.7.0 20111005 (experimental) [trunk revision
179538], GMP version 5.0.2, MPFR version 3.0.1, MPC version 0.9
GGC heuristics: --param ggc-min-expand=30 --param ggc-min-heapsize=4096
Compiler executable checksum: 7ba46202133ec4d752524b4545ac8c82

Program received signal EXC_BAD_ACCESS, Could not access memory.
Reason: KERN_PROTECTION_FAILURE at address: 0x00000000
0x02656f48 in set_is_used (var=0x470e4840) at tree-flow-inline.h:562
562       ann->used = true;
(gdb) bt
#0  0x02656f48 in set_is_used (var=0x470e4840) at tree-flow-inline.h:562
#1  0x0265ac37 in mark_all_vars_used_1 (tp=0x470e0b24,
walk_subtrees=0xbfffeb84, data=0x0) at
/GCC/gcc-live-trunk/gcc/tree-ssa-live.c:379
#2  0x02f0d0e3 in walk_tree_1 (tp=0x470e0b24, func=0x265a72c
<mark_all_vars_used_1>, data=0x0, pset=0x0, lh=0) at
/GCC/gcc-live-trunk/gcc/tree.c:10448
#3  0x0265bbff in mark_all_vars_used (expr_p=0x470bbeb8, data=0x0) at
/GCC/gcc-live-trunk/gcc/tree-ssa-live.c:595
#4  0x0265c6aa in remove_unused_locals () at
/GCC/gcc-live-trunk/gcc/tree-ssa-live.c:727
#5  0x019f79ef in execute_function_todo (data=0x8000) at
/GCC/gcc-live-trunk/gcc/passes.c:1695
#6  0x019f7422 in do_per_function (callback=0x19f78da <execute_function_todo>,
data=0x8000) at /GCC/gcc-live-trunk/gcc/passes.c:1548
#7  0x019f7b76 in execute_todo (flags=32768) at
/GCC/gcc-live-trunk/gcc/passes.c:1741
#8  0x019f856e in execute_one_pass (pass=0x34275c0) at
/GCC/gcc-live-trunk/gcc/passes.c:2087
#9  0x019f86b5 in execute_pass_list (pass=0x34275c0) at
/GCC/gcc-live-trunk/gcc/passes.c:2119
#10 0x02266222 in tree_rest_of_compilation (fndecl=0x470a5d80) at
/GCC/gcc-live-trunk/gcc/tree-optimize.c:420
#11 0x00a33edd in cgraph_expand_function (node=0x470133d8) at
/GCC/gcc-live-trunk/gcc/cgraphunit.c:1805
#12 0x00a340b8 in cgraph_expand_all_functions () at
/GCC/gcc-live-trunk/gcc/cgraphunit.c:1864
#13 0x00a34939 in cgraph_optimize () at
/GCC/gcc-live-trunk/gcc/cgraphunit.c:2141
#14 0x00a31b08 in cgraph_finalize_compilation_unit () at
/GCC/gcc-live-trunk/gcc/cgraphunit.c:1312
#15 0x00075a6b in c_write_global_declarations () at
/GCC/gcc-live-trunk/gcc/c-decl.c:9936
#16 0x01e85ef8 in compile_file () at /GCC/gcc-live-trunk/gcc/toplev.c:581
#17 0x01e88b3d in do_compile () at /GCC/gcc-live-trunk/gcc/toplev.c:1925
#18 0x01e88d21 in toplev_main (argc=25, argv=0xbffff1e8) at
/GCC/gcc-live-trunk/gcc/toplev.c:2001
#19 0x002ca1e4 in main (argc=25, argv=0xbffff1e8) at
/GCC/gcc-live-trunk/gcc/main.c:36

(gdb) call debug_tree(0x470e4840)
 <var_decl 0x470e4840 __emutls_v.e1
    type <record_type 0x470e47e0 __emutls_object BLK
        size <integer_cst 0x47009a48 constant 128>
        unit size <integer_cst 0x47009a64 constant 16>
        align 32 symtab 0 alias set -1 canonical type 0x470e47e0
        fields <field_decl 0x470e905c __size type <integer_type 0x4701c3c0
unsigned int>
            unsigned SI file (null) line 0 col 0
            size <integer_cst 0x4700955c constant 32>
            unit size <integer_cst 0x47009578 constant 4>
            align 32 offset_align 128
            offset <integer_cst 0x47009594 constant 0>
            bit offset <integer_cst 0x47009620 constant 0> context <record_type
0x470e47e0 __emutls_object> chain <field_decl 0x470e9000 __align>>
        pointer_to_this <pointer_type 0x470e4a20>>
    addressable used public static ignored external BLK file
/GCC/gcc-live-trunk/gcc/testsuite/gcc.dg/tls/nonpic-1.c line 5 col 22 size
<integer_cst 0x47009a48 128> unit size <integer_cst 0x47009a64 16>
    align 32 context <translation_unit_decl 0x47024ec4 D.1637>>

[Bug middle-end/50638] [4.7 Regression] emulated TLS fails

[hp at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=50638

Hans-Peter Nilsson <hp at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2011-10-07
                 CC|                            |hp at gcc dot gnu.org
     Ever Confirmed|0                           |1

--- Comment #1 from Hans-Peter Nilsson <hp at gcc dot gnu.org> 2011-10-07 00:34:21 UTC ---
For cris-elf too, another emutls target.
The full build-gcc.sh regression list for cris-elf at r179625 (last known
working at r179611):
g++.sum g++.dg/tls/static-1.C
gcc.sum gcc.dg/debug/tls-1.c
gcc.sum gcc.dg/tls/nonpic-1.c
gcc.sum gcc.dg/tls/opt-13.c
gcc.sum gcc.dg/tls/opt-14.c
gcc.sum gcc.dg/tls/opt-5.c
gcc.sum gcc.dg/tls/opt-6.c
gcc.sum gcc.dg/tls/opt-8.c
gcc.sum gcc.dg/tls/pr24428-2.c
gcc.sum gcc.dg/tls/pr24428.c
gcc.sum gcc.dg/tls/pr45870.c
gcc.sum gcc.dg/tls/pr47715-5.c
gcc.sum gcc.dg/tls/thr-cse-1.c
gcc.sum gcc.dg/torture/tls/run-gd.c
gcc.sum gcc.dg/torture/tls/run-ie.c
gcc.sum gcc.dg/torture/tls/run-ld.c
gcc.sum gcc.dg/torture/tls/run-le.c
gcc.sum gcc.dg/torture/tls/thr-init-1.c
gcc.sum gcc.dg/torture/tls/thr-init-2.c
gfortran.sum gfortran.dg/select_type_12.f03
(the last one *may* be due to a different bug, see PR50640)

[Bug middle-end/50638] [4.7 Regression] emulated TLS fails

[hp at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=50638

--- Comment #2 from Hans-Peter Nilsson <hp at gcc dot gnu.org> 2011-10-07 00:39:03 UTC ---
(In reply to comment #1)
> For cris-elf too, another emutls target.
> The full build-gcc.sh regression list for cris-elf at r179625 (last known
> working at r179611):

Sorry, I forgot that list is truncated at 20 lines, here are the 3 ones left:
objc.sum objc.dg/torture/tls/thr-init-2.m
objc.sum objc.dg/torture/tls/thr-init-3.m
objc.sum objc.dg/torture/tls/thr-init.m

[Bug middle-end/50638] [4.7 Regression] emulated TLS fails

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=50638

Richard Guenther <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |4.7.0

--- Comment #3 from Richard Guenther <rguenth at gcc dot gnu.org> 2011-10-07 08:29:41 UTC ---
I suppose emultls needs another add_referenced_var call.

[Bug middle-end/50638] [4.7 Regression] emulated TLS fails

[ro at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=50638

Rainer Orth <ro at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ro at gcc dot gnu.org

--- Comment #4 from Rainer Orth <ro at gcc dot gnu.org> 2011-10-07 16:40:09 UTC ---
The same issue breaks bootstrap on Solaris 8 and 9/x86 (so far, SPARC probably
too) with Sun as in libgo:

/vol/gcc/src/hg/trunk/local/libgo/runtime/go-defer.c: In function '__go_defer':
/vol/gcc/src/hg/trunk/local/libgo/runtime/go-defer.c:16:1: internal compiler
error: Segmentation Fault

[Bug middle-end/50638] [4.7 Regression] emulated TLS fails

[matz at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=50638

Michael Matz <matz at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

--- Comment #5 from Michael Matz <matz at gcc dot gnu.org> 2011-10-07 16:53:59 UTC ---
Mine.  See also http://gcc.gnu.org/ml/gcc-patches/2011-10/msg00597.html .
What's the variable that causes the segfault?

[Bug middle-end/50638] [4.7 Regression] emulated TLS fails

[ro at CeBiTec dot Uni-Bielefeld.DE]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=50638

--- Comment #6 from ro at CeBiTec dot Uni-Bielefeld.DE <ro at CeBiTec dot Uni-Bielefeld.DE> 2011-10-07 16:58:40 UTC ---
> --- Comment #5 from Michael Matz <matz at gcc dot gnu.org> 2011-10-07 16:53:59 UTC ---
> Mine.  See also http://gcc.gnu.org/ml/gcc-patches/2011-10/msg00597.html .
> What's the variable that causes the segfault?

Program received signal SIGSEGV, Segmentation fault.
set_is_used (tp=0xbf674be4, 
   
Parma_Polyhedra_Library14Grid_Generator11set_divisorERK10__gmp_exprIA1_12__mpz_structS3_E=0x80475fc,
data=0x0)
    at /vol/gcc/src/hg/trunk/local/gcc/tree-flow-inline.h:562
562       ann->used = true;
(gdb) where
#0  set_is_used (tp=0xbf674be4, 
   
Parma_Polyhedra_Library14Grid_Generator11set_divisorERK10__gmp_exprIA1_12__mpz_structS3_E=0x80475fc,
data=0x0)
    at /vol/gcc/src/hg/trunk/local/gcc/tree-flow-inline.h:562
#1  mark_all_vars_used_1 (tp=0xbf674be4, 
   
Parma_Polyhedra_Library14Grid_Generator11set_divisorERK10__gmp_exprIA1_12__mpz_structS3_E=0x80475fc,
data=0x0)
    at /vol/gcc/src/hg/trunk/local/gcc/tree-ssa-live.c:379
#2  0x087b479a in walk_tree_1 (tp=0xbf674be4, 
    func=0x868f570 <mark_all_vars_used_1>, 
    ZNK23Parma_Polyhedra_Library6Matrix8num_rowsEv=0x0, pset=0x0, lh=0)
    at /vol/gcc/src/hg/trunk/local/gcc/tree.c:10457
#3  0x08690152 in mark_all_vars_used ()
    at /vol/gcc/src/hg/trunk/local/gcc/tree-ssa-live.c:595
#4  remove_unused_locals ()
    at /vol/gcc/src/hg/trunk/local/gcc/tree-ssa-live.c:727
#5  0x084e8909 in execute_function_todo (
    __gmp_exprIA1_12__mpq_structS3_EE6Status10ascii_loadERSi=0x826)
    at /vol/gcc/src/hg/trunk/local/gcc/passes.c:1695
#6  0x084e8f44 in mp_exprIA1_12__mpq_structS1_E7set_strEPKci (
    _RKNS_17Constraint_SystemEPj=0x84e87b4 <execute_function_todo>, 
    __gmp_exprIA1_12__mpq_structS3_EE6Status10ascii_loadERSi=0x826)
    at /vol/gcc/src/hg/trunk/local/gcc/passes.c:1548
#7  0x084e943e in execute_todo (2__mpz_structS7_E=2086)
    at /vol/gcc/src/hg/trunk/local/gcc/passes.c:1741
#8  0x084ec2da in execute_one_pass (essionENS_15Relation_SymbolES4_=0x923e6a0)
    at /vol/gcc/src/hg/trunk/local/gcc/passes.c:2087
#9  0x084ec601 in execute_pass_list (essionENS_15Relation_SymbolES4_=0x923e6a0)
    at /vol/gcc/src/hg/trunk/local/gcc/passes.c:2119
#10 0x084ec614 in execute_pass_list (essionENS_15Relation_SymbolES4_=0x8f6c420)
    at /vol/gcc/src/hg/trunk/local/gcc/passes.c:2120
#11 0x084ec614 in execute_pass_list (essionENS_15Relation_SymbolES4_=0x8f6bb20)
    at /vol/gcc/src/hg/trunk/local/gcc/passes.c:2120
#12 0x0860d603 in tree_rest_of_compilation (
    4NNC_PolyhedronEEESaIS3_EE6removeERKS3_=0xbf638f80)
    at /vol/gcc/src/hg/trunk/local/gcc/tree-optimize.c:420
#13 0x082927d3 in cgraph_expand_function (
   
ZN23Parma_Polyhedra_Library3BoxINS_8IntervalI10__gmp_exprIA1_12__mpq_structS4_ENS_25Interval_Restriction_NoneINS_20Interval_Info_BitsetIjNS_29Rational_Interval_Info_PolicyEEEEEEEE24generalized_affine_imageENS_8VariableENS_15Relation_SymbolERKNS_17Linear_ExpressionERKS2_IA1_12__mpz_structSJ_E=0xbf5bf668)
    at /vol/gcc/src/hg/trunk/local/gcc/cgraphunit.c:1805
#14 0x08294a15 in Status8test_allEj ()
    at /vol/gcc/src/hg/trunk/local/gcc/cgraphunit.c:1864
#15 cgraph_optimize () at /vol/gcc/src/hg/trunk/local/gcc/cgraphunit.c:2141
#16 0x08294e7b in cgraph_finalize_compilation_unit ()
    at /vol/gcc/src/hg/trunk/local/gcc/cgraphunit.c:1312
#17 0x08166724 in c_write_global_declarations ()
    at /vol/gcc/src/hg/trunk/local/gcc/c-decl.c:9936
#18 0x0859e922 in compile_file (argc=11, argv=0x804794c)
    at /vol/gcc/src/hg/trunk/local/gcc/toplev.c:581
#19 do_compile (argc=11, argv=0x804794c)
    at /vol/gcc/src/hg/trunk/local/gcc/toplev.c:1925
#20 toplev_main (argc=11, argv=0x804794c)
    at /vol/gcc/src/hg/trunk/local/gcc/toplev.c:2001
#21 0x08cacf9b in main (argc=11, argv=0x804794c)
    at /vol/gcc/src/hg/trunk/local/gcc/main.c:36
(gdb) up
#1  mark_all_vars_used_1 (tp=0xbf674be4, 
   
Parma_Polyhedra_Library14Grid_Generator11set_divisorERK10__gmp_exprIA1_12__mpz_structS3_E=0x80475fc,
data=0x0)
    at /vol/gcc/src/hg/trunk/local/gcc/tree-ssa-live.c:379
379           set_is_used (t);
(gdb) p t
$1 = (tree) 0xbf656e40
(gdb) pt
 <var_decl bf656e40 __emutls_v.__go_panic_defer
    type <record_type bf656de0 __emutls_object BLK
        size <integer_cst bf5b5a48 constant 128>
        unit size <integer_cst bf5b5a64 constant 16>
        align 32 symtab 0 alias set -1 canonical type bf656de0
        fields <field_decl bf64bf74 __size type <integer_type bf5c73c0 unsigned
int>
            unsigned SI file 
Program received signal SIGSEGV, Segmentation fault.
0xbf6dd359 in strlen () from /usr/lib/libc.so.1
The program being debugged was signaled while in a function called from GDB.
GDB remains in the frame where the signal was received.
To change this behavior use "set unwindonsignal on".
Evaluation of the expression containing the function
(debug_tree(tree_node*)) will be abandoned.
When the function is done executing, GDB will silently stop.

    Rainer

[Bug middle-end/50638] [4.7 Regression] emulated TLS fails

[matz at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=50638

--- Comment #7 from Michael Matz <matz at gcc dot gnu.org> 2011-10-07 17:00:59 UTC ---
Hmm, I can't build go due to:
../../../gcc/libgo/runtime/sigqueue.goc:79:1: internal compiler error: in
maybe_record_trace_start, at dwarf2cfi.c:2243

but that seems unrelated.

[Bug middle-end/50638] [4.7 Regression] emulated TLS fails

[matz at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=50638

--- Comment #8 from Michael Matz <matz at gcc dot gnu.org> 2011-10-07 17:02:00 UTC ---
Okay, so it's really the emutlv_v variables.  That should be fixed by the 
patch at gcc-patches.

[Bug middle-end/50638] [4.7 Regression] emulated TLS fails

[ro at CeBiTec dot Uni-Bielefeld.DE]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=50638

--- Comment #9 from ro at CeBiTec dot Uni-Bielefeld.DE <ro at CeBiTec dot Uni-Bielefeld.DE> 2011-10-07 17:03:31 UTC ---
> --- Comment #7 from Michael Matz <matz at gcc dot gnu.org> 2011-10-07 17:00:59 UTC ---
> Hmm, I can't build go due to:
> ../../../gcc/libgo/runtime/sigqueue.goc:79:1: internal compiler error: in
> maybe_record_trace_start, at dwarf2cfi.c:2243
>
> but that seems unrelated.

Doesn't happen for me on i386-pc-solaris2.[89] as of r179656.

        Rainer

[Bug middle-end/50638] [4.7 Regression] emulated TLS fails

[ro at CeBiTec dot Uni-Bielefeld.DE]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=50638

--- Comment #10 from ro at CeBiTec dot Uni-Bielefeld.DE <ro at CeBiTec dot Uni-Bielefeld.DE> 2011-10-07 17:05:11 UTC ---
> --- Comment #8 from Michael Matz <matz at gcc dot gnu.org> 2011-10-07 17:02:00 UTC ---
> Okay, so it's really the emutlv_v variables.  That should be fixed by the 
> patch at gcc-patches.

I'll try a bootstrap on a different machine, but will only be able to
report results on monday.

    Rainer

[Bug middle-end/50638] [4.7 Regression] emulated TLS fails

[dominiq at lps dot ens.fr]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=50638

--- Comment #11 from Dominique d'Humieres <dominiq at lps dot ens.fr> 2011-10-08 10:22:30 UTC ---
On x86_64-apple-darwin10 the patch in
http://gcc.gnu.org/ml/gcc-patches/2011-10/msg00597.html fixes the tls failures
(over a thousand in my tests;-).

[Bug middle-end/50638] [4.7 Regression] emulated TLS fails

[matz at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=50638

--- Comment #12 from Michael Matz <matz at gcc dot gnu.org> 2011-10-10 11:59:33 UTC ---
Author: matz
Date: Mon Oct 10 11:59:29 2011
New Revision: 179745

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=179745
Log:
        PR middle-end/50638
        * tree-emutls.c (gen_emutls_addr): Call add_referenced_var.

Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/tree-emutls.c

[Bug middle-end/50638] [4.7 Regression] emulated TLS fails

[matz at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=50638

Michael Matz <matz at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED

--- Comment #13 from Michael Matz <matz at gcc dot gnu.org> 2011-10-10 12:54:30 UTC ---
AFAIK Fixed.

[Bug middle-end/50638] [4.7 Regression] emulated TLS fails

[matz at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=50638

Michael Matz <matz at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jojelino at gmail dot com

--- Comment #14 from Michael Matz <matz at gcc dot gnu.org> 2011-10-11 11:08:17 UTC ---
*** Bug 50658 has been marked as a duplicate of this bug. ***