[Bug testsuite/53155] New: Not parallel: test for -j fails

[Bug testsuite/53155] New: Not parallel: test for -j fails

[marc.glisse at normalesup dot org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53155

             Bug #: 53155
           Summary: Not parallel: test for -j fails
    Classification: Unclassified
           Product: gcc
           Version: 4.8.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: testsuite
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: marc.glisse@normalesup.org


Hello,

in order to decide whether they should run the testsuite in parallel, the
makefiles in gcc/ and libstdc++-v3/testsuite/ use the following test:

[ "$(filter -j, $(MFLAGS))" = "-j" ]

However, at least with the gnu make 3.81 shipped by debian, MFLAGS merges all
options, so it would normally be something like -wkj, which doesn't match the
filter.

[Bug testsuite/53155] Not parallel: test for -j fails with new make

[pinskia at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53155

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Not parallel: test for -j   |Not parallel: test for -j
                   |fails                       |fails with new make

--- Comment #1 from Andrew Pinski <pinskia at gcc dot gnu.org> 2012-04-28 21:39:07 UTC ---
It works for me with the 3.8.1 from debian.
apinski@apinskidesktop:~$ cat /etc/debian_version 
6.0.3
apinski@apinskidesktop:~$ apt-cache  showpkg make
Package: make
Versions: 
3.81-8

[Bug testsuite/53155] Not parallel: test for -j fails with new make

[marc.glisse at normalesup dot org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53155

--- Comment #2 from Marc Glisse <marc.glisse at normalesup dot org> 2012-04-28 21:49:43 UTC ---
laptop-mg /tmp/m $ cat Makefile 
all:
    $(MAKE) plouf

plouf:
    echo $(MFLAGS) "$(filter -j, $(MFLAGS))"
laptop-mg /tmp/m $ make -j
make plouf
make[1]: Entering directory `/tmp/m'
echo -wj ""
-wj 
make[1]: Leaving directory `/tmp/m'

version 3.81-8.2

[Bug testsuite/53155] Not parallel: test for -j fails with new make

[pinskia at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53155

--- Comment #3 from Andrew Pinski <pinskia at gcc dot gnu.org> 2012-04-28 21:53:21 UTC ---
-j by itself fails but -j with a number passes.  This is what I use which is
why it works.

[Bug testsuite/53155] Not parallel: test for -j fails with new make

[Joost.VandeVondele at mat dot ethz.ch]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=53155

Joost VandeVondele <Joost.VandeVondele at mat dot ethz.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2014-09-03
                 CC|                            |Joost.VandeVondele at mat dot ethz
                   |                            |.ch
     Ever confirmed|0                           |1

--- Comment #4 from Joost VandeVondele <Joost.VandeVondele at mat dot ethz.ch> ---
still fails. Honestly, this made contributing my first patches much slower, as
testing took ages to complete.

[Bug testsuite/53155] Not parallel: test for -j fails with new make

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=53155

--- Comment #5 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Hmm:
apinski@xeond:~/src/upstream-gcc/ttttt$ make -j
make plouf
make[1]: Entering directory '/bajas/pinskia/src/upstream-gcc/ttttt'
echo -w -j "-j"
-w -j -j
make[1]: Leaving directory '/bajas/pinskia/src/upstream-gcc/ttttt'
apinski@xeond:~/src/upstream-gcc/ttttt$ make --version
GNU Make 4.1


Hmm, Did something change in make?

[Bug testsuite/53155] Not parallel: test for -j fails with new make

[glisse at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=53155

--- Comment #6 from Marc Glisse <glisse at gcc dot gnu.org> ---
(In reply to Andrew Pinski from comment #5)
> Hmm, Did something change in make?

It looks like make now splits -j from other flags in MFLAGS, -wkj becomes -kw
-j, so the old filters probably work now...