public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "rearnsha at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug target/53938] ARM target generates sub-optimal code (extra instructions) on load from memory Date: Mon, 05 Aug 2013 21:20:00 -0000 [thread overview] Message-ID: <bug-53938-4-Prwb0Kzbdi@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-53938-4@http.gcc.gnu.org/bugzilla/> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53938 Richard Earnshaw <rearnsha at gcc dot gnu.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|WAITING |NEW --- Comment #4 from Richard Earnshaw <rearnsha at gcc dot gnu.org> --- Trunk as of this weekend still generates: mov r3, #-536870912 ldrb r1, [r3] @ zero_extendqisi2 ldrb ip, [r3] @ zero_extendqisi2 and r1, r1, #255 ldrh r2, [r3] tst r1, #128 movne r1, #0 tst r2, #128 movne r2, #0 mov ip, ip, asl #24 ldrh r0, [r3] add r1, r1, ip, asr #24 add r2, r1, r2 mov r0, r0, asl #16 add r0, r2, r0, asr #16 bx lr The real problem is that the RTL expansion passes never generate zero- or sign-extended values directly. They expect combine to pick this up. Unfortunately, combine won't touch a memory access that is volatile. What does still surprise me is that we fail to eliminate the zero-expand operation. After expand we have: (insn 8 7 9 (set (reg:SI 126) (zero_extend:SI (mem/v:QI (reg/f:SI 124) [0 MEM[(union io *)3758096384B].uch+0 S1 A64]))) test.c:30 -1 (nil)) (insn 9 8 10 (set (reg:QI 125) (subreg:QI (reg:SI 126) 0)) test.c:30 -1 (nil)) (insn 10 9 0 (set (reg/v:SI 111 [ i ]) (and:SI (subreg:SI (reg:QI 125) 0) (const_int 255 [0xff]))) test.c:30 -1 (nil)) I would have expected at the very least that some pass would have worked out that regs 126 and 111 are equivalent.
next prev parent reply other threads:[~2013-08-05 21:20 UTC|newest] Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top 2012-07-12 10:58 [Bug target/53938] New: " gregpsmith at live dot co.uk 2012-07-12 11:27 ` [Bug target/53938] " rguenth at gcc dot gnu.org 2012-07-12 16:10 ` pinskia at gcc dot gnu.org 2012-07-12 19:09 ` gregpsmith at live dot co.uk 2013-08-05 21:20 ` rearnsha at gcc dot gnu.org [this message] 2024-01-16 22:13 ` pinskia at gcc dot gnu.org 2024-04-24 13:27 ` rsaxvc at gmail dot com
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-53938-4-Prwb0Kzbdi@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).