[Bug ada/55119] New: Ada.Directories only handles files under 2GB

[Bug ada/55119] New: Ada.Directories only handles files under 2GB

[simon at pushface dot org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55119

             Bug #: 55119
           Summary: Ada.Directories only handles files under 2GB
    Classification: Unclassified
           Product: gcc
           Version: 4.7.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: ada
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: simon@pushface.org


In adaint.c, __gnat_stat_to_attr says

    /* st_size may be 32 bits, or 64 bits which is converted to long. We
       don't return a useful value for files larger than 2 gigabytes in
       either case. */
    attr->file_length = statbuf.st_size;  /* all systems */

where attr->file_length is a long.

This fails with large files on 64-bit filesystems (eg, Mac OS X).

I _think_ that a simple fix would be, in adaint.h, to define
file_attributes.file_length as a long long.

[Bug ada/55119] Ada.Directories only handles files under 2GB

[simon at pushface dot org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55119

--- Comment #1 from simon at pushface dot org 2012-10-29 21:57:02 UTC ---
(In reply to comment #0)

> where attr->file_length is a long.

And on Mac OS X, sizeof(long) is 8. So there isn't a problem there (but the
comment in adaint.c is still wrong).

Are there systems where the size of the largest file can't be held in a long?
Shouldn't attr->file_length be an off_t?

[Bug ada/55119] Ada.Directories only handles files under 2GB

[simon at pushface dot org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=55119

--- Comment #2 from simon at pushface dot org ---
I think this is OBE: fixed 2014-08-01, r213412, by making attr->file_length
__int64.

The comment in adaint.c is still wrong! Just tested on macOS with a 5GB
download.

[Bug ada/55119] Ada.Directories only handles files under 2GB

[ebotcazou at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=55119

Eric Botcazou <ebotcazou at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
   Target Milestone|---                         |5.0
         Resolution|---                         |FIXED

--- Comment #3 from Eric Botcazou <ebotcazou at gcc dot gnu.org> ---
The comment should probably go away indeed.