public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "vz-gcc at zeitlins dot org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c++/55578] Disabling warnings inside macro definition doesn't work
Date: Tue, 04 Oct 2022 16:04:36 +0000	[thread overview]
Message-ID: <bug-55578-4-DaaGwOTo78@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-55578-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=55578

--- Comment #10 from Vadim Zeitlin <vz-gcc at zeitlins dot org> ---
There definitely was a change in behaviour in gcc 11 because I had to make this
change

https://github.com/wxWidgets/wxWidgets/commit/95c98a0b5ff71caca6654327bf341719c6587766

to avoid getting warnings with it that we didn't get with the previous
versions.

The idea there is that we define some macros whose expansion contains
declarations of overridden virtual functions, which inevitably results in
-Wsuggest-override when used in user classes using or not using "override" for
their other functions, so we have to disable this warning locally.
wxWARNING_SUPPRESS_MISSING_OVERRIDE, which expands to

    _Pragma("GCC diagnostic push")
    _Pragma("GCC diagnostic ignored \"-Wsuggest-override\"")

worked for this until gcc 11 but not with it.

  parent reply	other threads:[~2022-10-04 16:04 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-03 18:41 [Bug c++/55578] New: " ruboam at gmail dot com
2012-12-05 13:07 ` [Bug c++/55578] " paolo.carlini at oracle dot com
2012-12-09  0:31 ` pinskia at gcc dot gnu.org
2021-04-26  9:34 ` vz-gcc at zeitlins dot org
2022-10-04  0:37 ` lhyatt at gcc dot gnu.org
2022-10-04 16:04 ` vz-gcc at zeitlins dot org [this message]
2022-10-05 22:08 ` lhyatt at gcc dot gnu.org
2022-10-06  1:31 ` vz-gcc at zeitlins dot org
2022-10-06  1:58 ` lhyatt at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-55578-4-DaaGwOTo78@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).