public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "lhyatt at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c++/55578] Disabling warnings inside macro definition doesn't work
Date: Wed, 05 Oct 2022 22:08:36 +0000	[thread overview]
Message-ID: <bug-55578-4-n7X6MfmZWt@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-55578-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=55578

--- Comment #11 from Lewis Hyatt <lhyatt at gcc dot gnu.org> ---
(In reply to Vadim Zeitlin from comment #10)
> There definitely was a change in behaviour in gcc 11 because I had to make
> this change
> 
> https://github.com/wxWidgets/wxWidgets/commit/
> 95c98a0b5ff71caca6654327bf341719c6587766

Thanks for that. I made a bisectable test that compiles allheaders.cpp (without
your GCC 11-specific workaround in place) and counts the number of
-Wsuggest-override warnings, which does indeed change in GCC 11.1 vs older and
newer versions. The bisect confirmed that this issue was the same as that of
PR100796. It existed only in GCC 11.1, as it was introduced by r11-7179 and was
fixed by r12-1538, which was also backported to GCC 11.2.

This particular issue only materializes with a sufficiently large source file,
so I don't think you should find any "reasonably" sized testcase to reproduce
it. All basic examples I tried work fine in 11.1 as well. As far as I can tell,
I think your workaround should be needed only for sufficiently large
translation units (approx 100000 lines or more), not for typical size user
code, and I think it should be needed only for 11.1 and no other version. If
you know otherwise, please advise... otherwise, I think this is resolved.

  parent reply	other threads:[~2022-10-05 22:08 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-03 18:41 [Bug c++/55578] New: " ruboam at gmail dot com
2012-12-05 13:07 ` [Bug c++/55578] " paolo.carlini at oracle dot com
2012-12-09  0:31 ` pinskia at gcc dot gnu.org
2021-04-26  9:34 ` vz-gcc at zeitlins dot org
2022-10-04  0:37 ` lhyatt at gcc dot gnu.org
2022-10-04 16:04 ` vz-gcc at zeitlins dot org
2022-10-05 22:08 ` lhyatt at gcc dot gnu.org [this message]
2022-10-06  1:31 ` vz-gcc at zeitlins dot org
2022-10-06  1:58 ` lhyatt at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-55578-4-n7X6MfmZWt@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).