[Bug c++/56892] New: dllexport prevents inline inside dll

[Bug c++/56892] New: dllexport prevents inline inside dll

[geoff at telesiscomputing dot com.au]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=56892

             Bug #: 56892
           Summary: dllexport prevents inline inside dll
    Classification: Unclassified
           Product: gcc
           Version: 4.8.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: c++
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: geoff@telesiscomputing.com.au


Created attachment 29840
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=29840
Preprocessed result of: mingw32-g++.exe -v -save-temps -std=c++11 -O2 -Winline
testlib.cpp

When the dllexport attribute is used at the class level (which is most common),
any inline methods for that class will NOT be inlined inside the shared library
binary itself.  This prevents the shared library from being fully optimised,
sometimes with significant impact on performance.

Produced on mingw / gcc v4.7.2, and on mingw64 / gcc v4.8.0.

Given these three classes (testlib.hpp):

class __declspec(dllexport) A {
public:
    int fa() { return m; }
    int ga();
private:
    int m{0};
};

class __declspec(dllexport) B {
public:
    int fb();
    int gb();
private:
    int m{0};
};
inline int B::fb() { return m; }

class C {
public:
    int fc() { return m; }
    __declspec(dllexport) int gc();
private:
    int m{0};
};


Implemented as (testlib.cpp):

#include "testlib.hpp"

int A::ga() { return (fa() + 1); }

int B::gb() { return (fb() + 1); }

int C::gc() { return (fc() + 1); }


And then compiled with: -std::c++11 -O2 -Winline testlib.cpp

(The -std::c++11 is just for the in-class initializer.)

A::fa() is not inlined, and no warning is given.
B::fb() is not inlined, the compiler warns that it won't inline.
C::fc() is inlined as expected.

Almost no-one writes their classes like class C, they use class A or (less
commonly) class B.  If they use class A style code they won't even know that
their inlines are being ignored when building the library itself.

I do understand the potential issues (the theory being that exported functions
are supposed to replaceable), but if __declspec(dllexport) - a synonym for
__attrribute__((dllexport)) - is supposed to emulate the behaviour seen by the
same declaration under msvc (why else create the synonym?) then it is failing
to do so.  See this link for details:
http://msdn.microsoft.com/en-us/library/xa0d9ste.aspx

It is apparent that dllexport and dllimport are introducing additional
semantics above that of "export symbol" and "import symbol".  So the other
work-around is to stop using dllexport and dllimport and use manual .def files,
or --export-all-symbols when calling the linker.  Obviously neither options is
ideal.

It's possible that there could be overlap with this bug report:
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=50779

[Bug c++/56892] dllexport prevents inline inside dll

[geoff at telesiscomputing dot com.au]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=56892

--- Comment #1 from Geoff Worboys <geoff at telesiscomputing dot com.au> 2013-04-09 12:35:33 UTC ---
I realised I should add that I put the same code (adjusted for lack of C++11
support) through msvc v17, and can see it optimising the inline calls inside
the library binary.

[Bug c++/56892] dllexport prevents inline inside dll

[paolo.carlini at oracle dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=56892

Paolo Carlini <paolo.carlini at oracle dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ktietz at gcc dot gnu.org

--- Comment #2 from Paolo Carlini <paolo.carlini at oracle dot com> ---
Kai, can you have a look?

[Bug c++/56892] dllexport prevents inline inside dll

[ktietz at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=56892

Kai Tietz <ktietz at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |FIXED

--- Comment #3 from Kai Tietz <ktietz at gcc dot gnu.org> ---
Issue is fixed for 4.8.1+ and on trunk.
Close bug