public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug translation/56985] New: gcc/fortran/resolve.c:920: "'%s' in cannot appear in COMMON ..."
@ 2013-04-17 10:04 stigge at antcom dot de
  2021-08-30  2:53 ` [Bug fortran/56985] " pinskia at gcc dot gnu.org
                   ` (4 more replies)
  0 siblings, 5 replies; 6+ messages in thread
From: stigge at antcom dot de @ 2013-04-17 10:04 UTC (permalink / raw)
  To: gcc-bugs


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=56985

             Bug #: 56985
           Summary: gcc/fortran/resolve.c:920: "'%s' in cannot appear in
                    COMMON ..."
    Classification: Unclassified
           Product: gcc
           Version: 4.8.1
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: translation
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: stigge@antcom.de


In gcc/fortran/resolve.c:920: "'%s' in cannot appear in COMMON ..."

-> I guess the "in" is not intended?


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Bug fortran/56985] gcc/fortran/resolve.c:920: "'%s' in cannot appear in COMMON ..."
  2013-04-17 10:04 [Bug translation/56985] New: gcc/fortran/resolve.c:920: "'%s' in cannot appear in COMMON ..." stigge at antcom dot de
@ 2021-08-30  2:53 ` pinskia at gcc dot gnu.org
  2021-08-30 11:53 ` anlauf at gcc dot gnu.org
                   ` (3 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: pinskia at gcc dot gnu.org @ 2021-08-30  2:53 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=56985

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Last reconfirmed|                            |2021-08-30
             Status|UNCONFIRMED                 |NEW
     Ever confirmed|0                           |1

--- Comment #1 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
      if (UNLIMITED_POLY (csym))
        gfc_error_now ("%qs in cannot appear in COMMON at %L "
                       "[F2008:C5100]", csym->name, &csym->declared_at);


Should most likely be:
      if (UNLIMITED_POLY (csym))
        gfc_error_now ("Variable %qs in cannot appear in COMMON at %L "
                       "[F2008:C5100]", csym->name, &csym->declared_at);

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Bug fortran/56985] gcc/fortran/resolve.c:920: "'%s' in cannot appear in COMMON ..."
  2013-04-17 10:04 [Bug translation/56985] New: gcc/fortran/resolve.c:920: "'%s' in cannot appear in COMMON ..." stigge at antcom dot de
  2021-08-30  2:53 ` [Bug fortran/56985] " pinskia at gcc dot gnu.org
@ 2021-08-30 11:53 ` anlauf at gcc dot gnu.org
  2021-08-31 18:32 ` anlauf at gcc dot gnu.org
                   ` (2 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: anlauf at gcc dot gnu.org @ 2021-08-30 11:53 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=56985

anlauf at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |anlauf at gcc dot gnu.org

--- Comment #2 from anlauf at gcc dot gnu.org ---
Actually the following seems better to me, as the location is that of the
declaration and not of the COMMON block:

diff --git a/gcc/fortran/resolve.c b/gcc/fortran/resolve.c
index f641d0d4dae..8e5ed1c032c 100644
--- a/gcc/fortran/resolve.c
+++ b/gcc/fortran/resolve.c
@@ -979,7 +979,7 @@ resolve_common_vars (gfc_common_head *common_block, bool
named_common)
        }

       if (UNLIMITED_POLY (csym))
-       gfc_error_now ("%qs in cannot appear in COMMON at %L "
+       gfc_error_now ("%qs at %L cannot appear in COMMON "
                       "[F2008:C5100]", csym->name, &csym->declared_at);

       if (csym->ts.type != BT_DERIVED)

The message is checked in gcc/testsuite/gfortran.dg/unlimited_polymorphic_2.f03

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Bug fortran/56985] gcc/fortran/resolve.c:920: "'%s' in cannot appear in COMMON ..."
  2013-04-17 10:04 [Bug translation/56985] New: gcc/fortran/resolve.c:920: "'%s' in cannot appear in COMMON ..." stigge at antcom dot de
  2021-08-30  2:53 ` [Bug fortran/56985] " pinskia at gcc dot gnu.org
  2021-08-30 11:53 ` anlauf at gcc dot gnu.org
@ 2021-08-31 18:32 ` anlauf at gcc dot gnu.org
  2021-09-01 17:06 ` cvs-commit at gcc dot gnu.org
  2021-09-01 17:08 ` anlauf at gcc dot gnu.org
  4 siblings, 0 replies; 6+ messages in thread
From: anlauf at gcc dot gnu.org @ 2021-08-31 18:32 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=56985

anlauf at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|unassigned at gcc dot gnu.org      |anlauf at gcc dot gnu.org
             Status|NEW                         |ASSIGNED

--- Comment #3 from anlauf at gcc dot gnu.org ---
Submitted: https://gcc.gnu.org/pipermail/fortran/2021-August/056457.html

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Bug fortran/56985] gcc/fortran/resolve.c:920: "'%s' in cannot appear in COMMON ..."
  2013-04-17 10:04 [Bug translation/56985] New: gcc/fortran/resolve.c:920: "'%s' in cannot appear in COMMON ..." stigge at antcom dot de
                   ` (2 preceding siblings ...)
  2021-08-31 18:32 ` anlauf at gcc dot gnu.org
@ 2021-09-01 17:06 ` cvs-commit at gcc dot gnu.org
  2021-09-01 17:08 ` anlauf at gcc dot gnu.org
  4 siblings, 0 replies; 6+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2021-09-01 17:06 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=56985

--- Comment #4 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Harald Anlauf <anlauf@gcc.gnu.org>:

https://gcc.gnu.org/g:a88280cff3436d0b6ab454514e5a3b97a543e9a5

commit r12-3295-ga88280cff3436d0b6ab454514e5a3b97a543e9a5
Author: Harald Anlauf <anlauf@gmx.de>
Date:   Wed Sep 1 19:05:47 2021 +0200

    Fortran - improve wording of error message

    gcc/fortran/ChangeLog:

            PR fortran/56985
            * resolve.c (resolve_common_vars): Fix grammar and improve wording
            of error message rejecting an unlimited polymorphic in COMMON.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Bug fortran/56985] gcc/fortran/resolve.c:920: "'%s' in cannot appear in COMMON ..."
  2013-04-17 10:04 [Bug translation/56985] New: gcc/fortran/resolve.c:920: "'%s' in cannot appear in COMMON ..." stigge at antcom dot de
                   ` (3 preceding siblings ...)
  2021-09-01 17:06 ` cvs-commit at gcc dot gnu.org
@ 2021-09-01 17:08 ` anlauf at gcc dot gnu.org
  4 siblings, 0 replies; 6+ messages in thread
From: anlauf at gcc dot gnu.org @ 2021-09-01 17:08 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=56985

anlauf at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #5 from anlauf at gcc dot gnu.org ---
Fixed for gcc-12.

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2021-09-01 17:08 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-04-17 10:04 [Bug translation/56985] New: gcc/fortran/resolve.c:920: "'%s' in cannot appear in COMMON ..." stigge at antcom dot de
2021-08-30  2:53 ` [Bug fortran/56985] " pinskia at gcc dot gnu.org
2021-08-30 11:53 ` anlauf at gcc dot gnu.org
2021-08-31 18:32 ` anlauf at gcc dot gnu.org
2021-09-01 17:06 ` cvs-commit at gcc dot gnu.org
2021-09-01 17:08 ` anlauf at gcc dot gnu.org

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).