[Bug bootstrap/57125] New: Build not SMP safe; fails to build bconfig.h

[Bug bootstrap/57125] New: Build not SMP safe; fails to build bconfig.h

[enrico.scholz at informatik dot tu-chemnitz.de]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57125

             Bug #: 57125
           Summary: Build not SMP safe; fails to build bconfig.h
    Classification: Unclassified
           Product: gcc
           Version: unknown
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: bootstrap
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: enrico.scholz@informatik.tu-chemnitz.de


Created attachment 29983
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=29983
Full build log

When building gcc-4.8 (patched by OpenEmbedded) with '-j 8', the build fails
from time to time because bconfig.h can not be found.  A subsequent make
succeeds in these cases.

[Bug bootstrap/57125] Build not SMP safe; fails to build bconfig.h

[dirtyepic at gentoo dot org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57125

Ryan Hill <dirtyepic at gentoo dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |toolchain at gentoo dot org

--- Comment #1 from Ryan Hill <dirtyepic at gentoo dot org> ---
This was partially fixed by
http://gcc.gnu.org/ml/gcc-patches/2012-11/msg01682.html but gengtype.c,
gengtype-parse.c, and gengtype-state.c also include bconfig.h if
-DGENERATOR_FILE is defined.

[Bug bootstrap/57125] Build not SMP safe; fails to build bconfig.h

[vcunat at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57125

Vladimír Čunát <vcunat at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |vcunat at gmail dot com

--- Comment #2 from Vladimír Čunát <vcunat at gmail dot com> ---
In this matter I'm quite confused by the intentions of
http://gcc.gnu.org/ml/gcc-patches/2012-07/msg00273.html

It states that host object files depend on CONFIG_H, but these seem to get in
fact built with -DGENERATOR_FILE (according to build log), so through
gentype.c, they include bconfig.h instead of config.h. I don't see that
reflected in build dependencies, and more importantly, I'm not even sure this
consequence was intended/correct.
>From gcc-bugs-return-438964-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Fri Jan 03 09:23:05 2014
Return-Path: <gcc-bugs-return-438964-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 21947 invoked by alias); 3 Jan 2014 09:23:05 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 21894 invoked by uid 48); 3 Jan 2014 09:23:02 -0000
From: "jakub at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/59519] [4.9 Regression] ICE on valid code at -O3 on x86_64-linux-gnu in slpeel_update_phi_nodes_for_guard1, at tree-vect-loop-manip.c:486
Date: Fri, 03 Jan 2014 09:23:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: tree-optimization
X-Bugzilla-Version: 4.9.0
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: jakub at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Priority: P1
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 4.9.0
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields:
Message-ID: <bug-59519-4-mgtDRCvEU7@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-59519-4@http.gcc.gnu.org/bugzilla/>
References: <bug-59519-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2014-01/txt/msg00106.txt.bz2
Content-length: 1007

http://gcc.gnu.org/bugzilla/show_bug.cgi?idY519

--- Comment #8 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
(In reply to bin.cheng from comment #7)
> (In reply to Jakub Jelinek from comment #6)
> > Created attachment 31562 [details]
> > gcc49-pr59519.patch
> >
> > I wonder if this isn't just a checking issue, the two PHI nodes created in
> > *new_exit_bb have the same argument, so I think it is just fine if the two
> > PHI results are used interchangeably, later optimization passes should
> > hopefully coalesce them into a single IV.
>
> I tested one similar patch before.  It passed x86_64 bootstrap and normal
> regression test.  It failed some ada (also one go) cases if I ran regression
> test with "-O3" option.  The failures look like noise to me, which I am not
> sure about.  What's your test results?

I admit I haven't performed -O3 bootstrap but normal, saw no bootstrap failures
nor testsuite regressions.
I'll try to run make check with RUNTESTFLAGS='--target_board=unix/-O3'.

[Bug bootstrap/57125] Build not SMP safe; fails to build bconfig.h

[vbraun at physics dot upenn.edu]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57125

Volker Braun <vbraun at physics dot upenn.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |vbraun at physics dot upenn.edu

--- Comment #3 from Volker Braun <vbraun at physics dot upenn.edu> ---
As another data point, I have randomly encountered this issue on ia64 with
gcc-4.7.3 

gcc -c  -DUSE_LIBUNWIND_EXCEPTIONS  -O0 -DIN_GCC   -W -Wall -Wno-narrowing
-Wwrite-strings -Wcast-qual -Wstrict-prototypes -Wmissing-prototypes
-Wmissing-format-attribute -pedantic -Wno-long-long -Wno-variadic-macros
-Wno-overlength-strings -Wold-style-definition -Wc++-compat -fno-common
-Wno-error -DHAVE_CONFIG_H -I. -I. -I../../src/gcc -I../../src/gcc/.
-I../../src/gcc/../include -I../../src/gcc/../libcpp/include
-I/home/buildbot/build/sage/iras-1/sage_git/build/local/include
-I/home/buildbot/build/sage/iras-1/sage_git/build/local/include
-I/home/buildbot/build/sage/iras-1/sage_git/build/local/include 
-I../../src/gcc/../libdecnumber -I../../src/gcc/../libdecnumber/dpd
-I../libdecnumber    ../../src/gcc/gengtype-lex.c -o gengtype-lex.o
../../src/gcc/gengtype-lex.c:1:21: fatal error: bconfig.h: No such file or
directory
compilation terminated.
make[6]: *** [gengtype-lex.o] Error 1

[Bug bootstrap/57125] Build not SMP safe; fails to build bconfig.h

[dirtyepic at gentoo dot org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57125

--- Comment #4 from Ryan Hill <dirtyepic at gentoo dot org> ---
For 4.7, the patch in comment #1 did the trick for us.

http://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo/src/patchsets/gcc/4.7.3/gentoo/93_all_4.8.0_gengtype-lex_parallel_build.patch

[Bug bootstrap/57125] Build not SMP safe; fails to build bconfig.h

[andrew at ado dot is-a-geek.net]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=57125

Andrew Oakley <andrew at ado dot is-a-geek.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |andrew at ado dot is-a-geek.net

--- Comment #5 from Andrew Oakley <andrew at ado dot is-a-geek.net> ---
Created attachment 33419
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=33419&action=edit
Possible fix

Attached is a patch which appears to fix this issue for me (on gcc 4.8.3).

In gcc/Makefile.in there is a comment:
# The gengtype generator program is special: Two versions are built.
# One is for the build machine, and one is for the host to allow
# plugins to define their types and generate the supporting GGC
# datastructures and routines with GTY markers.
# The host object files depend on CONFIG_H, and the build objects
# on BCONFIG_H.  For the build objects, add -DGENERATOR_FILE manually,
# the build-%: rule doesn't apply to them.

The change I chose to make swaps the make dependencies around, alternatively
GENERATOR_FILE may defined in the wrong case.  I'm not sure what the right
behaviour is here, or which set of objects is which!

[Bug bootstrap/57125] Build not SMP safe; fails to build bconfig.h

[andrew at ado dot is-a-geek.net]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=57125

--- Comment #6 from Andrew Oakley <andrew at ado dot is-a-geek.net> ---
Sorry, this patch doesn't seem sufficient (perhaps I was just lucky for a
while).  Apologies for the noise.

[Bug bootstrap/57125] Build not SMP safe; fails to build bconfig.h

[dev at codyps dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=57125

dev at codyps dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dev at codyps dot com

--- Comment #7 from dev at codyps dot com ---
I'm seeing this with gentoo's gcc-4.9.2

[Bug bootstrap/57125] Build not SMP safe; fails to build bconfig.h

[vapier at gentoo dot org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=57125

Mike Frysinger <vapier at gentoo dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jakub at gcc dot gnu.org

--- Comment #8 from Mike Frysinger <vapier at gentoo dot org> ---
(In reply to Vladimír Čunát from comment #2)

i think you're spot on -- the logic is inverted

(In reply to Andrew Oakley from comment #5)

i think this patch is incorrect.  you're inverting what the Makefile explicitly
is saying to do.  namely, build/%.o should be depending on $(BCONFIG_H) and
they should be building with -DGENERATOR_FILE.  so the CFLAGS- lines need
fixing.

looking at trunk, this appears to be fixed here:
https://gcc.gnu.org/viewcvs/gcc?view=revision&revision=218325

the compile logic was inverted so that bconfig.h is included by default, and to
get config.h you have to define HOST_GENERATOR_FILE.  then the CFLAGS-xxx line
was updated to use that.

i guess we keep this open so hopefully it'll get backported to gcc-4.9 ?
>From gcc-bugs-return-482311-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Tue Mar 31 04:54:29 2015
Return-Path: <gcc-bugs-return-482311-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 120862 invoked by alias); 31 Mar 2015 04:54:28 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 120819 invoked by uid 48); 31 Mar 2015 04:54:24 -0000
From: "tom at honermann dot net" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c++/65635] New: [c++-concepts] ICE in cp_tree_equal() during class template partial specialization constraint matching
Date: Tue, 31 Mar 2015 08:12:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: new
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: c++
X-Bugzilla-Version: unknown
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: tom at honermann dot net
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: bug_id short_desc product version bug_status bug_severity priority component assigned_to reporter
Message-ID: <bug-65635-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2015-03/txt/msg03455.txt.bz2
Content-length: 3844

https://gcc.gnu.org/bugzilla/show_bug.cgi?ide635

            Bug ID: 65635
           Summary: [c++-concepts] ICE in cp_tree_equal() during class
                    template partial specialization constraint matching
           Product: gcc
           Version: unknown
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: c++
          Assignee: unassigned at gcc dot gnu.org
          Reporter: tom at honermann dot net

Encountered with the latest revision of the gcc c++-concepts branch (r221742).

An internal compiler error occurs when matching constrained class template
partial specializations.

$ svn info   # From my local svn gcc repo.
Path: .
URL: svn://gcc.gnu.org/svn/gcc/branches/c++-concepts
Repository Root: svn://gcc.gnu.org/svn/gcc
Repository UUID: 138bc75d-0d04-0410-961f-82ee72b054a4
Revision: 221742
Node Kind: directory
Schedule: normal
Last Changed Author: asutton
Last Changed Rev: 221733
Last Changed Date: 2015-03-27 10:44:22 -0400 (Fri, 27 Mar 2015)

$ cat t.cpp
template<typename T>
concept bool Subsumed() {
    return requires () { typename T::type1; };
}

template<typename T>
concept bool Subsuming() {
    return Subsumed<T>()
        && requires () { typename T::type2; };
}

struct M {
    using type1 = int;
    using type2 = int;
};

template<typename T>
concept bool C() {
    return requires () {
               typename T::force_instantiation;
           };
}

template<typename T>
struct TM;
template<Subsumed T>
struct TM<T> {};
template<Subsuming T>
struct TM<T> {};

static_assert(C<TM<M>>(), "");

$ g++ -c -std=c++1z t.cpp
t.cpp:20:28: internal compiler error: in cp_tree_equal, at cp/tree.c:3037
                typename T::force_instantiation;
                            ^
0x7c7a6f cp_tree_equal(tree_node*, tree_node*)
        ../../gcc-c++-concepts2/c++-concepts/gcc/cp/tree.c:3037
0x7c7a0e cp_tree_equal(tree_node*, tree_node*)
        ../../gcc-c++-concepts2/c++-concepts/gcc/cp/tree.c:3028
0x82f7d2 match_terms
        ../../gcc-c++-concepts2/c++-concepts/gcc/cp/logic.cc:384
0x82f7d2 subsumes_atomic_constraint
        ../../gcc-c++-concepts2/c++-concepts/gcc/cp/logic.cc:394
0x82f7d2 subsumes_constraint
        ../../gcc-c++-concepts2/c++-concepts/gcc/cp/logic.cc:445
0x82f94f subsumes_conjunction
        ../../gcc-c++-concepts2/c++-concepts/gcc/cp/logic.cc:406
0x82f94f subsumes_constraint
        ../../gcc-c++-concepts2/c++-concepts/gcc/cp/logic.cc:439
0x82faee subsumes_constraints_nonnull
        ../../gcc-c++-concepts2/c++-concepts/gcc/cp/logic.cc:463
0x82faee subsumes(tree_node*, tree_node*)
        ../../gcc-c++-concepts2/c++-concepts/gcc/cp/logic.cc:481
0x82f554 more_constrained(tree_node*, tree_node*)
        ../../gcc-c++-concepts2/c++-concepts/gcc/cp/constraint.cc:2089
0x6899dd most_specialized_partial_spec
        ../../gcc-c++-concepts2/c++-concepts/gcc/cp/pt.c:20019
0x6afb0c instantiate_class_template_1
        ../../gcc-c++-concepts2/c++-concepts/gcc/cp/pt.c:9634
0x6afb0c instantiate_class_template(tree_node*)
        ../../gcc-c++-concepts2/c++-concepts/gcc/cp/pt.c:10174
0x74f2cb complete_type(tree_node*)
        ../../gcc-c++-concepts2/c++-concepts/gcc/cp/typeck.c:146
0x68bc7d tsubst(tree_node*, tree_node*, int, tree_node*)
        ../../gcc-c++-concepts2/c++-concepts/gcc/cp/pt.c:13001
0x67574b tsubst_decl
        ../../gcc-c++-concepts2/c++-concepts/gcc/cp/pt.c:11807
0x68b9c6 tsubst(tree_node*, tree_node*, int, tree_node*)
        ../../gcc-c++-concepts2/c++-concepts/gcc/cp/pt.c:12388
0x82eb81 tsubst_type_requirement
        ../../gcc-c++-concepts2/c++-concepts/gcc/cp/constraint.cc:1390
0x82eb81 tsubst_requirement
        ../../gcc-c++-concepts2/c++-concepts/gcc/cp/constraint.cc:1426
0x82eb81 tsubst_requirement_body
        ../../gcc-c++-concepts2/c++-concepts/gcc/cp/constraint.cc:1446

[Bug bootstrap/57125] Build not SMP safe; fails to build bconfig.h

[vapier at gentoo dot org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=57125

--- Comment #9 from Mike Frysinger <vapier at gentoo dot org> ---
after having the backport deployed in Gentoo, we found an edge case with the
fix in trunk ...

we still have this rule in gcc/Makefile.in:
# Generated source files for gengtype.  Prepend inclusion of
# bconfig.h because AIX requires _LARGE_FILES to be defined before
# any system header is included.
gengtype-lex.c : gengtype-lex.l
    -$(FLEX) $(FLEXFLAGS) -o$@ $< && { \
      echo '#include "bconfig.h"' > $@.tmp; \
      cat $@ >> $@.tmp; \
      mv $@.tmp $@; \
    }

so even though gengtype-lex.l was adapted to not include bconfig.h when
HOST_GENERATOR_FILE is defined, and the bconfig.h dep on that file was dropped,
the source still tries to always include it for both host & build modes.

i don't really understand the comment ... it seems to me that the lex file will
include the right config.h header files first already, so we should drop the
explicit insertion of bconfig.h here.

[Bug bootstrap/57125] Build not SMP safe; fails to build bconfig.h

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=57125

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
   Target Milestone|---                         |8.0
             Status|UNCONFIRMED                 |RESOLVED
           Keywords|                            |build

--- Comment #10 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
f142b5bc2102 (Romain Geissler           2011-08-04 11:30:45 +0000 2872)
gengtype-lex.o build/gengtype-lex.o : gengtype-lex.c gengtype.h $(SYSTEM_H)
d6d34aa9133a (Jakub Jelinek             2014-12-03 17:44:27 +0100 2873)
CFLAGS-gengtype-lex.o += -DHOST_GENERATOR_FILE
f142b5bc2102 (Romain Geissler           2011-08-04 11:30:45 +0000 2874)
build/gengtype-lex.o: $(BCONFIG_H)




18406601136a (Paolo Bonzini             2010-11-13 09:42:58 +0000 3001) #
Generated source files for gengtype.  Prepend inclusion of
8c7dbea9f193 (Boris Kolpackov           2017-11-26 13:00:48 +0000 3002) #
config.h/bconfig.h because AIX requires _LARGE_FILES to be defined before
18406601136a (Paolo Bonzini             2010-11-13 09:42:58 +0000 3003) # any
system header is included.
03787dfd8153 (Kelley Cook               2004-01-15 04:02:24 +0000 3004)
gengtype-lex.c : gengtype-lex.l
8fb15466274a (Paolo Bonzini             2010-11-11 23:44:44 +0000 3005)        
-$(FLEX) $(FLEXFLAGS) -o$@ $< && { \
8c7dbea9f193 (Boris Kolpackov           2017-11-26 13:00:48 +0000 3006)        
  echo '#ifdef HOST_GENERATOR_FILE' > $@.tmp; \
8c7dbea9f193 (Boris Kolpackov           2017-11-26 13:00:48 +0000 3007)        
  echo '#include "config.h"'       >> $@.tmp; \
8c7dbea9f193 (Boris Kolpackov           2017-11-26 13:00:48 +0000 3008)        
  echo '#else'                     >> $@.tmp; \
8c7dbea9f193 (Boris Kolpackov           2017-11-26 13:00:48 +0000 3009)        
  echo '#include "bconfig.h"'      >> $@.tmp; \
8c7dbea9f193 (Boris Kolpackov           2017-11-26 13:00:48 +0000 3010)        
  echo '#endif'                    >> $@.tmp; \
8fb15466274a (Paolo Bonzini             2010-11-11 23:44:44 +0000 3011)        
  cat $@ >> $@.tmp; \
8fb15466274a (Paolo Bonzini             2010-11-11 23:44:44 +0000 3012)        
  mv $@.tmp $@; \
8fb15466274a (Paolo Bonzini             2010-11-11 23:44:44 +0000 3013)        
}



So this was fixed with r8-4925-g8c7dbea9f193