[Bug tree-optimization/57218] New: Excessive inlining even at -Os

[Bug tree-optimization/57218] New: Excessive inlining even at -Os

[amylaar at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57218

             Bug #: 57218
           Summary: Excessive inlining even at -Os
    Classification: Unclassified
           Product: gcc
           Version: 4.8.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: tree-optimization
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: amylaar@gcc.gnu.org


Created attachment 30062
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=30062
test case (excerpt from newlib/libc/stdio/findfp.c)

In the testcase, std is inlined (thrice) into __sinit at the tree level,
even at -Os, thus increasing code size.
I first noticed this as a regression for arc-elf32 going from 4.4 to 4.8.
It used to be only inlined at -O3, not at -Os or -O2.
I have since verified that it is also not inlined at -Os / -O2
for i686-pc-linux-gnu 4.7.2 20120921 (Red Hat 4.7.2-2),
but it is inlined for i686-pc-linux-gnu GCC 4.8.0 and
4.9.0 20130422 (experimental)

Going from 4.7.2 to 4.9.0 (experimental), that causes a size regression
of 34.5% on i686-pc-linux-gnu at -Os.

[Bug tree-optimization/57218] [4.8/4.9 Regression] Excessive inlining even at -Os

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57218

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2013-05-10
                 CC|                            |hubicka at gcc dot gnu.org
   Target Milestone|---                         |4.8.1
            Summary|Excessive inlining even at  |[4.8/4.9 Regression]
                   |-Os                         |Excessive inlining even at
                   |                            |-Os
     Ever confirmed|0                           |1

--- Comment #1 from Richard Biener <rguenth at gcc dot gnu.org> ---
Confirmed.

Deciding on inlining of small functions.  Starting with size 47.
Enqueueing calls of std.isra.0/8.
   Estimating body: std.isra.0/8
   Known to be false: not inlined, op1 changed, op2 changed
   size:11 time:20
   Estimating body: std.isra.0/8
   Known to be false: not inlined, op1 changed, op2 changed
   size:11 time:20
   Estimating body: std.isra.0/8
   Known to be false: not inlined, op1 changed, op2 changed
   size:11 time:20
  enqueuing call __sinit/1 -> std.isra.0/8, badness -36092160
  enqueuing call __sinit/1 -> std.isra.0/8, badness -36092160
  enqueuing call __sinit/1 -> std.isra.0/8, badness -36092160
Enqueueing calls of __sinit/1.
   Estimating body: std.isra.0/8
   Known to be false: not inlined, op1 changed, op2 changed
   size:11 time:20

Considering std.isra.0 with 21 size
 to be inlined into __sinit in newlib/libc/stdio/findfp.c:79
 Estimated growth after inlined into all is +0 insns.
 Estimated badness is -36092160, frequency 0.39.
    Badness calculation for __sinit/1 -> std.isra.0/8
      size growth 7, time 20  big_speedup
      -36092160: guessed profile. frequency 0.389000, benefit 23.529411%, time
w/o inlining 34, time w inlining 26 overall growth 0 (current) 0 (original)
                Accounting size:7.00, time:2.72 on predicate:(op0[ref offset:
640] == 0)
Processing frequency std.isra.0
  Called by __sinit that is normal or hot
 Inlined into __sinit which now has time 26 and size 33,net change of +7.


So the reason is that it can eliminate the body of 'std' after inlining
it three times and it computes that the cost of doing that (3 * 7 is
the same as the cost of the offline body).

And that's because

  ptr_1(D)->_p = 0B;
                freq:1.00 size:  1 time:  1
                50% will be eliminated by inlining
                Accounting size:0.50, time:0.50 on predicate:(not inlined)
                Accounting size:0.50, time:0.50 on predicate:(true)
  ptr_1(D)->_r = 0;
                freq:1.00 size:  1 time:  1
                50% will be eliminated by inlining
                Accounting size:0.50, time:0.50 on predicate:(not inlined)
                Accounting size:0.50, time:0.50 on predicate:(true)
...

the inliner thinks that it is likely that initializations via parameters
are eliminated by inlining:

Inline summary for std.isra.0/8 inlinable
  self time:       29
  global time:     0
  self size:       21
  global size:     0
  self stack:      0
  global stack:    0
    size:7.000000, time:7.000000, predicate:(true)
    size:10.000000, time:9.000000, predicate:(not inlined)
  calls:
    memset/3 function body not available
      loop depth: 0 freq:1000 size: 4 time: 13 callee size: 0 stack: 0
       op1 is compile time invariant
       op2 is compile time invariant

not sure why we have that (not inlined) predicate size stuff but use
'self size' when accounting against inlining multiple times.

The above seems to suggest that GCC will _always_ inline a function
with just initializers twice when the body can be eliminated then.

[Bug tree-optimization/57218] [4.8/4.9 Regression] Excessive inlining even at -Os

[hubicka at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57218

--- Comment #2 from Jan Hubicka <hubicka at gcc dot gnu.org> ---
Yep, it is just heuristic here.  We may get more cureful at -Os (i.e. not so
optimistic about the optimization oppurtunities), but last time I played with
this it actually resulted in code size increase at Mozilla and -Os.

LLVM is doing kind of oposite heuristic tracking when function gets address of
local variable as a parameter and anticipate SRA then. I suppose I can give
this a try even though it will miss all the optimization of dynamically
allocated objects...

[Bug tree-optimization/57218] [4.8/4.9 Regression] Excessive inlining even at -Os

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57218

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.8.1                       |4.8.2

--- Comment #3 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
GCC 4.8.1 has been released.

[Bug tree-optimization/57218] [4.8/4.9 Regression] Excessive inlining even at -Os

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57218

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.8.2                       |4.8.3

--- Comment #4 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
GCC 4.8.2 has been released.

[Bug tree-optimization/57218] [4.8/4.9 Regression] Excessive inlining even at -Os

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57218

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P2

[Bug tree-optimization/57218] [4.8/4.9/4.10 Regression] Excessive inlining even at -Os

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=57218

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.8.3                       |4.8.4

--- Comment #5 from Richard Biener <rguenth at gcc dot gnu.org> ---
GCC 4.8.3 is being released, adjusting target milestone.

[Bug tree-optimization/57218] [4.8/4.9/5 Regression] Excessive inlining even at -Os

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=57218

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.8.4                       |4.8.5

--- Comment #6 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
GCC 4.8.4 has been released.

[Bug tree-optimization/57218] [4.8/4.9/5/6 Regression] Excessive inlining even at -Os

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=57218

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.8.5                       |4.9.3

--- Comment #7 from Richard Biener <rguenth at gcc dot gnu.org> ---
The gcc-4_8-branch is being closed, re-targeting regressions to 4.9.3.

[Bug tree-optimization/57218] [4.9/5/6 Regression] Excessive inlining even at -Os

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=57218

--- Comment #8 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
GCC 4.9.3 has been released.

[Bug tree-optimization/57218] [4.9/5/6 Regression] Excessive inlining even at -Os

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=57218

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.9.3                       |4.9.4

[Bug ipa/57218] [8/9/10 Regression] Excessive inlining even at -Os

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=57218

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|9.3                         |9.4

--- Comment #16 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
GCC 9.3.0 has been released, adjusting target milestone.

[Bug ipa/57218] [9/10/11/12 Regression] Excessive inlining even at -Os

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=57218

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|9.4                         |9.5

--- Comment #17 from Richard Biener <rguenth at gcc dot gnu.org> ---
GCC 9.4 is being released, retargeting bugs to GCC 9.5.

[Bug ipa/57218] [9/10/11/12 Regression] Excessive inlining even at -Os

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=57218

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |missed-optimization
   Last reconfirmed|2018-02-03 00:00:00         |2021-9-5

--- Comment #18 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
So looking at LLVM, at -Oz, the inlining is not done but at -Os it is.

[Bug ipa/57218] [10/11/12/13 Regression] Excessive inlining even at -Os

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=57218

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|9.5                         |10.4

--- Comment #19 from Richard Biener <rguenth at gcc dot gnu.org> ---
GCC 9 branch is being closed

[Bug ipa/57218] [10/11/12/13 Regression] Excessive inlining even at -Os

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=57218

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|10.4                        |10.5

--- Comment #20 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
GCC 10.4 is being released, retargeting bugs to GCC 10.5.

[Bug ipa/57218] [11/12/13/14 Regression] Excessive inlining even at -Os

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=57218

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|10.5                        |11.5

--- Comment #21 from Richard Biener <rguenth at gcc dot gnu.org> ---
GCC 10 branch is being closed.