[Bug translation/57850] New: Option -fdump-translation-unit not working

[Bug translation/57850] New: Option -fdump-translation-unit not working

[aponomarenko at rosalab dot ru]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57850

            Bug ID: 57850
           Summary: Option -fdump-translation-unit not working
           Product: gcc
           Version: 4.8.1
            Status: UNCONFIRMED
          Severity: critical
          Priority: P3
         Component: translation
          Assignee: unassigned at gcc dot gnu.org
          Reporter: aponomarenko at rosalab dot ru

Hi,

The -fdump-translation-unit option of the GCC compiler was broken in 4.8.1
(relative to 4.7.1).

Steps to reproduce:

1. Create any header file file.h
2. g++ -fdump-translation-unit file.h

g++ 4.7.1 dumps test.h.001t.tu, but g++ 4.8.1 does nothing.

May be this bug can be fixed like
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55164 ?

Thank you.

[Bug c++/57850] Option -fdump-translation-unit not working

[pinskia at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57850

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|translation                 |c++
           Severity|critical                    |normal

--- Comment #1 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
I bet we no longer go through the code for dumping while doing precompiled
headers .

[Bug c++/57850] Option -fdump-translation-unit not working

[paolo.carlini at oracle dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57850

--- Comment #2 from Paolo Carlini <paolo.carlini at oracle dot com> ---
See also PR2778 (!) If there is no interest in maintaining the option we should
probably remove / deprecate it. Seriously.

[Bug c++/57850] Option -fdump-translation-unit not working

[aponomarenko at rosalab dot ru]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57850

--- Comment #3 from Andrey Ponomarenko <aponomarenko at rosalab dot ru> ---
Please do not remove this option!

I know that it's private option for debugging GCC only, but it's used in the
ABI Compliance Checker tool:
http://ispras.linuxbase.org/index.php/ABI_compliance_checker

This tool is used by the army of maintainers of almost all Linux distributions
to verify ABI changes in system libraries.

The tool is also the core of the http://upstream-tracker.org/ service for
tracking upstream changes in APIs of system libraries.

If you remove this option then ABI Compliance Checker and upstream-tracker.org
will stop working and DLL hell will return.

Is there an alternative way to create translation unit dump of the header file
by the new GCC 4.8?

Is it possible to make this option working like in GCC<=4.7?

Thank you!

[Bug c++/57850] Option -fdump-translation-unit not working

[aponomarenko at rosalab dot ru]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57850

--- Comment #4 from Andrey Ponomarenko <aponomarenko at rosalab dot ru> ---
It's also used for maintaining binary compatibility of glibc:
http://sourceware.org/glibc/wiki/Testing/ABI_checker

and by the API Sanity Checker tool for generating unit tests for C/C++
libraries: http://ispras.linuxbase.org/index.php/API_Sanity_Checker

[Bug c++/57850] Option -fdump-translation-unit not working

[dmitrij.ledkov at ubuntu dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57850

--- Comment #5 from Dima <dmitrij.ledkov at ubuntu dot com> ---
Why is this bug is still marked unconfirmed? Is there something I can do to
confirm it?

[Bug c++/57850] Option -fdump-translation-unit not working

[singhai at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57850

--- Comment #7 from Sharad Singhai <singhai at gcc dot gnu.org> ---
I looked at it and this issue seems related to handling of PCH files. The
following patch introduced it

http://gcc.gnu.org/viewcvs/gcc/trunk/gcc/cp/decl2.c?r1=194363&r2=194362&pathrev=194363

When only a header file is being compiled then cp_write_global_declarations ()
returns immediately without doing any extra work. Thus dump code (and
everything else) is skipped.

I don't know what should be the right course of action here. If it is only the
dump functionality that needs to be restored, I can perhaps work around with
some restructuring. However, there is a lot of other processing which should be
skipped in case of PCH. Suggestions?

Thanks,
Sharad

[Bug c++/57850] Option -fdump-translation-unit not working

[paolo.carlini at oracle dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57850

Paolo Carlini <paolo.carlini at oracle dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |steven at gcc dot gnu.org

--- Comment #8 from Paolo Carlini <paolo.carlini at oracle dot com> ---
Let's add Steven in CC then.

[Bug c++/57850] [4.8/4.9 Regression] Option -fdump-translation-unit not working

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57850

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |4.9.0
            Summary|Option                      |[4.8/4.9 Regression] Option
                   |-fdump-translation-unit not |-fdump-translation-unit not
                   |working                     |working

[Bug c++/57850] [4.8/4.9 Regression] Option -fdump-translation-unit not working

[jason at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57850

Jason Merrill <jason at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |ASSIGNED
   Last reconfirmed|                            |2013-09-13
                 CC|                            |jason at gcc dot gnu.org
           Assignee|unassigned at gcc dot gnu.org      |jason at gcc dot gnu.org
     Ever confirmed|0                           |1

[Bug c++/57850] [4.8/4.9 Regression] Option -fdump-translation-unit not working

[jason at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57850

--- Comment #9 from Jason Merrill <jason at gcc dot gnu.org> ---
Created attachment 30818
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=30818&action=edit
patch

Can you verify that this patch fixes the issue?

[Bug c++/57850] [4.8/4.9 Regression] Option -fdump-translation-unit not working

[jason at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57850

Jason Merrill <jason at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |WAITING

[Bug c++/57850] [4.8/4.9 Regression] Option -fdump-translation-unit not working

[aponomarenko at rosalab dot ru]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57850

Andrey Ponomarenko <aponomarenko at rosalab dot ru> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|WAITING                     |RESOLVED
         Resolution|---                         |FIXED

--- Comment #10 from Andrey Ponomarenko <aponomarenko at rosalab dot ru> ---
(In reply to Jason Merrill from comment #9)
> Created attachment 30818 [details]
> patch
> 
> Can you verify that this patch fixes the issue?

Yes, it works! Thank you!

[Bug c++/57850] [4.8/4.9 Regression] Option -fdump-translation-unit not working

[aponomarenko at rosalab dot ru]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57850

Andrey Ponomarenko <aponomarenko at rosalab dot ru> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|FIXED                       |WORKSFORME

[Bug c++/57850] [4.8/4.9 Regression] Option -fdump-translation-unit not working

[dmitrij.ledkov at ubuntu dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57850

--- Comment #11 from Dima <dmitrij.ledkov at ubuntu dot com> ---
(In reply to Jason Merrill from comment #9)
> Created attachment 30818 [details]
> patch
> 
> Can you verify that this patch fixes the issue?

Yes, it works for me and makes abi-compliance-checker function once again.

Regards,

Dmitrijs.

[Bug c++/57850] [4.8/4.9 Regression] Option -fdump-translation-unit not working

[dmitrij.ledkov at ubuntu dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57850

--- Comment #12 from Dima <dmitrij.ledkov at ubuntu dot com> ---
Is this going to be applied for 4.9 & 4.8 series?

[Bug c++/57850] [4.8/4.9 Regression] Option -fdump-translation-unit not working

[jason at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57850

--- Comment #13 from Jason Merrill <jason at gcc dot gnu.org> ---
Author: jason
Date: Wed Oct 16 21:57:36 2013
New Revision: 203724

URL: http://gcc.gnu.org/viewcvs?rev=203724&root=gcc&view=rev
Log:
    PR c++/57850
    * decl2.c (dump_tu): Split out from...
    (cp_write_global_declarations): ...here.  Call it in PCH mode.

Modified:
    trunk/gcc/cp/ChangeLog
    trunk/gcc/cp/decl2.c

[Bug c++/57850] [4.8/4.9 Regression] Option -fdump-translation-unit not working

[jason at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57850

Jason Merrill <jason at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|WORKSFORME                  |FIXED
   Target Milestone|4.9.0                       |4.8.3

--- Comment #15 from Jason Merrill <jason at gcc dot gnu.org> ---
Fixed.

[Bug c++/57850] [4.8/4.9 Regression] Option -fdump-translation-unit not working

[jason at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57850

--- Comment #14 from Jason Merrill <jason at gcc dot gnu.org> ---
Author: jason
Date: Wed Oct 16 21:58:58 2013
New Revision: 203728

URL: http://gcc.gnu.org/viewcvs?rev=203728&root=gcc&view=rev
Log:
    PR c++/57850
    * decl2.c (dump_tu): Split out from...
    (cp_write_global_declarations): ...here.  Call it in PCH mode.

Modified:
    branches/gcc-4_8-branch/gcc/cp/ChangeLog
    branches/gcc-4_8-branch/gcc/cp/decl2.c