[Bug target/57935] New: ICE in rs6000_secondary_reload_inner:15181, type = load

[Bug target/57935] New: ICE in rs6000_secondary_reload_inner:15181, type = load

[pthaugen at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57935

            Bug ID: 57935
           Summary: ICE in rs6000_secondary_reload_inner:15181, type =
                    load
           Product: gcc
           Version: 4.9.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: target
          Assignee: unassigned at gcc dot gnu.org
          Reporter: pthaugen at gcc dot gnu.org
                CC: bergner at gcc dot gnu.org, meissner at gcc dot gnu.org
              Host: powerpc64-linux
            Target: powerpc64-linux
             Build: powerpc64-linux

Created attachment 30527
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=30527&action=edit
testcase

-mcpu=power8 causes ICE in testcase gcc.target/powerpc/ppc32-abi-dfp-1.c.

[pthaugen@igoo p8]$ ~/install/gcc/trunk/bin/gcc ppc32-abi-dfp-1.c -c -m32 -O1
-mcpu=power8rs6000_secondary_reload_inner:15181, type = load
(parallel [
        (set (reg:SD 9 9)
            (mem/c:SD (plus:SI (plus:SI (reg/f:SI 31 31)
                        (const_int 64 [0x40]))
                    (reg:SI 9 9 [253])) [0 a9+0 S4 A32]))
        (clobber (reg:SI 10 10))
    ])
ppc32-abi-dfp-1.c: In function ‘func4’:
ppc32-abi-dfp-1.c:141:1: internal compiler error: in
rs6000_secondary_reload_fail, at config/rs6000/rs6000.c:15117
 }
 ^
0x10908e37 rs6000_secondary_reload_fail
    /home/pthaugen/src/gcc/trunk/gcc/gcc/config/rs6000/rs6000.c:15117
0x10936fb7 rs6000_secondary_reload_inner(rtx_def*, rtx_def*, rtx_def*, bool)
    /home/pthaugen/src/gcc/trunk/gcc/gcc/config/rs6000/rs6000.c:15144
0x109f61e7 gen_reload_sd_si_load(rtx_def*, rtx_def*, rtx_def*)
    /home/pthaugen/src/gcc/trunk/gcc/gcc/config/rs6000/vector.md:196
0x100cf1f7 emit_input_reload_insns
    /home/pthaugen/src/gcc/trunk/gcc/gcc/reload1.c:7542
0x100cf1f7 do_input_reload
    /home/pthaugen/src/gcc/trunk/gcc/gcc/reload1.c:7880
0x100cf1f7 emit_reload_insns
    /home/pthaugen/src/gcc/trunk/gcc/gcc/reload1.c:8072
0x100cf1f7 reload_as_needed
    /home/pthaugen/src/gcc/trunk/gcc/gcc/reload1.c:4648
0x105c267b reload(rtx_def*, int)
    /home/pthaugen/src/gcc/trunk/gcc/gcc/reload1.c:1054
0x104a4867 do_reload
    /home/pthaugen/src/gcc/trunk/gcc/gcc/ira.c:4701
0x104a4867 rest_of_handle_reload
    /home/pthaugen/src/gcc/trunk/gcc/gcc/ira.c:4801
Please submit a full bug report,
>From gcc-bugs-return-426384-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Fri Jul 19 18:48:30 2013
Return-Path: <gcc-bugs-return-426384-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 22444 invoked by alias); 19 Jul 2013 18:48:29 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 19911 invoked by uid 48); 19 Jul 2013 18:46:28 -0000
From: "pthaugen at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/57936] New: ICE in rs6000_secondary_reload_inner:15144, type = load
Date: Fri, 19 Jul 2013 18:48:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: new
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: target
X-Bugzilla-Version: 4.9.0
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: pthaugen at gcc dot gnu.org
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: bug_id short_desc product version bug_status bug_severity priority component assigned_to reporter cc cf_gcchost cf_gcctarget cf_gccbuild attachments.created
Message-ID: <bug-57936-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2013-07/txt/msg00891.txt.bz2
Content-length: 2452

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57936

            Bug ID: 57936
           Summary: ICE in rs6000_secondary_reload_inner:15144, type =
                    load
           Product: gcc
           Version: 4.9.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: target
          Assignee: unassigned at gcc dot gnu.org
          Reporter: pthaugen at gcc dot gnu.org
                CC: bergner at gcc dot gnu.org, meissner at gcc dot gnu.org
              Host: powerpc64-linux
            Target: powerpc64-linux
             Build: powerpc64-linux

Created attachment 30528
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=30528&action=edit
Preprocessed tescase

-mcpu=power8 causes ICE in testcase g++.dg/torture/vshuf-v2di.C.

[pthaugen@igoo p8]$ ~/install/gcc/trunk/bin/g++ -c -m32 -mcpu=power8 -std=c++11
-O3 vshuf-v2di.ii
rs6000_secondary_reload_inner:15144, type = load
(parallel [
        (set (reg:V16QI 78 1)
            (reg:V16QI 32 0))
        (clobber (reg:SI 10 10))
    ])
In file included from vshuf-v2di.C:18:0:
/home/pthaugen/src/gcc/gcc-4_9-power8/gcc/gcc/testsuite/g++.dg/torture/vshuf-main.inc:
In function ‘int main()’:
/home/pthaugen/src/gcc/gcc-4_9-power8/gcc/gcc/testsuite/g++.dg/torture/vshuf-main.inc:29:1:
internal compiler error: in rs6000_secondary_reload_fail, at
config/rs6000/rs6000.c:15117
 }
 ^
0x10b106b7 rs6000_secondary_reload_fail
    /home/pthaugen/src/gcc/trunk/gcc/gcc/config/rs6000/rs6000.c:15117
0x10b3e837 rs6000_secondary_reload_inner(rtx_def*, rtx_def*, rtx_def*, bool)
    /home/pthaugen/src/gcc/trunk/gcc/gcc/config/rs6000/rs6000.c:15144
0x10bfd367 gen_reload_v16qi_si_load(rtx_def*, rtx_def*, rtx_def*)
    /home/pthaugen/src/gcc/trunk/gcc/gcc/config/rs6000/vector.md:196
0x100e5b23 emit_input_reload_insns
    /home/pthaugen/src/gcc/trunk/gcc/gcc/reload1.c:7542
0x100e5b23 do_input_reload
    /home/pthaugen/src/gcc/trunk/gcc/gcc/reload1.c:7880
0x100e5b23 emit_reload_insns
    /home/pthaugen/src/gcc/trunk/gcc/gcc/reload1.c:8072
0x100e5b23 reload_as_needed
    /home/pthaugen/src/gcc/trunk/gcc/gcc/reload1.c:4648
0x107c9efb reload(rtx_def*, int)
    /home/pthaugen/src/gcc/trunk/gcc/gcc/reload1.c:1054
0x106ac0e7 do_reload
    /home/pthaugen/src/gcc/trunk/gcc/gcc/ira.c:4701
0x106ac0e7 rest_of_handle_reload
    /home/pthaugen/src/gcc/trunk/gcc/gcc/ira.c:4801
Please submit a full bug report,
>From gcc-bugs-return-426385-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Fri Jul 19 19:32:43 2013
Return-Path: <gcc-bugs-return-426385-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 22151 invoked by alias); 19 Jul 2013 19:32:43 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 19894 invoked by uid 48); 19 Jul 2013 19:30:40 -0000
From: "jhand at austin dot rr.com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug libstdc++/57885] unordered_map find slower in 4.8.1 than 4.7.3 with integer key
Date: Fri, 19 Jul 2013 19:32:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: libstdc++
X-Bugzilla-Version: 4.8.1
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: jhand at austin dot rr.com
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields:
Message-ID: <bug-57885-4-Dttkkel0qX@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-57885-4@http.gcc.gnu.org/bugzilla/>
References: <bug-57885-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2013-07/txt/msg00892.txt.bz2
Content-length: 1737

http://gcc.gnu.org/bugzilla/show_bug.cgi?idW885

--- Comment #6 from Jim Hand <jhand at austin dot rr.com> ---
Thanks for the information Francois. That makes a lot of sense for the erase()
case.

For a little more information, I also timed this with three boost
implementations and saw the following times for boost 1.47, 1.49, and 1.53:

$ ./um.b147
Container:boost::unordered_map<int,int>  Key:int
Insertion: 13589 4581 4581 4593 4577  minE77 max\x13589
Lookup:    10344 10353 10339 10332 10338  min\x10332 max\x10353

$ ./um.b149
Container:boost::unordered_map<int,int>  Key:int
Insertion: 16593 7901 7944 7950 7970  miny01 max\x16593
Lookup:    15295 15340 15297 15303 15310  min\x15295 max\x15340

$ ./um.b153
Container:boost::unordered_map<int,int>  Key:int
Insertion: 10662 5648 5726 5747 5758  minV48 max\x10662
Lookup:    14880 14842 14844 14840 14928  min\x14840 max\x14928

The times are pretty comparable to gcc. Inserts may take about 10 or 11
nanoseconds on our hardware and finds look like they are taking about 5 or 6
nanoseconds. For most applications, including ours, the time spent inserting
and executing find() is miniscule compared to the other time spent by the
application.

If you feel you can improve performance while maintaining conformance with the
standard, please do so. If you feel that the current behavior is fine, we won't
complain (too much).

I also want you to know that the gcc developers all are doing a great job in
supporting the C++ community. I've been using gcc for C/C++ programming for
about 20 years now and have found the gcc compiler suite to be a great product.
My colleagues at work are really excited about moving from gcc-4.6 to 4.8,
mostly for the enhanced C++11 support.

[Bug target/57935] ICE in rs6000_secondary_reload_inner:15181, type = load

[amodra at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57935

Alan Modra <amodra at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
                 CC|                            |amodra at gmail dot com
         Resolution|---                         |DUPLICATE

--- Comment #1 from Alan Modra <amodra at gmail dot com> ---
This is exactly the same issue as pr58675.

*** This bug has been marked as a duplicate of bug 58675 ***

[Bug target/57935] ICE in rs6000_secondary_reload_inner:15181, type = load

[amodra at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57935

--- Comment #2 from Alan Modra <amodra at gcc dot gnu.org> ---
Author: amodra
Date: Sat Feb 15 10:49:55 2014
New Revision: 207798

URL: http://gcc.gnu.org/viewcvs?rev=207798&root=gcc&view=rev
Log:
    PR target/58675
    PR target/57935
    * config/rs6000/rs6000.c (rs6000_secondary_reload_inner): Use
    find_replacement on parts of insn rtl that might be reloaded.


Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/config/rs6000/rs6000.c

[Bug target/57935] ICE in rs6000_secondary_reload_inner:15181, type = load

[amodra at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57935

--- Comment #3 from Alan Modra <amodra at gcc dot gnu.org> ---
Author: amodra
Date: Wed Feb 26 04:41:53 2014
New Revision: 208166

URL: http://gcc.gnu.org/viewcvs?rev=208166&root=gcc&view=rev
Log:
    Apply mainline r207798
    PR target/58675
    PR target/57935
    * config/rs6000/rs6000.c (rs6000_secondary_reload_inner): Use
    find_replacement on parts of insn rtl that might be reloaded.


Modified:
    branches/ibm/gcc-4_8-branch/gcc/ChangeLog.ibm
    branches/ibm/gcc-4_8-branch/gcc/config/rs6000/rs6000.c

[Bug target/57935] ICE in rs6000_secondary_reload_inner:15181, type = load

[amodra at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57935

--- Comment #4 from Alan Modra <amodra at gcc dot gnu.org> ---
Author: amodra
Date: Wed Feb 26 21:57:40 2014
New Revision: 208186

URL: http://gcc.gnu.org/viewcvs?rev=208186&root=gcc&view=rev
Log:
    PR target/57935
    * reload1.c (emit_input_reload_insns): When reload_override_in,
    set old to rl->in_reg when rl->in_reg is a subreg.


Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/reload1.c

[Bug target/57935] ICE in rs6000_secondary_reload_inner:15181, type = load

[wschmidt at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57935

--- Comment #5 from Bill Schmidt <wschmidt at gcc dot gnu.org> ---
Author: wschmidt
Date: Fri Apr  4 15:05:34 2014
New Revision: 209112

URL: http://gcc.gnu.org/viewcvs?rev=209112&root=gcc&view=rev
Log:
2014-04-04  Bill Schmidt  <wschmidt@linux.vnet.ibm.com>

    Apply mainline r207798
    2014-02-26  Alan Modra  <amodra@gmail.com>
    PR target/58675
    PR target/57935
    * config/rs6000/rs6000.c (rs6000_secondary_reload_inner): Use
    find_replacement on parts of insn rtl that might be reloaded.

    Backport from mainline r208287
    2014-03-03  Bill Schmidt  <wschmidt@linux.vnet.ibm.com>

    * config/rs6000/rs6000.c (rs6000_preferred_reload_class): Disallow
    reload of PLUS rtx's outside of GENERAL_REGS or BASE_REGS; relax
    constraint on constants to permit them being loaded into
    GENERAL_REGS or BASE_REGS.


Modified:
    branches/gcc-4_8-branch/gcc/ChangeLog
    branches/gcc-4_8-branch/gcc/config/rs6000/rs6000.c