[Bug middle-end/58125] New: [4.9 Regression] ICE: in operator[], at vec.h:827 with -fno-inline-small-functions

[Bug middle-end/58125] New: [4.9 Regression] ICE: in operator[], at vec.h:827 with -fno-inline-small-functions

[zsojka at seznam dot cz]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58125

            Bug ID: 58125
           Summary: [4.9 Regression] ICE: in operator[], at vec.h:827 with
                    -fno-inline-small-functions
           Product: gcc
           Version: 4.9.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: middle-end
          Assignee: unassigned at gcc dot gnu.org
          Reporter: zsojka at seznam dot cz

Created attachment 30632
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=30632&action=edit
preprocessed testsuite/gcc.dg/tree-ssa/attr-alias.c

Compiler output:
$ gcc -O -fno-inline-small-functions attr-alias.i
/mnt/svn/gcc-trunk/gcc/testsuite/gcc.dg/tree-ssa/attr-alias.c:19:1: internal
compiler error: in operator[], at vec.h:827
 }
 ^
0x4e4459 vec<inline_summary, va_gc, vl_embed>::operator[](unsigned int)
        /mnt/svn/gcc-trunk/gcc/vec.h:827
0x4e4459 inline_summary
        /mnt/svn/gcc-trunk/gcc/ipa-inline.h:241
0x894e7c inline_summary
        /mnt/svn/gcc-trunk/gcc/ipa-inline-analysis.c:1006
0x894e7c reset_inline_summary
        /mnt/svn/gcc-trunk/gcc/ipa-inline-analysis.c:974
0x899f9f inline_free_summary()
        /mnt/svn/gcc-trunk/gcc/ipa-inline-analysis.c:4017
0x1172672 ipa_inline
        /mnt/svn/gcc-trunk/gcc/ipa-inline.c:1886
0x1172672 execute
        /mnt/svn/gcc-trunk/gcc/ipa-inline.c:2175
Please submit a full bug report,
with preprocessed source if appropriate.
Please include the complete backtrace with any bug report.
See <http://gcc.gnu.org/bugs.html> for instructions.

$ gcc -v
Using built-in specs.
COLLECT_GCC=/mnt/svn/gcc-trunk/binary-latest/bin/gcc
COLLECT_LTO_WRAPPER=/mnt/svn/gcc-trunk/binary-201617-lto-fortran-checking-yes-rtl-df/libexec/gcc/x86_64-unknown-linux-gnu/4.9.0/lto-wrapper
Target: x86_64-unknown-linux-gnu
Configured with: /mnt/svn/gcc-trunk//configure --enable-checking=yes,rtl,df
--enable-languages=c,c++,lto,fortran
--prefix=/mnt/svn/gcc-trunk/binary-201617-lto-fortran-checking-yes-rtl-df/
--without-cloog --without-ppl
Thread model: posix
gcc version 4.9.0 20130809 (experimental) (GCC) 

Tested revisions:
r201617 - ICE

[Bug middle-end/58125] [4.9 Regression] ICE: in operator[], at vec.h:827 with -fno-inline-small-functions

[mpolacek at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58125

Marek Polacek <mpolacek at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2013-08-12
                 CC|                            |mpolacek at gcc dot gnu.org
   Target Milestone|---                         |4.9.0
     Ever confirmed|0                           |1

--- Comment #1 from Marek Polacek <mpolacek at gcc dot gnu.org> ---
Confirmed.

[Bug middle-end/58125] [4.9 Regression] ICE: in operator[], at vec.h:827 with -fno-inline-small-functions

[mpolacek at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58125

Marek Polacek <mpolacek at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hubicka at gcc dot gnu.org

--- Comment #2 from Marek Polacek <mpolacek at gcc dot gnu.org> ---
Started with r201439.

[Bug middle-end/58125] [4.9 Regression] ICE: in operator[], at vec.h:827 with -fno-inline-small-functions

[mpolacek at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58125

--- Comment #3 from Marek Polacek <mpolacek at gcc dot gnu.org> ---
Seems like we're trying to access &(*inline_summary_vec)[node->uid]; where the
node->uid is 8, but inline_summary_vec's length is 8.

[Bug middle-end/58125] [4.9 Regression] ICE: in operator[], at vec.h:827 with -fno-inline-small-functions

[hubicka at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58125

Jan Hubicka <hubicka at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|unassigned at gcc dot gnu.org      |hubicka at gcc dot gnu.org

--- Comment #4 from Jan Hubicka <hubicka at gcc dot gnu.org> ---
mine.

[Bug middle-end/58125] [4.9 Regression] ICE: in operator[], at vec.h:827 with -fno-inline-small-functions

[hubicka at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58125

--- Comment #5 from Jan Hubicka <hubicka at gcc dot gnu.org> ---
OK, the testcase no longer reproduces, but the dump seems clear.  We introduced
new aliases but did not resize the summary vector, because we do not need info
for these.  Then we attempt to free it and ICE.
I am testing
Index: ipa-inline-analysis.c
===================================================================
--- ipa-inline-analysis.c       (revision 202199)
+++ ipa-inline-analysis.c       (working copy)
@@ -4019,7 +4019,8 @@
   if (!inline_edge_summary_vec.exists ())
     return;
   FOR_EACH_DEFINED_FUNCTION (node)
-    reset_inline_summary (node);
+    if (!node->symbol.alias)
+      reset_inline_summary (node);
   if (function_insertion_hook_holder)
     cgraph_remove_function_insertion_hook (function_insertion_hook_holder);
   function_insertion_hook_holder = NULL;

and will commit it along with the PR if that passes.

[Bug middle-end/58125] [4.9 Regression] ICE: in operator[], at vec.h:827 with -fno-inline-small-functions

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58125

--- Comment #6 from Richard Biener <rguenth at gcc dot gnu.org> ---
Did you fix it?

[Bug middle-end/58125] [4.9 Regression] ICE: in operator[], at vec.h:827 with -fno-inline-small-functions

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58125

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P1

[Bug middle-end/58125] [4.9 Regression] ICE: in operator[], at vec.h:827 with -fno-inline-small-functions

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58125

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jakub at gcc dot gnu.org

--- Comment #7 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
The testcase stopped reproducing with r202100.  But from quick look at the #c5
patch and ipa-inline-analysis.c it doesn't seem to be applied.  Honza?

[Bug middle-end/58125] [4.9 Regression] ICE: in operator[], at vec.h:827 with -fno-inline-small-functions

[law at redhat dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58125

Jeffrey A. Law <law at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |law at redhat dot com

--- Comment #8 from Jeffrey A. Law <law at redhat dot com> ---
Jan.  Ping!  If this is still an issue, can you update the patch for the trunk.
 If not, can you appropriately close this BZ?

Thanks,

[Bug middle-end/58125] [4.9 Regression] ICE: in operator[], at vec.h:827 with -fno-inline-small-functions

[hubicka at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58125

--- Comment #9 from Jan Hubicka <hubicka at gcc dot gnu.org> ---
Author: hubicka
Date: Fri Jan 17 21:10:42 2014
New Revision: 206734

URL: http://gcc.gnu.org/viewcvs?rev=206734&root=gcc&view=rev
Log:

    PR middle-end/58125
    * ipa-inline-analysis.c (inline_free_summary):
    Do not free summary of aliases.

Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/ipa-inline-analysis.c

[Bug middle-end/58125] [4.9 Regression] ICE: in operator[], at vec.h:827 with -fno-inline-small-functions

[hubicka at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58125

Jan Hubicka <hubicka at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #10 from Jan Hubicka <hubicka at gcc dot gnu.org> ---
Fixed.