[Bug libstdc++/58148] New: [C++11] Fails to insert iterator range into sequence container with -D_GLIBCXX_DEBUG when conversion is needed

[Bug libstdc++/58148] New: [C++11] Fails to insert iterator range into sequence container with -D_GLIBCXX_DEBUG when conversion is needed

[ai.azuma at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58148

            Bug ID: 58148
           Summary: [C++11] Fails to insert iterator range into sequence
                    container with -D_GLIBCXX_DEBUG when conversion is
                    needed
           Product: gcc
           Version: 4.9.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: libstdc++
          Assignee: unassigned at gcc dot gnu.org
          Reporter: ai.azuma at gmail dot com

Created attachment 30644
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=30644&action=edit
reproducing source code and output of -v option

The following valid code fails to compile with 4.9.0 20130804 and
`-D_GLIBCXX_DEBUG':

//============================
#include <vector>

int main()
{
  std::vector<wchar_t> v;
  char c = 'a';
  v.insert(v.begin(), &c, &c); // compile error
}
//============================

The above code successfully compiles with 4.9.0 20130728 and
`-D_GLIBCXX_DEBUG'. So this seems a regression, which has been introduced
between 20130728 and 20130804.

The same problem also occurs for `std::deque'.

[Bug libstdc++/58148] [C++11] Fails to insert iterator range into sequence container with -D_GLIBCXX_DEBUG when conversion is needed

[paolo.carlini at oracle dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58148

--- Comment #1 from Paolo Carlini <paolo.carlini at oracle dot com> ---
Francois, can you please have a look?

[Bug libstdc++/58148] [4.9 Regression] Fails to insert iterator range into sequence container with -D_GLIBCXX_DEBUG when conversion is needed

[paolo.carlini at oracle dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58148

--- Comment #2 from Paolo Carlini <paolo.carlini at oracle dot com> ---
-std=c++11 / gnu++11 required

[Bug libstdc++/58148] [4.9 Regression] Fails to insert iterator range into sequence container with -D_GLIBCXX_DEBUG when conversion is needed

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58148

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |4.9.0

[Bug libstdc++/58148] [4.9 Regression] Fails to insert iterator range into sequence container with -D_GLIBCXX_DEBUG when conversion is needed

[fdumont at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58148

--- Comment #3 from François Dumont <fdumont at gcc dot gnu.org> ---
Author: fdumont
Date: Fri Aug 30 20:55:37 2013
New Revision: 202121

URL: http://gcc.gnu.org/viewcvs?rev=202121&root=gcc&view=rev
Log:
2013-08-30  François Dumont  <fdumont@gcc.gnu.org>

    PR libstdc++/58148
    * include/debug/functions.h (__foreign_iterator_aux4): Use
    sequence const_pointer as common type to compare pointers. Add a
    fallback overload in case pointers cannot be cast to sequence
    const_pointer.
    * testsuite/23_containers/vector/modifiers/insert/58148.cc: New.

Added:
    trunk/libstdc++-v3/testsuite/23_containers/vector/modifiers/insert/58148.cc
Modified:
    trunk/libstdc++-v3/ChangeLog
    trunk/libstdc++-v3/include/debug/functions.h
>From gcc-bugs-return-428734-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Fri Aug 30 21:04:44 2013
Return-Path: <gcc-bugs-return-428734-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 8010 invoked by alias); 30 Aug 2013 21:04:44 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 7965 invoked by uid 48); 30 Aug 2013 21:04:41 -0000
From: "paolo.carlini at oracle dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug libstdc++/58148] [4.9 Regression] Fails to insert iterator range into sequence container with -D_GLIBCXX_DEBUG when conversion is needed
Date: Fri, 30 Aug 2013 21:04:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: libstdc++
X-Bugzilla-Version: 4.9.0
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: paolo.carlini at oracle dot com
X-Bugzilla-Status: RESOLVED
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 4.9.0
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: bug_status resolution
Message-ID: <bug-58148-4-3j469yq9o5@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-58148-4@http.gcc.gnu.org/bugzilla/>
References: <bug-58148-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2013-08/txt/msg01658.txt.bz2
Content-length: 435

http://gcc.gnu.org/bugzilla/show_bug.cgi?idX148

Paolo Carlini <paolo.carlini at oracle dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #4 from Paolo Carlini <paolo.carlini at oracle dot com> ---
Fixed.