[Bug libstdc++/58357] New: In C++11 std::rotate(first, middle, last) now should return a forward iterator to first + (last - middle).

[Bug libstdc++/58357] New: In C++11 std::rotate(first, middle, last) now should return a forward iterator to first + (last - middle).

[mhcox at bluezoosoftware dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58357

            Bug ID: 58357
           Summary: In C++11 std::rotate(first, middle, last) now should
                    return a forward iterator to  first + (last - middle).
           Product: gcc
           Version: 4.8.1
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: libstdc++
          Assignee: unassigned at gcc dot gnu.org
          Reporter: mhcox at bluezoosoftware dot com

According to section 25.3.11, the rotate(first, middle, last) algorithm should
return a forward iterator that points to (first + (last - middle)).

Compiled with -std=c++11.

[Bug libstdc++/58357] In C++11 std::rotate(first, middle, last) now should return a forward iterator to first + (last - middle).

[redi at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58357

Jonathan Wakely <redi at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2013-10-07
     Ever confirmed|0                           |1

[Bug libstdc++/58357] In C++11 std::rotate(first, middle, last) now should return a forward iterator to first + (last - middle).

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=58357

Jonathan Wakely <redi at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |5.0

[Bug libstdc++/58357] In C++11 std::rotate(first, middle, last) now should return a forward iterator to first + (last - middle).

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=58357

--- Comment #1 from Jonathan Wakely <redi at gcc dot gnu.org> ---
Author: redi
Date: Sat Jan 17 03:15:52 2015
New Revision: 219793

URL: https://gcc.gnu.org/viewcvs?rev=219793&root=gcc&view=rev
Log:
    DR 488
    PR libstdc++/58357
    * include/bits/algorithmfwd.h (rotate): Return an iterator.
    * include/bits/stl_algo.h (rotate, __rotate): Likewise.
    * testsuite/25_algorithms/rotate/dr488.cc: New.
    * testsuite/25_algorithms/rotate/check_type.cc: Adjust function type.
    * testsuite/25_algorithms/rotate/requirements/explicit_instantiation/
    2.cc: Likewise.
    * testsuite/25_algorithms/rotate/requirements/explicit_instantiation/
    pod.cc: Likewise.

Added:
    trunk/libstdc++-v3/testsuite/25_algorithms/rotate/dr488.cc
Modified:
    trunk/libstdc++-v3/ChangeLog
    trunk/libstdc++-v3/include/bits/algorithmfwd.h
    trunk/libstdc++-v3/include/bits/stl_algo.h
    trunk/libstdc++-v3/testsuite/25_algorithms/rotate/check_type.cc
   
trunk/libstdc++-v3/testsuite/25_algorithms/rotate/requirements/explicit_instantiation/2.cc
   
trunk/libstdc++-v3/testsuite/25_algorithms/rotate/requirements/explicit_instantiation/pod.cc

[Bug libstdc++/58357] In C++11 std::rotate(first, middle, last) now should return a forward iterator to first + (last - middle).

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=58357

Jonathan Wakely <redi at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #2 from Jonathan Wakely <redi at gcc dot gnu.org> ---
Fixed for GCC 5

[Bug libstdc++/58357] [5 Regression] In C++11 std::rotate(first, middle, last) now should return a forward iterator to first + (last - middle).

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=58357

Jonathan Wakely <redi at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |---
            Summary|In C++11 std::rotate(first, |[5 Regression] In C++11
                   |middle, last) now should    |std::rotate(first, middle,
                   |return a forward iterator   |last) now should return a
                   |to  first + (last -         |forward iterator to  first
                   |middle).                    |+ (last - middle).

--- Comment #3 from Jonathan Wakely <redi at gcc dot gnu.org> ---
Reopening as a reminder to fix the ABI problem Marc pointed out:
https://gcc.gnu.org/ml/libstdc++/2015-01/msg00087.html

[Bug libstdc++/58357] [5 Regression] In C++11 std::rotate(first, middle, last) now should return a forward iterator to first + (last - middle).

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=58357

--- Comment #4 from Jonathan Wakely <redi at gcc dot gnu.org> ---
Author: redi
Date: Thu Feb 19 20:57:40 2015
New Revision: 220823

URL: https://gcc.gnu.org/viewcvs?rev=220823&root=gcc&view=rev
Log:
    PR libstdc++/58357
    * include/bits/algorithmfwd.h (rotate): Move to inline namespace _V2.
    * include/bits/stl_algo.h (__rotate, rotate): Likewise.

Modified:
    trunk/libstdc++-v3/ChangeLog
    trunk/libstdc++-v3/include/bits/algorithmfwd.h
    trunk/libstdc++-v3/include/bits/stl_algo.h

[Bug libstdc++/58357] [5 Regression] In C++11 std::rotate(first, middle, last) now should return a forward iterator to first + (last - middle).

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=58357

Jonathan Wakely <redi at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #5 from Jonathan Wakely <redi at gcc dot gnu.org> ---
Done.