[Bug c/58364] New: likely wrong code bug

[Bug c/58364] New: likely wrong code bug

[regehr at cs dot utah.edu]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58364

            Bug ID: 58364
           Summary: likely wrong code bug
           Product: gcc
           Version: 4.9.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: c
          Assignee: unassigned at gcc dot gnu.org
          Reporter: regehr at cs dot utah.edu
                CC: chenyang at cs dot utah.edu

regehr@john-home ~/z/reduce/r107 $ gcc -O0 small.c ; ./a.out
regehr@john-home ~/z/reduce/r107 $ gcc -O1 small.c ; ./a.out
x
regehr@john-home ~/z/reduce/r107 $ cat small.c
int printf(const char *, ...);

int x3 (int x4) { 
  return x4 < 0 ? 1 : x4; 
}

int x0 = 1, x1, x2;

int main (void) {
  if (x3(x0 > x2 == (x1 = 0))) {
    printf("x\n");
  }
  return 0;
}
regehr@john-home ~/z/reduce/r107 $ gcc -v
Using built-in specs.
COLLECT_GCC=gcc
COLLECT_LTO_WRAPPER=/home/regehr/z/compiler-install/gcc-r202341-install/libexec/gcc/x86_64-unknown-linux-gnu/4.9.0/lto-wrapper
Target: x86_64-unknown-linux-gnu
Configured with: /home/regehr/z/compiler-source/gcc/configure
--prefix=/home/regehr/z/compiler-install/gcc-r202341-install
--enable-languages=c,c++ --disable-multilib
Thread model: posix
gcc version 4.9.0 20130906 (experimental) (GCC)

[Bug tree-optimization/58364] [4.8/4.9 Regression] likely wrong code bug

[glisse at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58364

Marc Glisse <glisse at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |wrong-code
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2013-09-08
          Component|c                           |tree-optimization
            Summary|likely wrong code bug       |[4.8/4.9 Regression] likely
                   |                            |wrong code bug
     Ever confirmed|0                           |1

--- Comment #1 from Marc Glisse <glisse at gcc dot gnu.org> ---
Something strange seems to happen in reassoc.

[Bug tree-optimization/58364] [4.8/4.9 Regression] likely wrong code bug

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58364

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jakub at gcc dot gnu.org
   Target Milestone|---                         |4.8.2

--- Comment #2 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Started with r193028 .  I'll have a look.

[Bug tree-optimization/58364] [4.8/4.9 Regression] likely wrong code bug

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58364

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|unassigned at gcc dot gnu.org      |jakub at gcc dot gnu.org

--- Comment #3 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Created attachment 30771
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=30771&action=edit
gcc49-pr58364.patch

Untested fix.

[Bug tree-optimization/58364] [4.8/4.9 Regression] likely wrong code bug

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58364

--- Comment #4 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Author: jakub
Date: Mon Sep  9 17:09:59 2013
New Revision: 202409

URL: http://gcc.gnu.org/viewcvs?rev=202409&root=gcc&view=rev
Log:
    PR tree-optimization/58364
    * tree-ssa-reassoc.c (init_range_entry): For BIT_NOT_EXPR on
    BOOLEAN_TYPE, only invert in_p and continue with arg0 if
    the current range can't be an unconditional true or false.

    * gcc.c-torture/execute/pr58364.c: New test.

Added:
    trunk/gcc/testsuite/gcc.c-torture/execute/pr58364.c
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/testsuite/ChangeLog
    trunk/gcc/tree-ssa-reassoc.c

[Bug tree-optimization/58364] [4.8/4.9 Regression] likely wrong code bug

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58364

--- Comment #5 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Author: jakub
Date: Mon Sep  9 17:11:05 2013
New Revision: 202410

URL: http://gcc.gnu.org/viewcvs?rev=202410&root=gcc&view=rev
Log:
    PR tree-optimization/58364
    * tree-ssa-reassoc.c (init_range_entry): For BIT_NOT_EXPR on
    BOOLEAN_TYPE, only invert in_p and continue with arg0 if
    the current range can't be an unconditional true or false.

    * gcc.c-torture/execute/pr58364.c: New test.

Added:
    branches/gcc-4_8-branch/gcc/testsuite/gcc.c-torture/execute/pr58364.c
Modified:
    branches/gcc-4_8-branch/gcc/ChangeLog
    branches/gcc-4_8-branch/gcc/testsuite/ChangeLog
    branches/gcc-4_8-branch/gcc/tree-ssa-reassoc.c

[Bug tree-optimization/58364] [4.8/4.9 Regression] likely wrong code bug

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58364

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #6 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Fixed.

[Bug tree-optimization/58364] [4.8/4.9 Regression] likely wrong code bug

[ebotcazou at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58364

Eric Botcazou <ebotcazou at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ebotcazou at gcc dot gnu.org

--- Comment #7 from Eric Botcazou <ebotcazou at gcc dot gnu.org> ---
r195642 is an equivalent fix in the folder (make_range_step).