public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug fortran/58471] [4.8/4.9 Regression] ICE on invalid with missing type constructor and -Wall
       [not found] <bug-58471-4@http.gcc.gnu.org/bugzilla/>
@ 2013-09-20  8:56 ` janus at gcc dot gnu.org
  2013-09-20  9:00 ` janus at gcc dot gnu.org
                   ` (6 subsequent siblings)
  7 siblings, 0 replies; 8+ messages in thread
From: janus at gcc dot gnu.org @ 2013-09-20  8:56 UTC (permalink / raw)
  To: gcc-bugs

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58471

janus at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |ice-on-invalid-code
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2013-09-20
                 CC|                            |janus at gcc dot gnu.org
            Summary|ICE on invalid with missing |[4.8/4.9 Regression] ICE on
                   |type constructor and -Wall  |invalid with missing type
                   |                            |constructor and -Wall
     Ever confirmed|0                           |1

--- Comment #1 from janus at gcc dot gnu.org ---
Confirmed. Seems to be a regression (works with 4.7).


^ permalink raw reply	[flat|nested] 8+ messages in thread
* [Bug fortran/58471] [4.8/4.9 Regression] ICE on invalid with missing type constructor and -Wall
       [not found] <bug-58471-4@http.gcc.gnu.org/bugzilla/>
  2013-09-20  8:56 ` [Bug fortran/58471] [4.8/4.9 Regression] ICE on invalid with missing type constructor and -Wall janus at gcc dot gnu.org
@ 2013-09-20  9:00 ` janus at gcc dot gnu.org
  2013-09-20 19:32 ` janus at gcc dot gnu.org
                   ` (5 subsequent siblings)
  7 siblings, 0 replies; 8+ messages in thread
From: janus at gcc dot gnu.org @ 2013-09-20  9:00 UTC (permalink / raw)
  To: gcc-bugs

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58471

--- Comment #2 from janus at gcc dot gnu.org ---
Can be fixed with this patch:


Index: gcc/fortran/primary.c
===================================================================
--- gcc/fortran/primary.c    (revision 202765)
+++ gcc/fortran/primary.c    (working copy)
@@ -2258,7 +2258,7 @@ gfc_expr_attr (gfc_expr *e)
     case EXPR_FUNCTION:
       gfc_clear_attr (&attr);

-      if (e->value.function.esym != NULL)
+      if (e->value.function.esym && e->value.function.esym->result)
     {
       gfc_symbol *sym = e->value.function.esym->result;
       attr = sym->attr;


^ permalink raw reply	[flat|nested] 8+ messages in thread
* [Bug fortran/58471] [4.8/4.9 Regression] ICE on invalid with missing type constructor and -Wall
       [not found] <bug-58471-4@http.gcc.gnu.org/bugzilla/>
  2013-09-20  8:56 ` [Bug fortran/58471] [4.8/4.9 Regression] ICE on invalid with missing type constructor and -Wall janus at gcc dot gnu.org
  2013-09-20  9:00 ` janus at gcc dot gnu.org
@ 2013-09-20 19:32 ` janus at gcc dot gnu.org
  2013-11-05 19:42 ` pault at gcc dot gnu.org
                   ` (4 subsequent siblings)
  7 siblings, 0 replies; 8+ messages in thread
From: janus at gcc dot gnu.org @ 2013-09-20 19:32 UTC (permalink / raw)
  To: gcc-bugs

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58471

--- Comment #3 from janus at gcc dot gnu.org ---
(In reply to janus from comment #2)
> Can be fixed with this patch:

... which regtests cleanly.


^ permalink raw reply	[flat|nested] 8+ messages in thread
* [Bug fortran/58471] [4.8/4.9 Regression] ICE on invalid with missing type constructor and -Wall
       [not found] <bug-58471-4@http.gcc.gnu.org/bugzilla/>
                   ` (2 preceding siblings ...)
  2013-09-20 19:32 ` janus at gcc dot gnu.org
@ 2013-11-05 19:42 ` pault at gcc dot gnu.org
  2013-11-07 21:25 ` janus at gcc dot gnu.org
                   ` (3 subsequent siblings)
  7 siblings, 0 replies; 8+ messages in thread
From: pault at gcc dot gnu.org @ 2013-11-05 19:42 UTC (permalink / raw)
  To: gcc-bugs

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58471

Paul Thomas <pault at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pault at gcc dot gnu.org

--- Comment #4 from Paul Thomas <pault at gcc dot gnu.org> ---
Hi Janus,

Are you going to apply your fix?

Cheers

Paul


^ permalink raw reply	[flat|nested] 8+ messages in thread
* [Bug fortran/58471] [4.8/4.9 Regression] ICE on invalid with missing type constructor and -Wall
       [not found] <bug-58471-4@http.gcc.gnu.org/bugzilla/>
                   ` (3 preceding siblings ...)
  2013-11-05 19:42 ` pault at gcc dot gnu.org
@ 2013-11-07 21:25 ` janus at gcc dot gnu.org
  2013-11-07 22:39 ` janus at gcc dot gnu.org
                   ` (2 subsequent siblings)
  7 siblings, 0 replies; 8+ messages in thread
From: janus at gcc dot gnu.org @ 2013-11-07 21:25 UTC (permalink / raw)
  To: gcc-bugs

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58471

janus at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|unassigned at gcc dot gnu.org      |janus at gcc dot gnu.org

--- Comment #5 from janus at gcc dot gnu.org ---
Hi Paul,

> Are you going to apply your fix?

yes. Thanks for reminding (I almost forgot about this one). Taking your comment
as an 'ok' and considering that the patch is completely trivial, I will commit
it to trunk soon (and 4.8 afterwards).

Cheers,
Janus


^ permalink raw reply	[flat|nested] 8+ messages in thread
* [Bug fortran/58471] [4.8/4.9 Regression] ICE on invalid with missing type constructor and -Wall
       [not found] <bug-58471-4@http.gcc.gnu.org/bugzilla/>
                   ` (4 preceding siblings ...)
  2013-11-07 21:25 ` janus at gcc dot gnu.org
@ 2013-11-07 22:39 ` janus at gcc dot gnu.org
  2013-11-17 12:00 ` janus at gcc dot gnu.org
  2013-11-17 12:02 ` janus at gcc dot gnu.org
  7 siblings, 0 replies; 8+ messages in thread
From: janus at gcc dot gnu.org @ 2013-11-07 22:39 UTC (permalink / raw)
  To: gcc-bugs

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58471

--- Comment #6 from janus at gcc dot gnu.org ---
Author: janus
Date: Thu Nov  7 22:39:15 2013
New Revision: 204547

URL: http://gcc.gnu.org/viewcvs?rev=204547&root=gcc&view=rev
Log:
2013-11-07  Janus Weil  <janus@gcc.gnu.org>

    PR fortran/58471
    * primary.c (gfc_expr_attr): Check for result symbol.

2013-11-07  Janus Weil  <janus@gcc.gnu.org>

    PR fortran/58471
    * gfortran.dg/constructor_9.f90: New.

Added:
    trunk/gcc/testsuite/gfortran.dg/constructor_9.f90
Modified:
    trunk/gcc/fortran/ChangeLog
    trunk/gcc/fortran/primary.c
    trunk/gcc/testsuite/ChangeLog


^ permalink raw reply	[flat|nested] 8+ messages in thread
* [Bug fortran/58471] [4.8/4.9 Regression] ICE on invalid with missing type constructor and -Wall
       [not found] <bug-58471-4@http.gcc.gnu.org/bugzilla/>
                   ` (5 preceding siblings ...)
  2013-11-07 22:39 ` janus at gcc dot gnu.org
@ 2013-11-17 12:00 ` janus at gcc dot gnu.org
  2013-11-17 12:02 ` janus at gcc dot gnu.org
  7 siblings, 0 replies; 8+ messages in thread
From: janus at gcc dot gnu.org @ 2013-11-17 12:00 UTC (permalink / raw)
  To: gcc-bugs

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58471

--- Comment #7 from janus at gcc dot gnu.org ---
Author: janus
Date: Sun Nov 17 12:00:15 2013
New Revision: 204915

URL: http://gcc.gnu.org/viewcvs?rev=204915&root=gcc&view=rev
Log:
2013-11-17  Janus Weil  <janus@gcc.gnu.org>

    Backport from mainline
    2013-11-07  Janus Weil  <janus@gcc.gnu.org>

    PR fortran/58471
    * primary.c (gfc_expr_attr): Check for result symbol.


2013-11-17  Janus Weil  <janus@gcc.gnu.org>

    Backport from mainline
    2013-11-07  Janus Weil  <janus@gcc.gnu.org>

    PR fortran/58471
    * gfortran.dg/constructor_9.f90: New.

Added:
    branches/gcc-4_8-branch/gcc/testsuite/gfortran.dg/constructor_9.f90
      - copied unchanged from r204547,
trunk/gcc/testsuite/gfortran.dg/constructor_9.f90
Modified:
    branches/gcc-4_8-branch/   (props changed)
    branches/gcc-4_8-branch/gcc/fortran/ChangeLog
    branches/gcc-4_8-branch/gcc/fortran/primary.c
    branches/gcc-4_8-branch/gcc/testsuite/ChangeLog

Propchange: branches/gcc-4_8-branch/
            ('svn:mergeinfo' modified)


^ permalink raw reply	[flat|nested] 8+ messages in thread
* [Bug fortran/58471] [4.8/4.9 Regression] ICE on invalid with missing type constructor and -Wall
       [not found] <bug-58471-4@http.gcc.gnu.org/bugzilla/>
                   ` (6 preceding siblings ...)
  2013-11-17 12:00 ` janus at gcc dot gnu.org
@ 2013-11-17 12:02 ` janus at gcc dot gnu.org
  7 siblings, 0 replies; 8+ messages in thread
From: janus at gcc dot gnu.org @ 2013-11-17 12:02 UTC (permalink / raw)
  To: gcc-bugs

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58471

janus at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #8 from janus at gcc dot gnu.org ---
Fixed on trunk and 4.8. Closing.

Thanks for the report!


^ permalink raw reply	[flat|nested] 8+ messages in thread
end of thread, other threads:[~2013-11-17 12:02 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <bug-58471-4@http.gcc.gnu.org/bugzilla/>
2013-09-20  8:56 ` [Bug fortran/58471] [4.8/4.9 Regression] ICE on invalid with missing type constructor and -Wall janus at gcc dot gnu.org
2013-09-20  9:00 ` janus at gcc dot gnu.org
2013-09-20 19:32 ` janus at gcc dot gnu.org
2013-11-05 19:42 ` pault at gcc dot gnu.org
2013-11-07 21:25 ` janus at gcc dot gnu.org
2013-11-07 22:39 ` janus at gcc dot gnu.org
2013-11-17 12:00 ` janus at gcc dot gnu.org
2013-11-17 12:02 ` janus at gcc dot gnu.org

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).