[Bug fortran/58754] ICE/Regression in [4.7/4.8/4.9] with allocatable character arrays

[Bug fortran/58754] ICE/Regression in [4.7/4.8/4.9] with allocatable character arrays

[burnus at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58754

Tobias Burnus <burnus at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |ice-on-valid-code
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2013-10-16
                 CC|                            |burnus at gcc dot gnu.org
      Known to work|                            |4.6.3
         Depends on|                            |57456
     Ever confirmed|0                           |1
      Known to fail|                            |4.7.3, 4.8.1, 4.9.0

--- Comment #1 from Tobias Burnus <burnus at gcc dot gnu.org> ---
The segfault occurs for trans-array.c's gfc_array_init_size:

5064      if (expr3_elem_size != NULL_TREE)
5065        tmp = expr3_elem_size;
5066      else if (expr3 != NULL)
5067        {
...
5089        tmp = TYPE_SIZE_UNIT (gfc_get_element_type (type));
5092      element_size = fold_convert (size_type_node, tmp);

And here tmp == NULL. I think the problem is that characters have to be handled
separately.

There should be somewhere a PR which is about moving all the memory size
calculation to gfc_trans_allocate - which already does it for scalars - instead
of partially repeating it in gfc_array_init_size. (The current algorithm might
also cause multiple function evaluation, which is wrong, too.)

I believe unifying the could would be the proper fix (and good in terms of code
size/maintenance as well). -- The PR I meant is: PR57456.

[Bug fortran/58754] [4.7/4.8/4.9 Regression] with allocatable character arrays

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58754

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P4
   Target Milestone|---                         |4.7.4
            Summary|ICE/Regression in           |[4.7/4.8/4.9 Regression]
                   |[4.7/4.8/4.9] with          |with allocatable character
                   |allocatable character       |arrays
                   |arrays                      |

[Bug fortran/58754] [4.7/4.8/4.9/4.10 Regression] with allocatable character arrays

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=58754

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.7.4                       |4.8.4

--- Comment #2 from Richard Biener <rguenth at gcc dot gnu.org> ---
The 4.7 branch is being closed, moving target milestone to 4.8.4.

[Bug fortran/58754] [4.8/4.9/5 Regression] with allocatable character arrays

[janus at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=58754

janus at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |janus at gcc dot gnu.org

--- Comment #3 from janus at gcc dot gnu.org ---
*** Bug 64069 has been marked as a duplicate of this bug. ***

[Bug fortran/58754] [4.8/4.9/5 Regression] ICE on allocating character array with source

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=58754

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.8.4                       |4.8.5

--- Comment #4 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
GCC 4.8.4 has been released.

[Bug fortran/58754] [4.8/4.9/5 Regression] ICE on allocating character array with source

[pault at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=58754

Paul Thomas <pault at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pault at gcc dot gnu.org
           Assignee|unassigned at gcc dot gnu.org      |pault at gcc dot gnu.org

--- Comment #5 from Paul Thomas <pault at gcc dot gnu.org> ---
Created attachment 35301
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=35301&action=edit
A preliminary patch

This fixes the problem. However, it will produce multiple evaluations of
function results and expressions. I will introduce a temporary to cover those
cases.

Paul

PS It's a pity I did not clock this before the RC!

[Bug fortran/58754] [4.8/4.9/5 Regression] ICE on allocating character array with source

[dominiq at lps dot ens.fr]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=58754

--- Comment #6 from Dominique d'Humieres <dominiq at lps dot ens.fr> ---
> This fixes the problem. 

Confirmed.

> However, it will produce multiple evaluations of function results
> and expressions. I will introduce a temporary to cover those cases.

Is it obvious?

> PS It's a pity I did not clock this before the RC!

No RC yet!

[Bug fortran/58754] [4.8/4.9/5/6 Regression] ICE on allocating character array with source

[pault at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=58754

--- Comment #7 from Paul Thomas <pault at gcc dot gnu.org> ---
(In reply to Dominique d'Humieres from comment #6)
> > This fixes the problem. 
> 
> Confirmed.
> 
> > However, it will produce multiple evaluations of function results
> > and expressions. I will introduce a temporary to cover those cases.
> 
> Is it obvious?
> 
> > PS It's a pity I did not clock this before the RC!
> 
> No RC yet!

What, really?

Paul

[Bug fortran/58754] [4.8/4.9/5/6 Regression] ICE on allocating character array with source

[dominiq at lps dot ens.fr]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=58754

--- Comment #8 from Dominique d'Humieres <dominiq at lps dot ens.fr> ---
> > No RC yet!
>
> What, really?

Now yes. 5.1 should be available in the middle of next week.

[Bug fortran/58754] [4.8/4.9/5/6 Regression] ICE on allocating character array with source

[paul.richard.thomas at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=58754

--- Comment #9 from paul.richard.thomas at gmail dot com <paul.richard.thomas at gmail dot com> ---
Ah that's a pity. I thought that 5.0 had closed when Tobias was
panicking about his co-array patch. I didn't think to check.

Cheers

Paul

On 17 April 2015 at 18:03, dominiq at lps dot ens.fr
<gcc-bugzilla@gcc.gnu.org> wrote:
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=58754
>
> --- Comment #8 from Dominique d'Humieres <dominiq at lps dot ens.fr> ---
>> > No RC yet!
>>
>> What, really?
>
> Now yes. 5.1 should be available in the middle of next week.
>
> --
> You are receiving this mail because:
> You are on the CC list for the bug.
> You are the assignee for the bug.

[Bug fortran/58754] [4.8/4.9/5/6 Regression] ICE on allocating character array with source

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=58754

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.8.5                       |4.9.3

--- Comment #10 from Richard Biener <rguenth at gcc dot gnu.org> ---
The gcc-4_8-branch is being closed, re-targeting regressions to 4.9.3.

[Bug fortran/58754] [4.9/5/6 Regression] ICE on allocating character array with source

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=58754

--- Comment #11 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
GCC 4.9.3 has been released.

[Bug fortran/58754] [4.9/5/6 Regression] ICE on allocating character array with source

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=58754

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.9.3                       |4.9.4

[Bug fortran/58754] [4.9/5 Regression] ICE on allocating character array with source

[pault at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=58754

Paul Thomas <pault at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[4.9/5/6 Regression] ICE on |[4.9/5 Regression] ICE on
                   |allocating character array  |allocating character array
                   |with source                 |with source

--- Comment #12 from Paul Thomas <pault at gcc dot gnu.org> ---
This is fixed on trunk - I suspect that Andre has put it right. I have applied
my patch to 5 branch and am regtesting it right now.

Paul

[Bug fortran/58754] [4.9/5 Regression] ICE on allocating character array with source

[pault at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=58754

--- Comment #13 from Paul Thomas <pault at gcc dot gnu.org> ---
Author: pault
Date: Thu Oct 22 18:05:21 2015
New Revision: 229179

URL: https://gcc.gnu.org/viewcvs?rev=229179&root=gcc&view=rev
Log:
2015-10-22  Paul Thomas  <pault@gcc.gnu.org>

        PR fortran/58754
        * trans-stmt.c (gfc_trans_allocate): Do not use the scalar
        character assignment if the allocate expression is an array
        descriptor.

2015-10-22  Paul Thomas  <pault@gcc.gnu.org>

        PR fortran/58754
        * gfortran.dg/pr58754.f90: New test

Added:
    branches/gcc-5-branch/gcc/testsuite/gfortran.dg/pr58754.f90
Modified:
    branches/gcc-5-branch/gcc/fortran/ChangeLog
    branches/gcc-5-branch/gcc/fortran/trans-stmt.c
    branches/gcc-5-branch/gcc/testsuite/ChangeLog

[Bug fortran/58754] [4.9/5 Regression] ICE on allocating character array with source

[pault at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=58754

--- Comment #14 from Paul Thomas <pault at gcc dot gnu.org> ---
Author: pault
Date: Thu Oct 22 18:08:31 2015
New Revision: 229180

URL: https://gcc.gnu.org/viewcvs?rev=229180&root=gcc&view=rev
Log:
2015-10-22  Paul Thomas  <pault@gcc.gnu.org>

        PR fortran/58754
        * gfortran.dg/pr58754.f90: New test

Added:
    branches/gcc-4_9-branch/gcc/testsuite/gfortran.dg/pr58754.f90
Modified:
    branches/gcc-4_9-branch/gcc/testsuite/ChangeLog

[Bug fortran/58754] [4.9/5 Regression] ICE on allocating character array with source

[pault at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=58754

Paul Thomas <pault at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #15 from Paul Thomas <pault at gcc dot gnu.org> ---
Dear Juergen,

Thanks for the report. I am sorry that it has taken a long time to get round to
fixing it.

Best regards

Paul