[Bug c++/59389] New: [C++11] bogus error: call of overloaded ‘Foo(<brace-enclosed initializer list>)’ is ambiguous

[Bug c++/59389] New: [C++11] bogus error: call of overloaded ‘Foo(<brace-enclosed initializer list>)’ is ambiguous

[ppluzhnikov at google dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59389

            Bug ID: 59389
           Summary: [C++11] bogus error: call of overloaded
                    ‘Foo(<brace-enclosed initializer list>)’ is ambiguous
           Product: gcc
           Version: unknown
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: c++
          Assignee: unassigned at gcc dot gnu.org
          Reporter: ppluzhnikov at google dot com

Google ref: b/11997192

Using current trunk:
g++ (GCC) 4.9.0 20131204 (experimental)

// --- cut ---
#include <string>
#include <vector>
#include <map>

struct Foo {
  Foo(const std::map<std::string, std::vector<std::string>>&);
};

int main()
{
  Foo foo2({{"abc", {"aaa", "bbb"}}});  // OK
  Foo foo1({{"abc", {"aaa"}}});         // Error.
}
// --- cut ---

g++ -c -std=c++11 t.cc

t.cc: In function 'int main()':
t.cc:12:30: error: call of overloaded 'Foo(<brace-enclosed initializer list>)'
is ambiguous
   Foo foo1({{"abc", {"aaa"}}});         // Error.
                              ^
t.cc:12:30: note: candidates are:
t.cc:6:3: note: Foo::Foo(const std::map<std::basic_string<char>,
std::vector<std::basic_string<char> > >&)
   Foo(const std::map<std::string, std::vector<std::string>>&);
   ^
t.cc:5:8: note: constexpr Foo::Foo(const Foo&)
 struct Foo {
        ^
t.cc:5:8: note: constexpr Foo::Foo(Foo&&)
>From gcc-bugs-return-436665-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Wed Dec 04 19:35:35 2013
Return-Path: <gcc-bugs-return-436665-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 25237 invoked by alias); 4 Dec 2013 19:35:34 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 25219 invoked by uid 48); 4 Dec 2013 19:35:31 -0000
From: "ppluzhnikov at google dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c++/59389] [C++11] bogus error:=?UTF-8?Q? call of overloaded ‘Foo?=(<brace-enclosed initializer list>)=?UTF-8?Q?’ is ambiguous?Date: Wed, 04 Dec 2013 19:35:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: c++
X-Bugzilla-Version: unknown
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: ppluzhnikov at google dot com
X-Bugzilla-Status: RESOLVED
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: bug_status resolution
Message-ID: <bug-59389-4-vyqj7RuXSA@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-59389-4@http.gcc.gnu.org/bugzilla/>
References: <bug-59389-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2013-12/txt/msg00320.txt.bz2
Content-length: 911

http://gcc.gnu.org/bugzilla/show_bug.cgi?idY389

Paul Pluzhnikov <ppluzhnikov at google dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |INVALID

--- Comment #1 from Paul Pluzhnikov <ppluzhnikov at google dot com> ---
Hmm, Clang also rejects this test:

t.cc:12:7: error: call to constructor of 'Foo' is ambiguous
  Foo foo1({{"abc", {"aaa"}}});         // Error.
      ^    ~~~~~~~~~~~~~~~~~~
t.cc:5:8: note: candidate is the implicit move constructor
struct Foo {
       ^
t.cc:5:8: note: candidate is the implicit copy constructor
t.cc:6:3: note: candidate constructor
  Foo(const std::map<std::string, std::vector<std::string>>&);
  ^
1 error generated.


I must have over-reduced the original.

[Bug c++/59389] [C++11] bogus error: call of overloaded ‘Foo(<brace-enclosed initializer list>)’ is ambiguous

[ppluzhnikov at google dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59389

Paul Pluzhnikov <ppluzhnikov at google dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |rejects-valid
             Status|RESOLVED                    |UNCONFIRMED
         Resolution|INVALID                     |---

--- Comment #2 from Paul Pluzhnikov <ppluzhnikov at google dot com> ---
Here is the test that compiles with Clang but not GCC (added explicit to
Foo::Foo):

#include <string>
#include <vector>
#include <map>

struct Foo {
  explicit Foo(const std::map<std::string, std::vector<std::string>>&
machines);
};

int main()
{
  Foo foo2({{"abc", {"aaa", "bbb"}}});  // OK
  Foo foo1({{"abc", {"aaa"}}});         // Error.
}

[Bug c++/59389] [C++11] bogus error: call of overloaded ‘Foo(<brace-enclosed initializer list>)’ is ambiguous

[manu at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59389

Manuel López-Ibáñez <manu at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |manu at gcc dot gnu.org

--- Comment #3 from Manuel López-Ibáñez <manu at gcc dot gnu.org> ---
Even in the first case the diagnostic is quite poor compared with clang's
(location info included).
>From gcc-bugs-return-436678-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Wed Dec 04 22:13:20 2013
Return-Path: <gcc-bugs-return-436678-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 7358 invoked by alias); 4 Dec 2013 22:13:19 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 7325 invoked by uid 48); 4 Dec 2013 22:13:14 -0000
From: "awwafa at gmail dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug libstdc++/59391] New: std::sort will go out of std::vector bounds and crash
Date: Wed, 04 Dec 2013 22:13:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: new
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: libstdc++
X-Bugzilla-Version: 4.4.6
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: awwafa at gmail dot com
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: bug_id short_desc product version bug_status bug_severity priority component assigned_to reporter
Message-ID: <bug-59391-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2013-12/txt/msg00333.txt.bz2
Content-length: 4621

http://gcc.gnu.org/bugzilla/show_bug.cgi?idY391

            Bug ID: 59391
           Summary: std::sort will go out of std::vector bounds and crash
           Product: gcc
           Version: 4.4.6
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: libstdc++
          Assignee: unassigned at gcc dot gnu.org
          Reporter: awwafa at gmail dot com

$ gcc -v
Using built-in specs.
Target: x86_64-redhat-linux
Configured with: ../configure --prefix=/usr --mandir=/usr/share/man
--infodir=/usr/share/info --with-bugurl=http://bugzilla.redhat.com/bugzilla
--enable-bootstrap --enable-shared --enable-threads=posix
--enable-checking=release --with-system-zlib --enable-__cxa_atexit
--disable-libunwind-exceptions --enable-gnu-unique-object
--enable-languages=c,c++,objc,obj-c++,java,fortran,ada --enable-java-awt=gtk
--disable-dssi --with-java-home=/usr/lib/jvm/java-1.5.0-gcj-1.5.0.0/jre
--enable-libgcj-multifile --enable-java-maintainer-mode
--with-ecj-jar=/usr/share/java/eclipse-ecj.jar --disable-libjava-multilib
--with-ppl --with-cloog --with-tune=generic --with-arch_32=i686
--build=x86_64-redhat-linux
Thread model: posix
gcc version 4.4.6 20110731 (Red Hat 4.4.6-3) (GCC)

----------- gcc switches used -----
g++  -o sort_test.o  -c sort_test.cxx
g++  -o sort_test  sort_test.o

------------ sort_test.cxx---------
#include <algorithm>
#include <vector>

bool compare_val(int* a, int* b) {
   if (*a <= *b) return true;
   return false;
}
int main (void) {

  const int int_array[] = {12, 13, 2, 2, 6, 7, 12, 2, 10, 11, 16, 5, 5, 2, 16,
7, 6, 16, 14, 5, 10, 9, 14, 3, 7, 15, 14, 6, 2, 1, 11, 13, 14, 12, 15, 4, 3,
11, 5, 12, 5, 5, 1, 9, 6, 16, 15, 11, 16, 13, 15, 10, 6, 13, 13, 12, 11, 10, 1,
13, 11, 11, 10, 9, 7, 8, 12, 10, 2};

   std::vector<int*> my_vec;
   int length = sizeof(int_array)/sizeof(int);
   for(int i=0; i < length; ++i) {
      int *int_ptr =new int;
      *int_ptr = int_array[i];
      my_vec.push_back(int_ptr);
   }
   std::sort(my_vec.begin(), my_vec.end(), compare_val);
}
------------ sort_test.cxx---------


---------------- Valgrind output -----------------
= 061== Memcheck, a memory error detector
= 061== Copyright (C) 2002-2009, and GNU GPL'd, by Julian Seward et al.
= 061== Using Valgrind-3.5.0 and LibVEX; rerun with -h for copyright info
= 061== Command: ./sort_test
= 061== 061== Invalid read of size 8
= 061==    at 0x40159E: __gnu_cxx::__normal_iterator<int**, std::vector<int*,
std::allocator<int*> > >
std::__unguarded_partition<__gnu_cxx::__normal_iterator<int**,
std::vector<int*, std::allocator<int*> > >, int*, bool (*)(int*,
int*)>(__gnu_cxx::__normal_iterator<int**, std::vector<int*,
std::allocator<int*> > >, __gnu_cxx::__normal_iterator<int**, std::vector<int*,
std::allocator<int*> > >, int*, bool (*)(int*, int*)) (in
/home/awafa/tmp/std_sort_crash/sort_test)
= 061==    by 0x4010B8: void
std::__introsort_loop<__gnu_cxx::__normal_iterator<int**, std::vector<int*,
std::allocator<int*> > >, long, bool (*)(int*,
int*)>(__gnu_cxx::__normal_iterator<int**, std::vector<int*,
std::allocator<int*> > >, __gnu_cxx::__normal_iterator<int**, std::vector<int*,
std::allocator<int*> > >, long, bool (*)(int*, int*)) (in
/home/awafa/tmp/std_sort_crash/sort_test)
= 061==    by 0x400B08: void std::sort<__gnu_cxx::__normal_iterator<int**,
std::vector<int*, std::allocator<int*> > >, bool (*)(int*,
int*)>(__gnu_cxx::__normal_iterator<int**, std::vector<int*,
std::allocator<int*> > >, __gnu_cxx::__normal_iterator<int**, std::vector<int*,
std::allocator<int*> > >, bool (*)(int*, int*)) (in
/home/awafa/tmp/std_sort_crash/sort_test)
= 061==    by 0x40092A: main (in /home/awafa/tmp/std_sort_crash/sort_test)
= 061==  Address 0x4a33a48 is 8 bytes before a block of size 1,024 alloc'd
= 061==    at 0x490459B: operator new(unsigned long)
(vg_replace_malloc.c:220)
= 061==    by 0x401844: __gnu_cxx::new_allocator<int*>::allocate(unsigned
long, void const*) (in /home/awafa/tmp/std_sort_crash/sort_test)
= 061==    by 0x4012C9: std::_Vector_base<int*, std::allocator<int*>
>::_M_allocate(unsigned long) (in /home/awafa/tmp/std_sort_crash/sort_test)
= 061==    by 0x400D5A: std::vector<int*, std::allocator<int*>
>::_M_insert_aux(__gnu_cxx::__normal_iterator<int**, std::vector<int*,
std::allocator<int*> > >, int* const&) (in
/home/awafa/tmp/std_sort_crash/sort_test)
= 061==    by 0x400A73: std::vector<int*, std::allocator<int*>
>::push_back(int* const&) (in /home/awafa/tmp/std_sort_crash/sort_test)
= 061==    by 0x4008E1: main (in /home/awafa/tmp/std_sort_crash/sort_test)

[Bug c++/59389] [C++11] bogus error: call of overloaded ‘Foo(<brace-enclosed initializer list>)’ is ambiguous

[ppluzhnikov at google dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59389

Paul Pluzhnikov <ppluzhnikov at google dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |richard-gccbugzilla@metafoo
                   |                            |.co.uk

--- Comment #4 from Paul Pluzhnikov <ppluzhnikov at google dot com> ---
Richard Smith is not yet sure whether this is a GCC bug (rejects valid),
or a Clang bug (accepts invalid):

> I'll need to dig into this a bit more (in particular, to check whether
> [over.best.ics]p4 should apply here and prevent us from considering the
> weird second option) but I think this is a Clang bug.

[Bug c++/59389] [C++11] bogus error: call of overloaded ‘Foo(<brace-enclosed initializer list>)’ is ambiguous

[richard-gccbugzilla at metafoo dot co.uk]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59389

--- Comment #5 from Richard Smith <richard-gccbugzilla at metafoo dot co.uk> ---
Under [over.best.ics]p4, I think both the original example in comment#0 and the
example in comment#2 are valid (so GCC is incorrect to reject both and Clang is
incorrect to reject #2).

The user-defined conversion from {"abc", {"aaa"}} to Foo is not considered when
forming the implicit conversion sequence for the first parameter of Foo's copy
or move constructor, so neither of those is viable in either case. But see also
core issue 1758.

[Bug c++/59389] [C++11] bogus error: call of overloaded ‘Foo(<brace-enclosed initializer list>)’ is ambiguous

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=59389

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Last reconfirmed|                            |2021-07-31
             Status|UNCONFIRMED                 |NEW
     Ever confirmed|0                           |1

[Bug c++/59389] [C++11] bogus error: call of overloaded ‘Foo(<brace-enclosed initializer list>)’ is ambiguous

[vital.had at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=59389

Sergey Fedorov <vital.had at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |vital.had at gmail dot com

--- Comment #6 from Sergey Fedorov <vital.had at gmail dot com> ---
Has this ever been addressed?

I am getting a similar-looking error with gcc-13.2.0 now:
https://github.com/NGSolve/ngsolve/issues/68

[Bug c++/59389] [C++11] bogus error: call of overloaded ‘Foo(<brace-enclosed initializer list>)’ is ambiguous

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=59389

--- Comment #7 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
(In reply to Sergey Fedorov from comment #6)
> I am getting a similar-looking error with gcc-13.2.0 now:
> https://github.com/NGSolve/ngsolve/issues/68

Both clang and GCC reject the original testcase still ....
So I doubt this is the same issue ...

[Bug c++/59389] [C++11] bogus error: call of overloaded ‘Foo(<brace-enclosed initializer list>)’ is ambiguous

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=59389

--- Comment #8 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
(In reply to Andrew Pinski from comment #7)
> (In reply to Sergey Fedorov from comment #6)
> > I am getting a similar-looking error with gcc-13.2.0 now:
> > https://github.com/NGSolve/ngsolve/issues/68
> 
> Both clang and GCC reject the original testcase still ....
> So I doubt this is the same issue ...

Also the testcase in comment #2 works with GCC 13.2.0 while fails with GCC
13.1.0 ...