[Bug bootstrap/59447] New: --with-dwarf2 is not propagated correctly, will always create dwarf4 by default

[Bug bootstrap/59447] New: --with-dwarf2 is not propagated correctly, will always create dwarf4 by default

[rose.garcia-eggl2fk at yopmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59447

            Bug ID: 59447
           Summary: --with-dwarf2 is not propagated correctly, will always
                    create dwarf4 by default
           Product: gcc
           Version: 4.8.2
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: bootstrap
          Assignee: unassigned at gcc dot gnu.org
          Reporter: rose.garcia-eggl2fk at yopmail dot com

even if one manages that --with-dwarf2 gets properly redirected to
gcc/configure from the toplevel configure script ( i used

        GCC_DWARF_CONFFLAGS="--with-dwarf2=yes" ;
        export host_configargs="$GCC_DWARF_CONFFLAGS" ;
        export target_configargs="$GCC_DWARF_CONFFLAGS" ;
        export build_configargs="$GCC_DWARF_CONFFLAGS" ;

plus i passed it to top-level configure), gcc will still default to DWARF4, and
all created binaries will have dwarf4 debug info, unless -gdwarf-2 was passed
explicitly on the command line.

the culprit is this line
gcc-4.8.2/gcc/common.opt:Common Joined UInteger Var(dwarf_version) Init(4)
Negative(gstabs)

introduced in commit 
http://repo.or.cz/w/official-gcc.git/commitdiff/052166fd4a8051c7dc4c87d408be091c99aafd55

note that even the command below still talks about dwarf2.
i see nothing in the build system that would fill in the required 2 here
instead of the 4, and indeed the generated options.c has dwarf_version = 4 in
it.

[Bug bootstrap/59447] --with-dwarf2 is not propagated correctly, will always create dwarf4 by default

[joseph at codesourcery dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59447

--- Comment #1 from joseph at codesourcery dot com <joseph at codesourcery dot com> ---
This is a documentation bug - the installation manual should make clear 
that "DWARF 2" in the description of this option means DWARF 2 or later, 
as appropriate for the target, as opposed to (for example) STABS.

[Bug bootstrap/59447] --with-dwarf2 should be documented as meaning "DWARF 2 or later" instead of just "DWARF 2"

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=59447

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Last reconfirmed|2017-09-07 00:00:00         |2022-1-5

--- Comment #6 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
diff --git a/gcc/configure.ac b/gcc/configure.ac
index 247371e6537..78c9bb15531 100644
--- a/gcc/configure.ac
+++ b/gcc/configure.ac
@@ -1002,7 +1002,7 @@ fi,
 objc_boehm_gc='')

 AC_ARG_WITH(dwarf2,
-[AS_HELP_STRING([--with-dwarf2], [force the default debug format to be DWARF
2])],
+[AS_HELP_STRING([--with-dwarf2], [force the default debug format to be DWARF 2
(or later)])],
 dwarf2="$with_dwarf2",
 dwarf2=no)



I think will fix the issue.

[Bug bootstrap/59447] --with-dwarf2 should be documented as meaning "DWARF 2 or later" instead of just "DWARF 2"

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=59447

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|unassigned at gcc dot gnu.org      |pinskia at gcc dot gnu.org
             Status|NEW                         |ASSIGNED

--- Comment #7 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Actually this will solve it fully:
diff --git a/gcc/configure.ac b/gcc/configure.ac
index 247371e6537..78c9bb15531 100644
--- a/gcc/configure.ac
+++ b/gcc/configure.ac
@@ -1002,7 +1002,7 @@ fi,
 objc_boehm_gc='')

 AC_ARG_WITH(dwarf2,
-[AS_HELP_STRING([--with-dwarf2], [force the default debug format to be DWARF
2])],
+[AS_HELP_STRING([--with-dwarf2], [force the default debug format to be DWARF 2
(or later)])],
 dwarf2="$with_dwarf2",
 dwarf2=no)

diff --git a/gcc/doc/install.texi b/gcc/doc/install.texi
index 54ad7c7b47c..56136ff0e7f 100644
--- a/gcc/doc/install.texi
+++ b/gcc/doc/install.texi
@@ -1872,7 +1872,7 @@ should not be built.

 @item --with-dwarf2
 Specify that the compiler should
-use DWARF 2 debugging information as the default.
+use DWARF 2 (or later) debugging information as the default.

 @item --with-advance-toolchain=@var{at}
 On 64-bit PowerPC Linux systems, configure the compiler to use the


Let me take it and submit the patch.

[Bug bootstrap/59447] --with-dwarf2 should be documented as meaning "DWARF 2 or later" instead of just "DWARF 2"

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=59447

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|pinskia at gcc dot gnu.org         |unassigned at gcc dot gnu.org
             Status|ASSIGNED                    |NEW

--- Comment #8 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
No longer working on this one.

[Bug bootstrap/59447] --with-dwarf2 should be documented as meaning "DWARF 2 or later" instead of just "DWARF 2"

[egallager at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=59447

Eric Gallager <egallager at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|unassigned at gcc dot gnu.org      |egallager at gcc dot gnu.org

--- Comment #9 from Eric Gallager <egallager at gcc dot gnu.org> ---
I guess I can take this

[Bug bootstrap/59447] --with-dwarf2 should be documented as meaning "DWARF 2 or later" instead of just "DWARF 2"

[egallager at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=59447

Eric Gallager <egallager at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch
                URL|                            |https://gcc.gnu.org/piperma
                   |                            |il/gcc-patches/2022-Decembe
                   |                            |r/607702.html

--- Comment #10 from Eric Gallager <egallager at gcc dot gnu.org> ---
Patch posted:
https://gcc.gnu.org/pipermail/gcc-patches/2022-December/607702.html

[Bug bootstrap/59447] --with-dwarf2 should be documented as meaning "DWARF 2 or later" instead of just "DWARF 2"

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=59447

--- Comment #11 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Eric Gallager <egallager@gcc.gnu.org>:

https://gcc.gnu.org/g:a710f3ce7474792c098ac6fe4dc6a366cdbb4fb4

commit r13-4457-ga710f3ce7474792c098ac6fe4dc6a366cdbb4fb4
Author: Eric Gallager <egallager@gcc.gnu.org>
Date:   Fri Dec 2 01:08:45 2022 -0500

    PR59447: --with-dwarf2 implies "(or later)"

    This patch includes "(or later)" in the documentation of the gcc
    subdirectory's --with-dwarf2 configure flag. Closes PR59447.

    gcc/ChangeLog:

            PR bootstrap/59447
            * configure: Regenerate.
            * configure.ac: Document --with-dwarf2 flag as also
            applying to later DWARF standards.
            * doc/install.texi: Likewise.

[Bug bootstrap/59447] --with-dwarf2 should be documented as meaning "DWARF 2 or later" instead of just "DWARF 2"

[egallager at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=59447

Eric Gallager <egallager at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #12 from Eric Gallager <egallager at gcc dot gnu.org> ---
Fixed.