[Bug fortran/59599] New: Compiler internal error on intrinsic ichar

[Bug fortran/59599] New: Compiler internal error on intrinsic ichar

[fmartinez at gmv dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59599

            Bug ID: 59599
           Summary: Compiler internal error on intrinsic ichar
           Product: gcc
           Version: 4.9.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: fortran
          Assignee: unassigned at gcc dot gnu.org
          Reporter: fmartinez at gmv dot com

Created attachment 31513
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=31513&action=edit
Source code generatin the execption

When using the optional paramenter kind in the invocation of intrinsic function
ichar the following exception is thrown:

m_util_convert.f90:767:0: internal compiler error: in gfc_trans_assignment_1,
at fortran/trans-expr.c:8006
   res = ichar( cpk, kind=1 )
 ^

Source file attached

[Bug fortran/59599] Compiler internal error on intrinsic ichar

[fmartinez at gmv dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59599

--- Comment #2 from Fran Martinez Fadrique <fmartinez at gmv dot com> ---
*** Bug 60118 has been marked as a duplicate of this bug. ***

[Bug fortran/59599] Compiler internal error on intrinsic ichar

[mikael at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59599

Mikael Morin <mikael at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mikael at gcc dot gnu.org

--- Comment #3 from Mikael Morin <mikael at gcc dot gnu.org> ---
in trans-intrinsic's gfc_conv_intrinsic_function_args:

      if (e->ts.type == BT_CHARACTER)
    {
      gfc_conv_expr (&argse, e);
      gfc_conv_string_parameter (&argse);
          argarray[curr_arg++] = argse.string_length;
      gcc_assert (curr_arg < nargs);
    }

we evaluate the string lenth into argarray[curr_arg], but argarray[curr_arg] is
supposed to be the place where the next function argument lies.  So in the
testcase, we don't evaluate the "kind" argument to "ichar" and all hell breaks
loose from that.

[Bug fortran/59599] Compiler internal error on intrinsic ichar

[mikael at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59599

--- Comment #4 from Mikael Morin <mikael at gcc dot gnu.org> ---
(In reply to Mikael Morin from comment #3)
> we evaluate the string lenth into argarray[curr_arg],
s/lenth/length/

> but argarray[curr_arg]
> is supposed to be the place where the next function argument lies.
To be clear: it's the place where the next function argument will be put once
evaluated, but we don't get to that point because curr_arg is bumped and we
have the wanted number of arguments.

[Bug fortran/59599] Compiler internal error on intrinsic ichar

[mikael at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59599

--- Comment #5 from Mikael Morin <mikael at gcc dot gnu.org> ---
Patch:

diff --git a/gcc/fortran/trans-intrinsic.c b/gcc/fortran/trans-intrinsic.c
index 1eb9490..1e1a137 100644
--- a/gcc/fortran/trans-intrinsic.c
+++ b/gcc/fortran/trans-intrinsic.c
@@ -4690,7 +4690,7 @@ gfc_conv_intrinsic_ichar (gfc_se * se, gfc_expr * expr)
 {
   tree args[2], type, pchartype;

-  gfc_conv_intrinsic_function_args (se, expr, args, 2);
+  gfc_conv_intrinsic_function_args (se, expr, args, 3);
   gcc_assert (POINTER_TYPE_P (TREE_TYPE (args[1])));
   pchartype = gfc_get_pchar_type (expr->value.function.actual->expr->ts.kind);
   args[1] = fold_build1_loc (input_location, NOP_EXPR, pchartype, args[1]);

[Bug fortran/59599] Compiler internal error on intrinsic ichar

[mikael at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59599

--- Comment #6 from Mikael Morin <mikael at gcc dot gnu.org> ---
(In reply to Mikael Morin from comment #5)
> Patch:
> 
doesn't work. :-(

[Bug fortran/59599] Compiler internal error on intrinsic ichar

[mikael at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59599

--- Comment #7 from Mikael Morin <mikael at gcc dot gnu.org> ---
(In reply to Mikael Morin from comment #6)
> (In reply to Mikael Morin from comment #5)
> > Patch:
> > 
> doesn't work. :-(

ichar's kind argument is optional, so passing a constant number of arguments to
gfc_conv_intrinsic_function_args is bogus.
This is a stage1 bug anyway (non-regression).

diff --git a/gcc/fortran/trans-intrinsic.c b/gcc/fortran/trans-intrinsic.c
index 1eb9490..cff8e89 100644
--- a/gcc/fortran/trans-intrinsic.c
+++ b/gcc/fortran/trans-intrinsic.c
@@ -4689,8 +4689,10 @@ static void
 gfc_conv_intrinsic_ichar (gfc_se * se, gfc_expr * expr)
 {
   tree args[2], type, pchartype;
+  int nargs;

-  gfc_conv_intrinsic_function_args (se, expr, args, 2);
+  nargs = gfc_intrinsic_argument_list_length (expr);
+  gfc_conv_intrinsic_function_args (se, expr, args, nargs);
   gcc_assert (POINTER_TYPE_P (TREE_TYPE (args[1])));
   pchartype = gfc_get_pchar_type (expr->value.function.actual->expr->ts.kind);
   args[1] = fold_build1_loc (input_location, NOP_EXPR, pchartype, args[1]);

[Bug fortran/59599] Compiler internal error on intrinsic ichar

[mikael at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59599

--- Comment #8 from Mikael Morin <mikael at gcc dot gnu.org> ---
Author: mikael
Date: Sat Feb 15 11:48:41 2014
New Revision: 207799

URL: http://gcc.gnu.org/viewcvs?rev=207799&root=gcc&view=rev
Log:
fortran/
        PR fortran/59599
        * trans-intrinsic.c (gfc_conv_intrinsic_ichar): Calculate the
        number of arguments.

testsuite/
        PR fortran/59599
        * gfortran.dg/ichar_3.f90: New test.


Added:
    trunk/gcc/testsuite/gfortran.dg/ichar_3.f90
Modified:
    trunk/gcc/fortran/ChangeLog
    trunk/gcc/fortran/trans-intrinsic.c
    trunk/gcc/testsuite/ChangeLog

[Bug fortran/59599] Compiler internal error on intrinsic ichar

[mikael at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59599

--- Comment #9 from Mikael Morin <mikael at gcc dot gnu.org> ---
Author: mikael
Date: Sat Feb 22 12:22:17 2014
New Revision: 208042

URL: http://gcc.gnu.org/viewcvs?rev=208042&root=gcc&view=rev
Log:
fortran/
        PR fortran/59599
        * trans-intrinsic.c (gfc_conv_intrinsic_ichar): Calculate the
        number of arguments.

testsuite/
        PR fortran/59599
        * gfortran.dg/ichar_3.f90: New test.


Added:
    branches/gcc-4_8-branch/gcc/testsuite/gfortran.dg/ichar_3.f90
Modified:
    branches/gcc-4_8-branch/gcc/fortran/ChangeLog
    branches/gcc-4_8-branch/gcc/fortran/trans-intrinsic.c
    branches/gcc-4_8-branch/gcc/testsuite/ChangeLog

[Bug fortran/59599] Compiler internal error on intrinsic ichar

[mikael at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59599

--- Comment #10 from Mikael Morin <mikael at gcc dot gnu.org> ---
Author: mikael
Date: Sat Feb 22 12:41:53 2014
New Revision: 208043

URL: http://gcc.gnu.org/viewcvs?rev=208043&root=gcc&view=rev
Log:
fortran/
        PR fortran/59599
        * trans-intrinsic.c (gfc_conv_intrinsic_ichar): Calculate the
        number of arguments.

testsuite/
        PR fortran/59599
        * gfortran.dg/ichar_3.f90: New test.


Added:
    branches/gcc-4_7-branch/gcc/testsuite/gfortran.dg/ichar_3.f90
Modified:
    branches/gcc-4_7-branch/gcc/fortran/ChangeLog
    branches/gcc-4_7-branch/gcc/fortran/trans-intrinsic.c
    branches/gcc-4_7-branch/gcc/testsuite/ChangeLog

[Bug fortran/59599] Compiler internal error on intrinsic ichar

[mikael at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59599

Mikael Morin <mikael at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED
           Assignee|unassigned at gcc dot gnu.org      |mikael at gcc dot gnu.org

--- Comment #11 from Mikael Morin <mikael at gcc dot gnu.org> ---
Bug fixed for 4.7.4, 4.8.3 and 4.9.0.
Thanks for reporting it.