[Bug libfortran/59771] New: Cleanup handling of Gw.0 and Gw.0Ee format

[Bug libfortran/59771] New: Cleanup handling of Gw.0 and Gw.0Ee format

[jvdelisle at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59771

            Bug ID: 59771
           Summary: Cleanup handling of Gw.0 and Gw.0Ee format
           Product: gcc
           Version: 4.9.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: libfortran
          Assignee: jvdelisle at gcc dot gnu.org
          Reporter: jvdelisle at gcc dot gnu.org

Carried over from PR48906 Comment 38

"If d is zero, kPEw.0 or kPEw.0Ee editing is used for Gw.0 editing or Gw.0Ee
editing respectively."

Possible patch needs more testing:

Index: write_float.def
===================================================================
--- write_float.def    (revision 206545)
+++ write_float.def    (working copy)
@@ -1046,7 +1046,8 @@
   rexp_d = calculate_exp_ ## x (-d);\
   if ((m > 0.0 && ((m < 0.1 - 0.1 * r * rexp_d) || (rexp_d * (m + r) >=
1.0)))\
       || ((m == 0.0) && !(compile_options.allow_std\
-              & (GFC_STD_F2003 | GFC_STD_F2008))))\
+              & (GFC_STD_F2003 | GFC_STD_F2008)))\
+      ||  d == 0)\
     { \
       newf.format = FMT_E;\
       newf.u.real.w = w;\

[Bug libfortran/59771] Cleanup handling of Gw.0 and Gw.0Ee format

[jvdelisle at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59771

Jerry DeLisle <jvdelisle at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2014-01-11
     Ever confirmed|0                           |1

--- Comment #1 from Jerry DeLisle <jvdelisle at gcc dot gnu.org> ---
A simple test case:

 PRINT '(6(1X,1PG9.0e2))', 0.0, 0.04, 0.06, 0.4, 0.6, 243.0
 PRINT '(6(1X,1PE9.0e2))', 0.0, 0.04, 0.06, 0.4, 0.6, 243.0

end

Without patch:

 ./a.out 
At line 1 of file pr48906.f90 (unit = 6, file = 'stdout')
Internal Error: Unspecified precision

With patch:

 ./a.out 
    0.E+00    4.E-02    6.E-02    4.E-01    6.E-01    2.E+02
    0.E+00    4.E-02    6.E-02    4.E-01    6.E-01    2.E+02

[Bug libfortran/59771] Cleanup handling of Gw.0 and Gw.0Ee format

[jvdelisle at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59771

--- Comment #2 from Jerry DeLisle <jvdelisle at gcc dot gnu.org> ---
Author: jvdelisle
Date: Sun Jan 19 23:17:43 2014
New Revision: 206785

URL: http://gcc.gnu.org/viewcvs?rev=206785&root=gcc&view=rev
Log:
2014-01-19  Jerry DeLisle  <jvdelisle@gcc.gnu>
        Dominique d'Humieres  <dominiq@lps.ens.fr>

    PR libfortran/59771
    PR libfortran/59774
    PR libfortran/59836
    * io/write_float.def (output_float): Fix wrong handling of the
    Fw.0 format.
    (output_float_FMT_G_): Fixes rounding issues with -m32.

Modified:
    trunk/libgfortran/ChangeLog
    trunk/libgfortran/io/write_float.def

[Bug libfortran/59771] Cleanup handling of Gw.0 and Gw.0Ee format

[jvdelisle at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59771

--- Comment #3 from Jerry DeLisle <jvdelisle at gcc dot gnu.org> ---
Author: jvdelisle
Date: Sun Jan 19 23:21:10 2014
New Revision: 206786

URL: http://gcc.gnu.org/viewcvs?rev=206786&root=gcc&view=rev
Log:
2014-01-19  Steven G. Kargl  <kargl@gcc.gnu.org>

    PR libfortran/59771
    PR libfortran/59774
    PR libfortran/59836
    * gfortran.dg/round_3.f08: New cases added.
    * gfortran.dg/fmt_g_1.f90: New test.

Added:
    trunk/gcc/testsuite/gfortran.dg/fmt_g_1.f90
Modified:
    trunk/gcc/testsuite/ChangeLog
    trunk/gcc/testsuite/gfortran.dg/round_3.f08

[Bug libfortran/59771] Cleanup handling of Gw.0 and Gw.0Ee format

[jvdelisle at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59771

--- Comment #4 from Jerry DeLisle <jvdelisle at gcc dot gnu.org> ---
Author: jvdelisle
Date: Sat Feb 15 15:48:48 2014
New Revision: 207801

URL: http://gcc.gnu.org/viewcvs?rev=207801&root=gcc&view=rev
Log:
2014-02-15  Jerry DeLisle  <jvdelisle@gcc.gnu>
        Dominique d'Humieres  <dominiq@lps.ens.fr>

    Backport from mainline
    PR libfortran/59771
    PR libfortran/59774
    PR libfortran/59836
    * io/write_float.def (output_float): Fix wrong handling of the
    Fw.0 format.
    (output_float_FMT_G_): Fixes rounding issues with -m32.

Modified:
    branches/gcc-4_8-branch/libgfortran/ChangeLog
    branches/gcc-4_8-branch/libgfortran/io/write_float.def

[Bug libfortran/59771] Cleanup handling of Gw.0 and Gw.0Ee format

[jvdelisle at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59771

--- Comment #5 from Jerry DeLisle <jvdelisle at gcc dot gnu.org> ---
Author: jvdelisle
Date: Sat Feb 15 15:57:35 2014
New Revision: 207802

URL: http://gcc.gnu.org/viewcvs?rev=207802&root=gcc&view=rev
Log:
2014-02-15  Jerry DeLisle  <jvdelisle@gcc.gnu>
        Dominique d'Humieres  <dominiq@lps.ens.fr>

    Backport from mainline
    PR libfortran/59771
    PR libfortran/59774
    PR libfortran/59836
    * gfortran.dg/fmt_g_1.f90: New test.
    * gfortran.dg/round_3.f08: New cases added.

Added:
    branches/gcc-4_8-branch/gcc/testsuite/gfortran.dg/fmt_g_1.f90
Modified:
    branches/gcc-4_8-branch/gcc/testsuite/ChangeLog
    branches/gcc-4_8-branch/gcc/testsuite/gfortran.dg/round_3.f08

[Bug libfortran/59771] Cleanup handling of Gw.0 and Gw.0Ee format

[jvdelisle at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59771

--- Comment #6 from Jerry DeLisle <jvdelisle at gcc dot gnu.org> ---
Author: jvdelisle
Date: Sat Feb 15 16:53:07 2014
New Revision: 207803

URL: http://gcc.gnu.org/viewcvs?rev=207803&root=gcc&view=rev
Log:
2014-02-15  Jerry DeLisle  <jvdelisle@gcc.gnu>
        Dominique d'Humieres  <dominiq@lps.ens.fr>

    Backport from mainline
    PR libfortran/59771
    PR libfortran/59774
    PR libfortran/59836
    * io/write_float.def (output_float): Fix wrong handling of the
    Fw.0 format.
    (output_float_FMT_G_): Fixes rounding issues with -m32.

Modified:
    branches/gcc-4_7-branch/libgfortran/ChangeLog
    branches/gcc-4_7-branch/libgfortran/io/write_float.def

[Bug libfortran/59771] Cleanup handling of Gw.0 and Gw.0Ee format

[jvdelisle at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59771

--- Comment #7 from Jerry DeLisle <jvdelisle at gcc dot gnu.org> ---
Author: jvdelisle
Date: Sat Feb 15 16:55:19 2014
New Revision: 207804

URL: http://gcc.gnu.org/viewcvs?rev=207804&root=gcc&view=rev
Log:
2014-02-15  Jerry DeLisle  <jvdelisle@gcc.gnu>
        Dominique d'Humieres  <dominiq@lps.ens.fr>

    Backport from mainline
    PR libfortran/59771
    PR libfortran/59774
    PR libfortran/59836
    * gfortran.dg/fmt_g_1.f90: New test.
    * gfortran.dg/round_3.f08: New cases added.

Added:
    branches/gcc-4_7-branch/gcc/testsuite/gfortran.dg/fmt_g_1.f90
Modified:
    branches/gcc-4_7-branch/gcc/testsuite/ChangeLog
    branches/gcc-4_7-branch/gcc/testsuite/gfortran.dg/round_3.f08

[Bug libfortran/59771] Cleanup handling of Gw.0 and Gw.0Ee format

[jvdelisle at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59771

Jerry DeLisle <jvdelisle at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #8 from Jerry DeLisle <jvdelisle at gcc dot gnu.org> ---
Fixed on 4.8 and 4.7. Closing