[Bug target/59789] New: [4.9 Regression] ICE in in convert_move, at expr.c:333

[Bug target/59789] New: [4.9 Regression] ICE in in convert_move, at expr.c:333

[aivchenk at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59789

            Bug ID: 59789
           Summary: [4.9 Regression] ICE in in convert_move, at expr.c:333
           Product: gcc
           Version: 4.9.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: target
          Assignee: unassigned at gcc dot gnu.org
          Reporter: aivchenk at gmail dot com

Android build is currently broken due to this bug:

>gcc expr_ice.c -c   -O2 -fPIC -m32 -march=i686

expr_ice.c:9:13: internal compiler error: in convert_move, at expr.c:333
     __m128i bar  = _mm_set1_epi32(0);
             ^
0x73a66e convert_move(rtx_def*, rtx_def*, int)
        /export/users/aivchenk/src/gcc/gcc/expr.c:333
0x73dae5 store_expr(tree_node*, rtx_def*, int, bool)
        /export/users/aivchenk/src/gcc/gcc/expr.c:5389
0x73fbb9 expand_assignment(tree_node*, tree_node*, bool)
        /export/users/aivchenk/src/gcc/gcc/expr.c:5114
0x65f28d expand_gimple_stmt_1
        /export/users/aivchenk/src/gcc/gcc/cfgexpand.c:3213
0x65f28d expand_gimple_stmt
        /export/users/aivchenk/src/gcc/gcc/cfgexpand.c:3309
0x660f17 expand_gimple_basic_block
        /export/users/aivchenk/src/gcc/gcc/cfgexpand.c:5149
0x6637c9 gimple_expand_cfg
        /export/users/aivchenk/src/gcc/gcc/cfgexpand.c:5715
0x6637c9 execute
        /export/users/aivchenk/src/gcc/gcc/cfgexpand.c:5935
Please submit a full bug report,


>cat expr_ice.c
#include <stdint.h>
#include <emmintrin.h>

typedef void (*func_type)();
extern func_type f;

static void f1()
{
    __m128i bar  = _mm_set1_epi32(0);
    _mm_storel_epi64(&bar, bar);
}


void foo(void)
{
  f = f1;
}

[Bug target/59789] [4.9 Regression] ICE in in convert_move, at expr.c:333

[hjl.tools at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59789

--- Comment #1 from H.J. Lu <hjl.tools at gmail dot com> ---
The code is invalid since -march=i686 doesn't support SSE.
The older GCC issues:

In file included from /tmp/pr59789.c:2:0:
/usr/lib/gcc/x86_64-redhat-linux/4.8.2/include/emmintrin.h:31:3: error: #error
"SSE2 instruction set not enabled"
 # error "SSE2 instruction set not enabled"
   ^
/tmp/pr59789.c: In function ‘f1’:
/tmp/pr59789.c:9:5: error: unknown type name ‘__m128i’
     __m128i bar  = _mm_set1_epi32(0);
>From gcc-bugs-return-440226-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Mon Jan 13 15:34:16 2014
Return-Path: <gcc-bugs-return-440226-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 24766 invoked by alias); 13 Jan 2014 15:34:16 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 24734 invoked by uid 48); 13 Jan 2014 15:34:13 -0000
From: "martinwguy at gmail dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug bootstrap/59770] [4.9 Regression] bootstrap failure for arm-linux-gnueabi targeting armv4t
Date: Mon, 13 Jan 2014 15:34:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: bootstrap
X-Bugzilla-Version: 4.9.0
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: martinwguy at gmail dot com
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 4.9.0
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: cc
Message-ID: <bug-59770-4-evkNUWD3t9@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-59770-4@http.gcc.gnu.org/bugzilla/>
References: <bug-59770-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2014-01/txt/msg01368.txt.bz2
Content-length: 443

http://gcc.gnu.org/bugzilla/show_bug.cgi?idY770

Martin Guy <martinwguy at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martinwguy at gmail dot com

--- Comment #1 from Martin Guy <martinwguy at gmail dot com> ---
Duplicate of #59595 which also fails on armv5t host-built-target

[Bug target/59789] [4.9 Regression] ICE in in convert_move, at expr.c:333

[hjl.tools at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59789

H.J. Lu <hjl.tools at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2014-01-13
     Ever confirmed|0                           |1

[Bug target/59789] [4.9 Regression] ICE in in convert_move, at expr.c:333

[hjl.tools at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59789

H.J. Lu <hjl.tools at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hjl.tools at gmail dot com
   Target Milestone|---                         |4.9.0

[Bug target/59789] [4.9 Regression] ICE in in convert_move, at expr.c:333

[aivchenk at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59789

--- Comment #2 from Alexander Ivchenko <aivchenk at gmail dot com> ---
lets just say that my code is valid and I forgot to add "-msse2" :).


(In reply to H.J. Lu from comment #1)
> The code is invalid since -march=i686 doesn't support SSE.
> The older GCC issues:
> 
> In file included from /tmp/pr59789.c:2:0:
> /usr/lib/gcc/x86_64-redhat-linux/4.8.2/include/emmintrin.h:31:3: error:
> #error "SSE2 instruction set not enabled"
>  # error "SSE2 instruction set not enabled"
>    ^
> /tmp/pr59789.c: In function ‘f1’:
> /tmp/pr59789.c:9:5: error: unknown type name ‘__m128i’
>      __m128i bar  = _mm_set1_epi32(0);
>From gcc-bugs-return-440232-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Mon Jan 13 15:59:45 2014
Return-Path: <gcc-bugs-return-440232-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 7075 invoked by alias); 13 Jan 2014 15:59:45 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 7051 invoked by uid 48); 13 Jan 2014 15:59:42 -0000
From: "hjl.tools at gmail dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/59789] [4.9 Regression] ICE in in convert_move, at expr.c:333
Date: Mon, 13 Jan 2014 15:59:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: target
X-Bugzilla-Version: 4.9.0
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: hjl.tools at gmail dot com
X-Bugzilla-Status: NEW
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 4.9.0
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields:
Message-ID: <bug-59789-4-u6s2k049wA@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-59789-4@http.gcc.gnu.org/bugzilla/>
References: <bug-59789-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2014-01/txt/msg01374.txt.bz2
Content-length: 263

http://gcc.gnu.org/bugzilla/show_bug.cgi?idY789

--- Comment #3 from H.J. Lu <hjl.tools at gmail dot com> ---
(In reply to Alexander Ivchenko from comment #2)
> lets just say that my code is valid and I forgot to add "-msse2" :).
>

Does GCC ICE with -msse2?

[Bug target/59789] [4.9 Regression] ICE in in convert_move, at expr.c:333

[hjl.tools at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59789

H.J. Lu <hjl.tools at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tmsriram at google dot com

--- Comment #4 from H.J. Lu <hjl.tools at gmail dot com> ---
ICE without -msse2 is caused by r201039.

[Bug target/59789] [4.9 Regression] ICE in in convert_move, at expr.c:333

[hjl.tools at gmail dot com]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="UTF-8", Size: 4304 bytes --]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59789

--- Comment #5 from H.J. Lu <hjl.tools at gmail dot com> ---
A smaller testcase:

[hjl@gnu-6 gcc]$ cat /tmp/x.c
#pragma GCC push_options
#pragma GCC target("sse2")
typedef int __v4si __attribute__ ((__vector_size__ (16)));
typedef long long __m128i __attribute__ ((__vector_size__ (16),
__may_alias__));

extern __inline __m128i __attribute__((__gnu_inline__, __always_inline__,
__artificial__))
_mm_set_epi32 (int __q3, int __q2, int __q1, int __q0)
{
  return __extension__ (__m128i)(__v4si){ __q0, __q1, __q2, __q3 };
}
#pragma GCC pop_options

__m128i
f1(void)
{
  return _mm_set_epi32 (0, 0, 0, 0);
}
[hjl@gnu-6 gcc]$ ./xgcc -B./ -S /tmp/x.c -m32   -O2 -march=i686 
/tmp/x.c: In function ‘f1’:
/tmp/x.c:14:1: warning: SSE vector return without SSE enabled changes the ABI
[enabled by default]
 f1(void)
 ^
/tmp/x.c:7:1: error: inlining failed in call to always_inline ‘_mm_set_epi32’:
target specific option mismatch
 _mm_set_epi32 (int __q3, int __q2, int __q1, int __q0)
 ^
/tmp/x.c:16:24: error: called from here
   return _mm_set_epi32 (0, 0, 0, 0);
                        ^
/tmp/x.c:16:3: internal compiler error: in convert_move, at expr.c:333
   return _mm_set_epi32 (0, 0, 0, 0);
   ^
0x7da639 convert_move(rtx_def*, rtx_def*, int)
    /export/gnu/import/git/gcc/gcc/expr.c:333
0x7e8e77 store_expr(tree_node*, rtx_def*, int, bool)
    /export/gnu/import/git/gcc/gcc/expr.c:5389
0x7e787a expand_assignment(tree_node*, tree_node*, bool)
    /export/gnu/import/git/gcc/gcc/expr.c:5114
0x6e0645 expand_gimple_stmt_1
    /export/gnu/import/git/gcc/gcc/cfgexpand.c:3213
0x6e0a3f expand_gimple_stmt
    /export/gnu/import/git/gcc/gcc/cfgexpand.c:3309
0x6e6e58 expand_gimple_basic_block
    /export/gnu/import/git/gcc/gcc/cfgexpand.c:5149
0x6e88fc gimple_expand_cfg
    /export/gnu/import/git/gcc/gcc/cfgexpand.c:5715
0x6e8f76 execute
    /export/gnu/import/git/gcc/gcc/cfgexpand.c:5935
Please submit a full bug report,
with preprocessed source if appropriate.
Please include the complete backtrace with any bug report.
See <http://gcc.gnu.org/bugs.html> for instructions.
[hjl@gnu-6 gcc]$
>From gcc-bugs-return-440244-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Mon Jan 13 18:37:08 2014
Return-Path: <gcc-bugs-return-440244-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 1926 invoked by alias); 13 Jan 2014 18:37:07 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 1872 invoked by uid 48); 13 Jan 2014 18:37:03 -0000
From: "hjl.tools at gmail dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/59789] [4.9 Regression] ICE in in convert_move, at expr.c:333
Date: Mon, 13 Jan 2014 18:37:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: target
X-Bugzilla-Version: 4.9.0
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: hjl.tools at gmail dot com
X-Bugzilla-Status: NEW
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 4.9.0
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: attachments.created
Message-ID: <bug-59789-4-awrvctEFzi@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-59789-4@http.gcc.gnu.org/bugzilla/>
References: <bug-59789-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2014-01/txt/msg01386.txt.bz2
Content-length: 296

http://gcc.gnu.org/bugzilla/show_bug.cgi?idY789

--- Comment #6 from H.J. Lu <hjl.tools at gmail dot com> ---
Created attachment 31824
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id1824&actioníit
A patch

This is a patch based on

http://gcc.gnu.org/bugzilla/show_bug.cgi?idW698#c7

[Bug tree-optimization/59789] [4.9 Regression] ICE in in convert_move, at expr.c:333

[hjl at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59789

--- Comment #8 from hjl at gcc dot gnu.org <hjl at gcc dot gnu.org> ---
Author: hjl
Date: Mon Jan 20 21:08:26 2014
New Revision: 206858

URL: http://gcc.gnu.org/viewcvs?rev=206858&root=gcc&view=rev
Log:
Add type to DEFCIFCODE to describe the inline failure

Report inline error during early inlining if the inline failure is
CIF_FINAL_ERROR.

gcc/

    PR middle-end/59789
    * cgraph.c (cgraph_inline_failed_string): Add type to DEFCIFCODE.
    (cgraph_inline_failed_type): New function.
    * cgraph.h (DEFCIFCODE): Add type.
    (cgraph_inline_failed_type_t): New enum.
    (cgraph_inline_failed_type): New prototype.
    * cif-code.def: Add CIF_FINAL_NORMAL to OK, FUNCTION_NOT_CONSIDERED,
    FUNCTION_NOT_OPTIMIZED, REDEFINED_EXTERN_INLINE,
    FUNCTION_NOT_INLINE_CANDIDATE, LARGE_FUNCTION_GROWTH_LIMIT,
    LARGE_STACK_FRAME_GROWTH_LIMIT, MAX_INLINE_INSNS_SINGLE_LIMIT,
    MAX_INLINE_INSNS_AUTO_LIMIT, INLINE_UNIT_GROWTH_LIMIT,
    RECURSIVE_INLINING, UNLIKELY_CALL, NOT_DECLARED_INLINED,
    OPTIMIZING_FOR_SIZE, ORIGINALLY_INDIRECT_CALL,
    INDIRECT_UNKNOWN_CALL, USES_COMDAT_LOCAL. 
    Add CIF_FINAL_ERROR to UNSPECIFIED, BODY_NOT_AVAILABLE,
    FUNCTION_NOT_INLINABLE, OVERWRITABLE, MISMATCHED_ARGUMENTS,
    EH_PERSONALITY, NON_CALL_EXCEPTIONS, TARGET_OPTION_MISMATCH,
    OPTIMIZATION_MISMATCH.
    * tree-inline.c (expand_call_inline): Emit errors during
    early_inlining if cgraph_inline_failed_type returns
    CIF_FINAL_ERROR.

gcc/testsuite/

    PR middle-end/59789
    * gcc.target/i386/pr59789.c: New testcase.

Added:
    trunk/gcc/testsuite/gcc.target/i386/pr59789.c
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/cgraph.c
    trunk/gcc/cgraph.h
    trunk/gcc/cif-code.def
    trunk/gcc/testsuite/ChangeLog
    trunk/gcc/tree-inline.c

[Bug tree-optimization/59789] [4.9 Regression] ICE in in convert_move, at expr.c:333

[hjl.tools at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59789

H.J. Lu <hjl.tools at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #9 from H.J. Lu <hjl.tools at gmail dot com> ---
Fixed.