[Bug target/60207] Wrong TFmode check in construct_container

[Bug target/60207] Wrong TFmode check in construct_container

[ubizjak at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60207

--- Comment #1 from Uroš Bizjak <ubizjak at gmail dot com> ---
(In reply to H.J. Lu from comment #0)

> But we didn't remove mode == TFmode check in construct_container.

This check is benign. classify_argument will return:

    case TFmode:
      classes[0] = X86_64_SSE_CLASS;
      classes[1] = X86_64_SSEUP_CLASS;
      return 2;

and the check in construct_container is:

  if (n == 2
      && regclass[0] == X86_64_INTEGER_CLASS
      && regclass[1] == X86_64_INTEGER_CLASS
      && (mode == CDImode || mode == TImode || mode == TFmode)
      && intreg[0] + 1 == intreg[1])
    return gen_rtx_REG (mode, intreg[0]);

The above condition never triggers due to regclass checks.

So, you can remove TFmode check without harm. The patch is pre-approved for
mainline and release branches.
>From gcc-bugs-return-443627-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Sat Feb 15 09:45:36 2014
Return-Path: <gcc-bugs-return-443627-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 29918 invoked by alias); 15 Feb 2014 09:45:35 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 29873 invoked by uid 48); 15 Feb 2014 09:45:32 -0000
From: "rguenth at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug rtl-optimization/49847] [4.7/4.8/4.9 Regression] NULL deref in fold_rtx (prev_insn_cc0 == NULL)
Date: Sat, 15 Feb 2014 09:45:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: rtl-optimization
X-Bugzilla-Version: 4.7.0
X-Bugzilla-Keywords: build, ice-on-valid-code
X-Bugzilla-Severity: critical
X-Bugzilla-Who: rguenth at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Priority: P4
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 4.7.4
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: cc
Message-ID: <bug-49847-4-HRmyZ6nN4d@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-49847-4@http.gcc.gnu.org/bugzilla/>
References: <bug-49847-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2014-02/txt/msg01384.txt.bz2
Content-length: 660

http://gcc.gnu.org/bugzilla/show_bug.cgi?idI847

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|richard.guenther at gmail dot com  |rguenth at gcc dot gnu.org,
                   |                            |stevenb.gcc at gmail dot com

--- Comment #27 from Richard Biener <rguenth at gcc dot gnu.org> ---
Yeah, not sure how non-cc0 targets avoid this situation.  I wonder if there is
a suitable pre-reload pass to do such reloading (I'm not sure teaching reload
to do that is the best idea ...)

[Bug target/60207] Wrong TFmode check in construct_container

[hjl at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60207

--- Comment #3 from hjl at gcc dot gnu.org <hjl at gcc dot gnu.org> ---
Author: hjl
Date: Wed Feb 19 22:43:19 2014
New Revision: 207925

URL: http://gcc.gnu.org/viewcvs?rev=207925&root=gcc&view=rev
Log:
Remove TFmode check for X86_64_INTEGER_CLASS

    Backport from mainline
    PR target/60207
    * config/i386/i386.c (construct_container): Remove TFmode check
    for X86_64_INTEGER_CLASS.

Modified:
    branches/gcc-4_8-branch/gcc/ChangeLog
    branches/gcc-4_8-branch/gcc/config/i386/i386.c

[Bug target/60207] Wrong TFmode check in construct_container

[hjl at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60207

--- Comment #4 from hjl at gcc dot gnu.org <hjl at gcc dot gnu.org> ---
Author: hjl
Date: Wed Feb 19 22:45:34 2014
New Revision: 207926

URL: http://gcc.gnu.org/viewcvs?rev=207926&root=gcc&view=rev
Log:
Remove TFmode check for X86_64_INTEGER_CLASS

    Backport from mainline
    PR target/60207
    * config/i386/i386.c (construct_container): Remove TFmode check
    for X86_64_INTEGER_CLASS.

Modified:
    branches/gcc-4_7-branch/gcc/ChangeLog
    branches/gcc-4_7-branch/gcc/config/i386/i386.c

[Bug target/60207] Wrong TFmode check in construct_container

[hjl.tools at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60207

H.J. Lu <hjl.tools at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |FIXED
   Target Milestone|---                         |4.7.4

--- Comment #5 from H.J. Lu <hjl.tools at gmail dot com> ---
Fixed for 4.7.4, 4.8.3 and 4.9.0.