public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug libstdc++/60326] Incorrect type from std::make_unsigned<wchar_t>
       [not found] <bug-60326-4@http.gcc.gnu.org/bugzilla/>
@ 2014-02-24  3:54 ` kristian.spangsege at gmail dot com
  2014-02-24 10:07 ` redi at gcc dot gnu.org
                   ` (4 subsequent siblings)
  5 siblings, 0 replies; 6+ messages in thread
From: kristian.spangsege at gmail dot com @ 2014-02-24  3:54 UTC (permalink / raw)
  To: gcc-bugs

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60326

--- Comment #1 from Kristian Spangsege <kristian.spangsege at gmail dot com> ---
Oops, should have been:

Clang 3.4 with `libc++` does this on x86_64:

std::make_signed<wchar_t>::type --> int 
std::make_unsigned<wchar_t>::type --> unsigned


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Bug libstdc++/60326] Incorrect type from std::make_unsigned<wchar_t>
       [not found] <bug-60326-4@http.gcc.gnu.org/bugzilla/>
  2014-02-24  3:54 ` [Bug libstdc++/60326] Incorrect type from std::make_unsigned<wchar_t> kristian.spangsege at gmail dot com
@ 2014-02-24 10:07 ` redi at gcc dot gnu.org
  2014-05-15 12:31 ` redi at gcc dot gnu.org
                   ` (3 subsequent siblings)
  5 siblings, 0 replies; 6+ messages in thread
From: redi at gcc dot gnu.org @ 2014-02-24 10:07 UTC (permalink / raw)
  To: gcc-bugs

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60326

Jonathan Wakely <redi at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2014-02-24
     Ever confirmed|0                           |1

--- Comment #2 from Jonathan Wakely <redi at gcc dot gnu.org> ---
I think we're just missing wchar_t specializations, and also for char16_t and
char32_t

#include <type_traits>
using namespace std;
using wchar_signed = make_signed<wchar_t>::type;
using wchar_unsigned = make_unsigned<wchar_t>::type;
static_assert( !is_same<wchar_signed, wchar_unsigned>::value, "");
static_assert( !is_same<char16_t, make_signed<char16_t>::type>::value, "");
static_assert( !is_same<char32_t, make_signed<char32_t>::type>::value, "");


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Bug libstdc++/60326] Incorrect type from std::make_unsigned<wchar_t>
       [not found] <bug-60326-4@http.gcc.gnu.org/bugzilla/>
  2014-02-24  3:54 ` [Bug libstdc++/60326] Incorrect type from std::make_unsigned<wchar_t> kristian.spangsege at gmail dot com
  2014-02-24 10:07 ` redi at gcc dot gnu.org
@ 2014-05-15 12:31 ` redi at gcc dot gnu.org
  2014-05-15 12:33 ` redi at gcc dot gnu.org
                   ` (2 subsequent siblings)
  5 siblings, 0 replies; 6+ messages in thread
From: redi at gcc dot gnu.org @ 2014-05-15 12:31 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=60326

--- Comment #3 from Jonathan Wakely <redi at gcc dot gnu.org> ---
Author: redi
Date: Thu May 15 12:31:05 2014
New Revision: 210473

URL: http://gcc.gnu.org/viewcvs?rev=210473&root=gcc&view=rev
Log:
    PR libstdc++/60326
    * include/std/type_traits (__make_unsigned, __make_signed): Define
    specializations for wchar_t, char16_t and char32_t.
    * testsuite/20_util/make_signed/requirements/typedefs-4.cc: New.
    * testsuite/20_util/make_unsigned/requirements/typedefs-1.cc: Correct
    test for make_unsigned<volatile wchar_t>.
    * testsuite/20_util/make_unsigned/requirements/typedefs-2.cc:
    Likewise.
    * testsuite/20_util/declval/requirements/1_neg.cc: Adjust dg-error
    line number.
    * testsuite/20_util/make_signed/requirements/typedefs_neg.cc:
    Likewise.
    * testsuite/20_util/make_unsigned/requirements/typedefs_neg.cc:
    Likewise.

Added:
    trunk/libstdc++-v3/testsuite/20_util/make_signed/requirements/typedefs-4.cc
      - copied, changed from r210471,
trunk/libstdc++-v3/testsuite/20_util/declval/requirements/1_neg.cc
Modified:
    trunk/libstdc++-v3/ChangeLog
    trunk/libstdc++-v3/include/std/type_traits
    trunk/libstdc++-v3/testsuite/20_util/declval/requirements/1_neg.cc
   
trunk/libstdc++-v3/testsuite/20_util/make_signed/requirements/typedefs_neg.cc
   
trunk/libstdc++-v3/testsuite/20_util/make_unsigned/requirements/typedefs-1.cc
   
trunk/libstdc++-v3/testsuite/20_util/make_unsigned/requirements/typedefs-2.cc
   
trunk/libstdc++-v3/testsuite/20_util/make_unsigned/requirements/typedefs_neg.cc


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Bug libstdc++/60326] Incorrect type from std::make_unsigned<wchar_t>
       [not found] <bug-60326-4@http.gcc.gnu.org/bugzilla/>
                   ` (2 preceding siblings ...)
  2014-05-15 12:31 ` redi at gcc dot gnu.org
@ 2014-05-15 12:33 ` redi at gcc dot gnu.org
  2014-06-13 12:00 ` redi at gcc dot gnu.org
  2014-06-13 12:02 ` redi at gcc dot gnu.org
  5 siblings, 0 replies; 6+ messages in thread
From: redi at gcc dot gnu.org @ 2014-05-15 12:33 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=60326

--- Comment #4 from Jonathan Wakely <redi at gcc dot gnu.org> ---
Fixed on trunk so far


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Bug libstdc++/60326] Incorrect type from std::make_unsigned<wchar_t>
       [not found] <bug-60326-4@http.gcc.gnu.org/bugzilla/>
                   ` (3 preceding siblings ...)
  2014-05-15 12:33 ` redi at gcc dot gnu.org
@ 2014-06-13 12:00 ` redi at gcc dot gnu.org
  2014-06-13 12:02 ` redi at gcc dot gnu.org
  5 siblings, 0 replies; 6+ messages in thread
From: redi at gcc dot gnu.org @ 2014-06-13 12:00 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=60326

--- Comment #5 from Jonathan Wakely <redi at gcc dot gnu.org> ---
Author: redi
Date: Fri Jun 13 11:59:22 2014
New Revision: 211636

URL: https://gcc.gnu.org/viewcvs?rev=211636&root=gcc&view=rev
Log:
2014-06-13  Jonathan Wakely  <jwakely@redhat.com>

    Backport from mainline
    PR libstdc++/60326
    * include/std/type_traits (__make_unsigned, __make_signed): Define
    specializations for wchar_t, char16_t and char32_t.
    * testsuite/20_util/make_signed/requirements/typedefs-4.cc: New.
    * testsuite/20_util/make_unsigned/requirements/typedefs-1.cc: Correct
    test for make_unsigned<volatile wchar_t>.
    * testsuite/20_util/make_unsigned/requirements/typedefs-2.cc:
    Likewise.
    * testsuite/20_util/declval/requirements/1_neg.cc: Adjust dg-error
    line number.
    * testsuite/20_util/make_signed/requirements/typedefs_neg.cc:
    Likewise.
    * testsuite/20_util/make_unsigned/requirements/typedefs_neg.cc:
    Likewise.

    Backport from mainline
    PR libstdc++/61269
    * include/std/type_traits: Move include outside namespace std.
    * testsuite/20_util/declval/requirements/1_neg.cc: Adjust dg-error.
    * testsuite/20_util/make_signed/requirements/typedefs_neg.cc: Likewise.
    * testsuite/20_util/make_unsigned/requirements/typedefs_neg.cc:
    Likewise.

Added:
   
branches/gcc-4_9-branch/libstdc++-v3/testsuite/20_util/make_signed/requirements/typedefs-4.cc
      - copied, changed from r211602,
branches/gcc-4_9-branch/libstdc++-v3/testsuite/20_util/declval/requirements/1_neg.cc
Modified:
    branches/gcc-4_9-branch/libstdc++-v3/ChangeLog
    branches/gcc-4_9-branch/libstdc++-v3/include/std/type_traits
   
branches/gcc-4_9-branch/libstdc++-v3/testsuite/20_util/declval/requirements/1_neg.cc
   
branches/gcc-4_9-branch/libstdc++-v3/testsuite/20_util/make_signed/requirements/typedefs_neg.cc
   
branches/gcc-4_9-branch/libstdc++-v3/testsuite/20_util/make_unsigned/requirements/typedefs-1.cc
   
branches/gcc-4_9-branch/libstdc++-v3/testsuite/20_util/make_unsigned/requirements/typedefs-2.cc
   
branches/gcc-4_9-branch/libstdc++-v3/testsuite/20_util/make_unsigned/requirements/typedefs_neg.cc


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Bug libstdc++/60326] Incorrect type from std::make_unsigned<wchar_t>
       [not found] <bug-60326-4@http.gcc.gnu.org/bugzilla/>
                   ` (4 preceding siblings ...)
  2014-06-13 12:00 ` redi at gcc dot gnu.org
@ 2014-06-13 12:02 ` redi at gcc dot gnu.org
  5 siblings, 0 replies; 6+ messages in thread
From: redi at gcc dot gnu.org @ 2014-06-13 12:02 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=60326

Jonathan Wakely <redi at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED
   Target Milestone|---                         |4.9.1

--- Comment #6 from Jonathan Wakely <redi at gcc dot gnu.org> ---
Fixed for 4.9.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2014-06-13 12:02 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <bug-60326-4@http.gcc.gnu.org/bugzilla/>
2014-02-24  3:54 ` [Bug libstdc++/60326] Incorrect type from std::make_unsigned<wchar_t> kristian.spangsege at gmail dot com
2014-02-24 10:07 ` redi at gcc dot gnu.org
2014-05-15 12:31 ` redi at gcc dot gnu.org
2014-05-15 12:33 ` redi at gcc dot gnu.org
2014-06-13 12:00 ` redi at gcc dot gnu.org
2014-06-13 12:02 ` redi at gcc dot gnu.org

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).