[Bug target/62111] New: ICE when building Linux kernel for sh64

[Bug target/62111] New: ICE when building Linux kernel for sh64

[dhowells at redhat dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=62111

            Bug ID: 62111
           Summary: ICE when building Linux kernel for sh64
           Product: gcc
           Version: 4.9.1
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: target
          Assignee: unassigned at gcc dot gnu.org
          Reporter: dhowells at redhat dot com

Created attachment 33303
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=33303&action=edit
Reduced preprocessed source

When trying to build the kernel with an sh64 cross-compiler, I get the
following error:

  sh64-linux-gnu-gcc -Wp,-MD,arch/sh/kernel/.setup.o.d  -nostdinc -isystem
/usr/lib/gcc/sh64-linux-elf/4.9.1/include -I../arch/sh/include
-Iarch/sh/include/generated  -I../include -Iinclude -I../arch/sh/include/uapi
-Iarch/sh/include/generated/uapi -I../include/uapi -Iinclude/generated/uapi
-include ../include/linux/kconfig.h  -I../arch/sh/kernel -Iarch/sh/kernel
-D__KERNEL__ -m5-64media-nofpu -ml -Wa,-isa=shmedia -ffreestanding 
-I../arch/sh/include/cpu-sh5 -Iarch/sh/include/cpu-sh5 
-I../arch/sh/include/cpu-common -Iarch/sh/include/cpu-common 
-I../arch/sh/include/mach-common -Iarch/sh/include/mach-common -Wall -Wundef
-Wstrict-prototypes -Wno-trigraphs -fno-strict-aliasing -fno-common
-Werror-implicit-function-declaration -Wno-format-security -pipe
-m5-64media-nofpu -ml -Wa,-isa=shmedia -ffreestanding 
-I../arch/sh/include/cpu-sh5 -Iarch/sh/include/cpu-sh5 
-I../arch/sh/include/cpu-common -Iarch/sh/include/cpu-common 
-I../arch/sh/include/mach-common -Iarch/sh/include/mach-common
-fno-delete-null-pointer-checks -O2 --param=allow-store-data-races=0
-Wframe-larger-than=1024 -fno-stack-protector -Wno-unused-but-set-variable
-fno-omit-frame-pointer -fno-optimize-sibling-calls
-fno-var-tracking-assignments -Wdeclaration-after-statement -Wno-pointer-sign
-fno-strict-overflow -fconserve-stack -Werror=implicit-int
-Werror=strict-prototypes -Werror=date-time -DCC_HAVE_ASM_GOTO -Werror   
-D"KBUILD_STR(s)=#s" -D"KBUILD_BASENAME=KBUILD_STR(setup)" 
-D"KBUILD_MODNAME=KBUILD_STR(setup)" -c -o arch/sh/kernel/setup.o
../arch/sh/kernel/setup.c
../arch/sh/kernel/setup.c: In function 'setup_arch':
../arch/sh/kernel/setup.c:312:1: internal compiler error: in sh_print_operand,
at config/sh/sh.c:1359
 }
 ^
Please submit a full bug report,
with preprocessed source if appropriate.
See <http://bugzilla.redhat.com/bugzilla/> for instructions.
{standard input}: Assembler messages:
{standard input}:365: Warning: partial line at end of file ignored
Preprocessed source stored into /tmp/ccQ2JuUO.out file, please attach this to
your bugreport.

A reduced version of the preprocessed source is attached

[Bug target/62111] ICE when building Linux kernel for sh64

[dhowells at redhat dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=62111

--- Comment #1 from dhowells at redhat dot com <dhowells at redhat dot com> ---
The following command line is sufficient to reproduce the error:

sh64-linux-gnu-gcc -m5-64media-nofpu -ml -O2 -S -o testcase.o testcase.i

Adding -v to the command line:

Using built-in specs.
COLLECT_GCC=/usr/bin/sh64-linux-gnu-gcc
Target: sh64-linux-elf
Configured with: ../gcc-4.9.1-20140717/configure --bindir=/usr/bin
--build=x86_64-redhat-linux-gnu --datadir=/usr/share --disable-decimal-float
--disable-dependency-tracking --disable-gold --disable-libgomp
--disable-libmudflap --disable-libquadmath --disable-libssp --disable-nls
--disable-plugin --disable-shared --disable-silent-rules
--disable-sjlj-exceptions --disable-threads --enable-checking=
--enable-gnu-unique-object --enable-initfini-array --enable-languages=c,c++
--enable-linker-build-id --enable-nls --enable-obsolete --enable-targets=all
--exec-prefix=/usr --host=x86_64-redhat-linux-gnu --includedir=/usr/include
--infodir=/usr/share/info --libexecdir=/usr/libexec --localstatedir=/var
--mandir=/usr/share/man --prefix=/usr --program-prefix=sh64-linux-gnu-
--sbindir=/usr/sbin --sharedstatedir=/var/lib --sysconfdir=/etc
--target=sh64-linux-elf --with-bugurl=http://bugzilla.redhat.com/bugzilla/
--with-linker-hash-style=gnu --with-newlib
--with-sysroot=/usr/sh64-linux-gnu/sys-root --with-system-libunwind
--with-system-zlib --without-headers
--with-isl=/data/fedora/cross-gcc/gcc-4.9.1-20140717/isl-install
--with-cloog=/data/fedora/cross-gcc/gcc-4.9.1-20140717/cloog-install
--with-multilib-list=m5-32media,m5-32media-nofpu,m5-compact,m5-compact-nofpu,m5-64media,m5-64media-nofpu
Thread model: single
gcc version 4.9.1 20140717 (Red Hat Cross 4.9.1-2) (GCC) 
COLLECT_GCC_OPTIONS='-m5-64media-nofpu' '-ml' '-O2' '-S' '-o' 'setup.o' '-v'
 /usr/libexec/gcc/sh64-linux-elf/4.9.1/cc1 -fpreprocessed testcase-min.i -quiet
-dumpbase testcase-min.i -m5-64media-nofpu -ml -auxbase-strip setup.o -O2
-version -o setup.o
GNU C (GCC) version 4.9.1 20140717 (Red Hat Cross 4.9.1-2) (sh64-linux-elf)
        compiled by GNU C version 4.8.3 20140624 (Red Hat 4.8.3-1), GMP version
5.1.2, MPFR version 3.1.2, MPC version 1.0.1
GGC heuristics: --param ggc-min-expand=100 --param ggc-min-heapsize=131072
GNU C (GCC) version 4.9.1 20140717 (Red Hat Cross 4.9.1-2) (sh64-linux-elf)
        compiled by GNU C version 4.8.3 20140624 (Red Hat 4.8.3-1), GMP version
5.1.2, MPFR version 3.1.2, MPC version 1.0.1
GGC heuristics: --param ggc-min-expand=100 --param ggc-min-heapsize=131072
Compiler executable checksum: fb8656871dc1cbba0b3d802cd873a004
testcase-min.i: In function ‘setup_arch’:
testcase-min.i:20:1: internal compiler error: in sh_print_operand, at
config/sh/sh.c:1359
 }
 ^
Please submit a full bug report,
with preprocessed source if appropriate.
See <http://bugzilla.redhat.com/bugzilla/> for instructions.
Preprocessed source stored into /tmp/cctH44XH.out file, please attach this to
your bugreport.
>From gcc-bugs-return-458297-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Tue Aug 12 20:18:50 2014
Return-Path: <gcc-bugs-return-458297-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 21177 invoked by alias); 12 Aug 2014 20:18:49 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 21151 invoked by uid 48); 12 Aug 2014 20:18:43 -0000
From: "dhowells at redhat dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/62111] ICE when building Linux kernel for sh64
Date: Tue, 12 Aug 2014 20:18:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: target
X-Bugzilla-Version: 4.9.1
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: dhowells at redhat dot com
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields:
Message-ID: <bug-62111-4-nc8o7SH8E0@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-62111-4@http.gcc.gnu.org/bugzilla/>
References: <bug-62111-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2014-08/txt/msg00794.txt.bz2
Content-length: 267

https://gcc.gnu.org/bugzilla/show_bug.cgi?idb111

--- Comment #2 from dhowells at redhat dot com <dhowells at redhat dot com> ---
The binutils is based on the 2.24 branch, git commit
cab6c3ee9785f072a373afe31253df0451db93cf and was built targeting
sh64-linux-elf.

[Bug target/62111] ICE when building Linux kernel for sh64

[dhowells at redhat dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=62111

--- Comment #4 from dhowells at redhat dot com <dhowells at redhat dot com> ---
The compiler is gcc-4.9.1, dated 20140717, svnrev 212747.

One patch is applied - see bug 61844.

[Bug target/62111] ICE when building Linux kernel for sh64

[dhowells at redhat dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=62111

--- Comment #6 from dhowells at redhat dot com <dhowells at redhat dot com> ---
(In reply to Kazumoto Kojima from comment #5)
> ...
> 
> even though general_extend_operand doesn't permit (truncate (mem ...)).
> An easy workaround might be to disable truncate in general_extend_operand
> before reload.
> 
> --- gcc/config/sh/predicates.md.orig	2014-08-02 11:55:29.228875715 +0900
> +++ gcc/config/sh/predicates.md	2014-08-17 08:30:20.439326569 +0900
> ...

This does appear to fix the ICE's.  Unfortunately, it seems the kernel code has
bit-rotted too much to get all the way through building.
>From gcc-bugs-return-458689-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Mon Aug 18 09:32:17 2014
Return-Path: <gcc-bugs-return-458689-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 13202 invoked by alias); 18 Aug 2014 09:32:16 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 13125 invoked by uid 48); 18 Aug 2014 09:32:10 -0000
From: "dhowells at redhat dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/62111] ICE when building Linux kernel for sh64
Date: Mon, 18 Aug 2014 09:32:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: target
X-Bugzilla-Version: 4.9.1
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: dhowells at redhat dot com
X-Bugzilla-Status: NEW
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields:
Message-ID: <bug-62111-4-nzaVre8mK3@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-62111-4@http.gcc.gnu.org/bugzilla/>
References: <bug-62111-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2014-08/txt/msg01186.txt.bz2
Content-length: 605

https://gcc.gnu.org/bugzilla/show_bug.cgi?idb111

--- Comment #7 from dhowells at redhat dot com <dhowells at redhat dot com> ---
Having said that, if I use make -k, I can get this:

../drivers/scsi/sd.c: In function 'sd_init_command':
../drivers/scsi/sd.c:1139:1: error: unrecognizable insn:
 }
 ^
(insn 1335 1334 9 190 (set (reg/v:DI 336 [ sector ])
        (lshiftrt:DI (reg:DI 171 [ D.34693 ])
            (const_int -10 [0xfffffffffffffff6]))) ../drivers/scsi/sd.c:707 -1
     (nil))
../drivers/scsi/sd.c:1139:1: internal compiler error: in extract_insn, at
recog.c:2202

Do you want it reducing?

[Bug target/62111] ICE when building Linux kernel for sh64

[kkojima at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=62111

--- Comment #8 from Kazumoto Kojima <kkojima at gcc dot gnu.org> ---
A reduced test case is always welcome.

[Bug target/62111] ICE when building Linux kernel for sh64

[olegendo at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=62111

--- Comment #9 from Oleg Endo <olegendo at gcc dot gnu.org> ---
(In reply to dhowells@redhat.com from comment #7)
> Having said that, if I use make -k, I can get this:
> 
> ../drivers/scsi/sd.c: In function 'sd_init_command':
> ../drivers/scsi/sd.c:1139:1: error: unrecognizable insn:
>  }
>  ^
> (insn 1335 1334 9 190 (set (reg/v:DI 336 [ sector ])
>         (lshiftrt:DI (reg:DI 171 [ D.34693 ])
>             (const_int -10 [0xfffffffffffffff6]))) ../drivers/scsi/sd.c:707
> -1
>      (nil))
> ../drivers/scsi/sd.c:1139:1: internal compiler error: in extract_insn, at
> recog.c:2202
> 
> Do you want it reducing?

My first guess is that one of the commits for PR 54089 caused this, where I
forgot to handle SHmedia cases.  A reduced test case would help a lot indeed.

[Bug target/62111] ICE when building Linux kernel for sh64

[dhowells at redhat dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=62111

--- Comment #10 from dhowells at redhat dot com <dhowells at redhat dot com> ---
This is the reduced test case for comment 7:

extern void string_get_size(unsigned long long size);
void sd_read_capacity(unsigned long long capacity)
{
    string_get_size(capacity << -1);
}

[Bug target/62111] ICE when building Linux kernel for sh64

[segher at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=62111

Segher Boessenkool <segher at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |segher at gcc dot gnu.org

--- Comment #11 from Segher Boessenkool <segher at gcc dot gnu.org> ---
Re: #c7:

In sh.c, change "char amount[6]" to "signed char
amount[6]" -- does that help?

[Bug target/62111] ICE when building Linux kernel for sh64

[dhowells at redhat dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=62111

--- Comment #13 from dhowells at redhat dot com <dhowells at redhat dot com> ---
(In reply to Segher Boessenkool from comment #11)
> Re: #c7:
> 
> In sh.c, change "char amount[6]" to "signed char
> amount[6]" -- does that help?

That shouldn't make any difference to a compiler hosted on x86_64, as char is
signed there by default.  Did you mean change it to "unsigned char amount[6]"?

[Bug target/62111] ICE when building Linux kernel for sh64

[kkojima at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=62111

--- Comment #14 from Kazumoto Kojima <kkojima at gcc dot gnu.org> ---
Created attachment 33372
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=33372&action=edit
A possible patch

It seems that the ICE in #c7 came from the negative shift count.
I'm not sure that the patch is compatible with the behavior of
older sh64 compilers, though it might be not a bit deal because
the negative shift count causes the undefined behavior anyway.

[Bug target/62111] ICE when building Linux kernel for sh64

[dhowells at redhat dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=62111

--- Comment #15 from dhowells at redhat dot com <dhowells at redhat dot com> ---
That fixes the ICE.

[Bug target/62111] ICE when building Linux kernel for sh64

[kkojima at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=62111

--- Comment #16 from Kazumoto Kojima <kkojima at gcc dot gnu.org> ---
Author: kkojima
Date: Mon Aug 25 00:37:51 2014
New Revision: 214413

URL: https://gcc.gnu.org/viewcvs?rev=214413&root=gcc&view=rev
Log:
    PR target/62111
    * config/sh/predicates.md (general_extend_operand): Disable
    TRUNCATE before reload completes.


Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/config/sh/predicates.md

[Bug target/62111] ICE when building Linux kernel for sh64

[kkojima at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=62111

--- Comment #17 from Kazumoto Kojima <kkojima at gcc dot gnu.org> ---
I've filed a new PR62261 for the issue in #c7.

[Bug target/62111] ICE when building Linux kernel for sh64

[kkojima at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=62111

--- Comment #18 from Kazumoto Kojima <kkojima at gcc dot gnu.org> ---
Author: kkojima
Date: Tue Sep  2 22:28:29 2014
New Revision: 214832

URL: https://gcc.gnu.org/viewcvs?rev=214832&root=gcc&view=rev
Log:
    PR target/62111
    * config/sh/predicates.md (general_extend_operand): Disable
    TRUNCATE before reload completes.


Modified:
    branches/gcc-4_9-branch/gcc/ChangeLog
    branches/gcc-4_9-branch/gcc/config/sh/predicates.md

[Bug target/62111] ICE when building Linux kernel for sh64

[kkojima at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=62111

Kazumoto Kojima <kkojima at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #19 from Kazumoto Kojima <kkojima at gcc dot gnu.org> ---
Fixed.