[Bug sanitizer/62157] New: make distclean error when libsanitizer is configured not to build 'tsan'

[Bug sanitizer/62157] New: make distclean error when libsanitizer is configured not to build 'tsan'

[Explorer09 at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=62157

            Bug ID: 62157
           Summary: make distclean error when libsanitizer is configured
                    not to build 'tsan'
           Product: gcc
           Version: 4.9.1
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: sanitizer
          Assignee: unassigned at gcc dot gnu.org
          Reporter: Explorer09 at gmail dot com
                CC: dodji at gcc dot gnu.org, dvyukov at gcc dot gnu.org,
                    jakub at gcc dot gnu.org, kcc at gcc dot gnu.org

Tested on GCC 4.9.1. (Host OS is Ubuntu 12.04.5 32-bit)

To reproduce:
1. Have a 32-bit operating system (or something that makes
ac_cv_sizeof_void_p!=8 )
2. mkdir libsanitizer-build ; cd libsanitizer-build
3. ../gcc-4.9.1/libsanitizer/configure --disable-multilib
(I know libsanitizer isn't meant to be configured this way, but I do this just
to demonstrate the error.)
Now notice that tsan/Makefile won't be generated.
4. make distclean

Actual result is something like this:
--------------
Making distclean in tsan
/bin/bash: line 26: cd: tsan: No such file or directory
make[2]: *** [distclean-recursive] Error 1
make[2]: Leaving directory
`/home/explorer/toolchain/gcc-build/i486-pc-linux-gnu/libsanitizer'
make[1]: *** [distclean-target-libsanitizer] Error 1
make[1]: Leaving directory `/home/explorer/toolchain/gcc-build'
make: *** [do-distclean] Error 2
--------------

I have to use "make -k distclean" to workaround problem like this when building
a cross-GCC.

[Bug sanitizer/62157] make distclean error when libsanitizer is configured not to build 'tsan'

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=62157

--- Comment #1 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Seems like automake bug to me, all this DIST_SUBDIRS vs. SUBDIRS and
am__recursive_targets stuff comes from it.

[Bug sanitizer/62157] make distclean error when libsanitizer is configured not to build 'tsan'

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=62157

--- Comment #2 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Though, of course, distclean doesn't make much sense when building in a
separate build directory, just removing the whole build directory is the right
distclean.

[Bug sanitizer/62157] make distclean error when libsanitizer is configured not to build 'tsan'

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=62157

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |antony at cosmologist dot info

--- Comment #3 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
*** Bug 100987 has been marked as a duplicate of this bug. ***

[Bug sanitizer/62157] make distclean error when libsanitizer is configured not to build 'tsan'

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=62157

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
     Ever confirmed|0                           |1
             Status|UNCONFIRMED                 |ASSIGNED
           Assignee|unassigned at gcc dot gnu.org      |pinskia at gcc dot gnu.org
   Last reconfirmed|                            |2021-11-27

--- Comment #4 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
I have a patch.

[Bug sanitizer/62157] make distclean error when libsanitizer is configured not to build 'tsan'

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=62157

--- Comment #5 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
From:
https://www.gnu.org/software/automake/manual/html_node/SUBDIRS-vs-DIST_005fSUBDIRS.html

If SUBDIRS contains AC_SUBST variables, DIST_SUBDIRS will not be defined
correctly because Automake does not know the possible values of these
variables. In this case DIST_SUBDIRS needs to be defined manually.

And from
https://www.gnu.org/software/automake/manual/html_node/Unconfigured-Subdirectories.html

For instance, if you define SUBDIRS conditionally using AC_SUBST and do not
define DIST_SUBDIRS explicitly, it will be default to ‘$(SUBDIRS)’; another
possibility is to force DIST_SUBDIRS = $(SUBDIRS).

[Bug sanitizer/62157] make distclean error when libsanitizer is configured not to build 'tsan'

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=62157

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch
                URL|                            |https://gcc.gnu.org/piperma
                   |                            |il/gcc-patches/2021-Novembe
                   |                            |r/585590.html

--- Comment #6 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Patch submitted:
https://gcc.gnu.org/pipermail/gcc-patches/2021-November/585590.html

[Bug sanitizer/62157] make distclean error when libsanitizer is configured not to build 'tsan'

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=62157

--- Comment #7 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The trunk branch has been updated by Andrew Pinski <pinskia@gcc.gnu.org>:

https://gcc.gnu.org/g:32377c101934477e3d27fec9c6a22f1c97ccf730

commit r12-5566-g32377c101934477e3d27fec9c6a22f1c97ccf730
Author: Andrew Pinski <apinski@marvell.com>
Date:   Sun Nov 28 01:14:59 2021 +0000

    Fix PR 62157: disclean in libsanitizer not working

    So what is happening is DIST_SUBDIRS contains the conditional
    directories which is wrong, so we need to force DIST_SUBDIRS
    to be the same as SUBDIRS as recommened by the automake manual.

    OK? Bootstrapped and tested on x86_64-linux-gnu with no regressions.
    Also now make distclean works inside libsanitizer directory.

    libsanitizer/ChangeLog:

            PR sanitizer/62157
            * Makefile.am: Force DIST_SUBDIRS to be SUBDIRS.
            * Makefile.in: Regenerate.
            * asan/Makefile.in: Likewise.
            * hwasan/Makefile.in: Likewise.
            * interception/Makefile.in: Likewise.
            * libbacktrace/Makefile.in: Likewise.
            * lsan/Makefile.in: Likewise.
            * sanitizer_common/Makefile.in: Likewise.
            * tsan/Makefile.in: Likewise.
            * ubsan/Makefile.in: Likewise.

[Bug sanitizer/62157] make distclean error when libsanitizer is configured not to build 'tsan'

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=62157

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
   Target Milestone|---                         |12.0
             Status|ASSIGNED                    |RESOLVED

--- Comment #8 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Fixed.