public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug c++/63164] unnecessary calls to __dynamic_cast
       [not found] <bug-63164-4@http.gcc.gnu.org/bugzilla/>
@ 2021-05-26 21:08 ` glisse at gcc dot gnu.org
  2022-04-28 14:57 ` avi at scylladb dot com
                   ` (4 subsequent siblings)
  5 siblings, 0 replies; 6+ messages in thread
From: glisse at gcc dot gnu.org @ 2021-05-26 21:08 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63164

Marc Glisse <glisse at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Last reconfirmed|                            |2021-05-26
             Status|UNCONFIRMED                 |NEW
     Ever confirmed|0                           |1

--- Comment #2 from Marc Glisse <glisse at gcc dot gnu.org> ---
I was going to file exactly the same RFE for dynamic_cast and final types
(preferably it should also work if 'final' is only detected by LTO, but that
shouldn't block an easier front-end patch), so confirmed.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Bug c++/63164] unnecessary calls to __dynamic_cast
       [not found] <bug-63164-4@http.gcc.gnu.org/bugzilla/>
  2021-05-26 21:08 ` [Bug c++/63164] unnecessary calls to __dynamic_cast glisse at gcc dot gnu.org
@ 2022-04-28 14:57 ` avi at scylladb dot com
  2022-04-28 14:58 ` avi at scylladb dot com
                   ` (3 subsequent siblings)
  5 siblings, 0 replies; 6+ messages in thread
From: avi at scylladb dot com @ 2022-04-28 14:57 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63164

--- Comment #3 from Avi Kivity <avi at scylladb dot com> ---
I have something like this:

│     2680  future<> system_keyspace_make(distributed<replica::database>&
dist_db, distributed<service::storage_service>& dist_ss,
sharded<gms::gossiper>& dist_gossiper, db::config& cfg) {               │
│     2681      register_virtual_tables(dist_db, dist_ss, dist_gossiper, cfg);  
...
                                                                               
                                        │
│     2687      for (auto&& table : system_keyspace::all_tables(db_config)) {   

...

│     2695              co_await db.create_keyspace(ksm,
dist_ss.local().get_erm_factory(), true,
replica::database::system_keyspace::yes);   


And I see a crash as if the std::vector returned by all_tables() is not
persisted. This worked in previous gcc versions and works in clang.

I don't now what the standard says, but it really should persist temporaries in
range for that contains a suspension point, or a lot of buggy code will be
written.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Bug c++/63164] unnecessary calls to __dynamic_cast
       [not found] <bug-63164-4@http.gcc.gnu.org/bugzilla/>
  2021-05-26 21:08 ` [Bug c++/63164] unnecessary calls to __dynamic_cast glisse at gcc dot gnu.org
  2022-04-28 14:57 ` avi at scylladb dot com
@ 2022-04-28 14:58 ` avi at scylladb dot com
  2022-04-28 17:30 ` redi at gcc dot gnu.org
                   ` (2 subsequent siblings)
  5 siblings, 0 replies; 6+ messages in thread
From: avi at scylladb dot com @ 2022-04-28 14:58 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63164

--- Comment #4 from Avi Kivity <avi at scylladb dot com> ---
Oops, last comment intended for a separate bug. Curse the bug list thing.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Bug c++/63164] unnecessary calls to __dynamic_cast
       [not found] <bug-63164-4@http.gcc.gnu.org/bugzilla/>
                   ` (2 preceding siblings ...)
  2022-04-28 14:58 ` avi at scylladb dot com
@ 2022-04-28 17:30 ` redi at gcc dot gnu.org
  2022-04-28 17:33 ` avi at scylladb dot com
  2024-02-08  0:05 ` pinskia at gcc dot gnu.org
  5 siblings, 0 replies; 6+ messages in thread
From: redi at gcc dot gnu.org @ 2022-04-28 17:30 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63164

--- Comment #5 from Jonathan Wakely <redi at gcc dot gnu.org> ---
Avi, in the BZ Preferences you can set "After changing a bug" to "Show the
updated bug" instead of jumping to the next one in the list.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Bug c++/63164] unnecessary calls to __dynamic_cast
       [not found] <bug-63164-4@http.gcc.gnu.org/bugzilla/>
                   ` (3 preceding siblings ...)
  2022-04-28 17:30 ` redi at gcc dot gnu.org
@ 2022-04-28 17:33 ` avi at scylladb dot com
  2024-02-08  0:05 ` pinskia at gcc dot gnu.org
  5 siblings, 0 replies; 6+ messages in thread
From: avi at scylladb dot com @ 2022-04-28 17:33 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63164

--- Comment #6 from Avi Kivity <avi at scylladb dot com> ---
I already owe you many beers, but this one is special.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Bug c++/63164] unnecessary calls to __dynamic_cast
       [not found] <bug-63164-4@http.gcc.gnu.org/bugzilla/>
                   ` (4 preceding siblings ...)
  2022-04-28 17:33 ` avi at scylladb dot com
@ 2024-02-08  0:05 ` pinskia at gcc dot gnu.org
  5 siblings, 0 replies; 6+ messages in thread
From: pinskia at gcc dot gnu.org @ 2024-02-08  0:05 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63164

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |janschultke at googlemail dot com

--- Comment #7 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
*** Bug 113821 has been marked as a duplicate of this bug. ***

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2024-02-08  0:05 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <bug-63164-4@http.gcc.gnu.org/bugzilla/>
2021-05-26 21:08 ` [Bug c++/63164] unnecessary calls to __dynamic_cast glisse at gcc dot gnu.org
2022-04-28 14:57 ` avi at scylladb dot com
2022-04-28 14:58 ` avi at scylladb dot com
2022-04-28 17:30 ` redi at gcc dot gnu.org
2022-04-28 17:33 ` avi at scylladb dot com
2024-02-08  0:05 ` pinskia at gcc dot gnu.org

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).