[Bug bootstrap/63188] New: [5 Regression] r214954 breaks bootstrap on x86_64-apple-darwin13

[Bug bootstrap/63188] New: [5 Regression] r214954 breaks bootstrap on x86_64-apple-darwin13

[dominiq at lps dot ens.fr]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63188

            Bug ID: 63188
           Summary: [5 Regression] r214954 breaks bootstrap on
                    x86_64-apple-darwin13
           Product: gcc
           Version: 5.0
            Status: UNCONFIRMED
          Severity: blocker
          Priority: P3
         Component: bootstrap
          Assignee: unassigned at gcc dot gnu.org
          Reporter: dominiq at lps dot ens.fr
                CC: iains at gcc dot gnu.org, jsm28 at gcc dot gnu.org
              Host: x86_64-apple-darwin13
            Target: x86_64-apple-darwin13
             Build: x86_64-apple-darwin13

Revision r214954 breaks bootstrap on x86_64-apple-darwin13:

g++ -c  -DIN_GCC_FRONTEND -DIN_GCC_FRONTEND -g  -DIN_GCC    -fno-exceptions
-fno-rtti -fasynchronous-unwind-tables -W -Wall -Wno-narrowing -Wwrite-strings
-Wcast-qual -Wno-format -Wmissing-format-attribute -Woverloaded-virtual
-pedantic -Wno-long-long -Wno-variadic-macros -Wno-overlength-strings
-fno-common  -DHAVE_CONFIG_H -I. -Ic-family -I../../work/gcc
-I../../work/gcc/c-family -I../../work/gcc/../include -I./../intl
-I../../work/gcc/../libcpp/include -I/opt/mp/include 
-I../../work/gcc/../libdecnumber -I../../work/gcc/../libdecnumber/dpd
-I../libdecnumber -I../../work/gcc/../libbacktrace -DCLOOG_INT_GMP 
-DCLOOG_INT_GMP -I/opt/mp/include  -o c-family/c-cppbuiltin.o -MT
c-family/c-cppbuiltin.o -MMD -MP -MF c-family/.deps/c-cppbuiltin.TPo
../../work/gcc/c-family/c-cppbuiltin.c
../../work/gcc/c-family/c-cppbuiltin.c: In function 'void
c_cpp_builtins(cpp_reader*)':
../../work/gcc/c-family/c-cppbuiltin.c:972:25: error: expected
primary-expression before ',' token
      INIT_SECTION_ASM_OP, 1);
                         ^
INIT_SECTION_ASM_OP is defined in gcc/config/darwin.h:

#undef  INIT_SECTION_ASM_OP
#define INIT_SECTION_ASM_OP

[Bug bootstrap/63188] [5 Regression] r214954 breaks bootstrap on x86_64-apple-darwin13

[dominiq at lps dot ens.fr]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63188

Dominique d'Humieres <dominiq at lps dot ens.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2014-09-05
     Ever confirmed|0                           |1

--- Comment #1 from Dominique d'Humieres <dominiq at lps dot ens.fr> ---
If I remove the line

#define INIT_SECTION_ASM_OP

in gcc/config/darwin.h, bootstrap fails at

/bin/sh ../../../../work/libgcc/../mkinstalldirs i386
/opt/gcc/build_w/./gcc/xgcc -B/opt/gcc/build_w/./gcc/
-B/opt/gcc/gcc4.10w/x86_64-apple-darwin13.3.0/bin/
-B/opt/gcc/gcc4.10w/x86_64-apple-darwin13.3.0/lib/ -isystem
/opt/gcc/gcc4.10w/x86_64-apple-darwin13.3.0/include -isystem
/opt/gcc/gcc4.10w/x86_64-apple-darwin13.3.0/sys-include    -O2  -g -O2 -DIN_GCC
   -W -Wall -Wno-narrowing -Wwrite-strings -Wcast-qual -Wno-format
-Wstrict-prototypes -Wmissing-prototypes -Wold-style-definition  -isystem
./include   -pipe -fno-common -g -DIN_LIBGCC2 -fbuilding-libgcc
-fno-stack-protector  -dynamiclib -nodefaultlibs -install_name
/opt/gcc/gcc4.10w/lib/libgcc_s.1.dylib -single_module -o i386/libgcc_s.dylib
-Wl,-exported_symbols_list,libgcc.map -compatibility_version 1 -current_version
1.0 -g -O2 -m32 -B./ _muldi3_s.o _negdi2_s.o _lshrdi3_s.o _ashldi3_s.o
_ashrdi3_s.o _cmpdi2_s.o _ucmpdi2_s.o _clear_cache_s.o _trampoline_s.o
__main_s.o _absvsi2_s.o _absvdi2_s.o _addvsi3_s.o _addvdi3_s.o _subvsi3_s.o
_subvdi3_s.o _mulvsi3_s.o _mulvdi3_s.o _negvsi2_s.o _negvdi2_s.o _ctors_s.o
_ffssi2_s.o _ffsdi2_s.o _clz_s.o _clzsi2_s.o _clzdi2_s.o _ctzsi2_s.o
_ctzdi2_s.o _popcount_tab_s.o _popcountsi2_s.o _popcountdi2_s.o _paritysi2_s.o
_paritydi2_s.o _powisf2_s.o _powidf2_s.o _powixf2_s.o _powitf2_s.o _mulsc3_s.o
_muldc3_s.o _mulxc3_s.o _multc3_s.o _divsc3_s.o _divdc3_s.o _divxc3_s.o
_divtc3_s.o _bswapsi2_s.o _bswapdi2_s.o _clrsbsi2_s.o _clrsbdi2_s.o
_fixunssfsi_s.o _fixunsdfsi_s.o _fixunsxfsi_s.o _fixsfdi_s.o _fixdfdi_s.o
_fixxfdi_s.o _fixunssfdi_s.o _fixunsdfdi_s.o _fixunsxfdi_s.o _floatdisf_s.o
_floatdidf_s.o _floatdixf_s.o _floatundisf_s.o _floatundidf_s.o
_floatundixf_s.o _fixsfti_s.o _fixdfti_s.o _fixxfti_s.o _fixtfti_s.o
_fixunssfti_s.o _fixunsdfti_s.o _fixunsxfti_s.o _fixunstfti_s.o _floattisf_s.o
_floattidf_s.o _floattixf_s.o _floattitf_s.o _floatuntisf_s.o _floatuntidf_s.o
_floatuntixf_s.o _floatuntitf_s.o _divdi3_s.o _moddi3_s.o _udivdi3_s.o
_umoddi3_s.o _udiv_w_sdiv_s.o _udivmoddi4_s.o darwin-64_s.o cpuinfo_s.o
tf-signs_s.o sfp-exceptions_s.o addtf3_s.o divtf3_s.o eqtf2_s.o getf2_s.o
letf2_s.o multf3_s.o negtf2_s.o subtf3_s.o unordtf2_s.o fixtfsi_s.o
fixunstfsi_s.o floatsitf_s.o floatunsitf_s.o fixtfdi_s.o fixunstfdi_s.o
floatditf_s.o floatunditf_s.o extendsftf2_s.o extenddftf2_s.o extendxftf2_s.o
trunctfsf2_s.o trunctfdf2_s.o trunctfxf2_s.o enable-execute-stack_s.o
unwind-dw2_s.o unwind-dw2-fde-darwin_s.o unwind-sjlj_s.o unwind-c_s.o
emutls_s.o libgcc.a -lc
ld: warning: could not create compact unwind for __Unwind_RaiseException: does
not use EBP or ESP based frame
ld: warning: could not create compact unwind for __Unwind_ForcedUnwind: does
not use EBP or ESP based frame
ld: warning: could not create compact unwind for __Unwind_Resume: does not use
EBP or ESP based frame
ld: warning: could not create compact unwind for __Unwind_Resume_or_Rethrow:
does not use EBP or ESP based frame
Undefined symbols for architecture i386:
  "___EH_FRAME_BEGIN__", referenced from:
      ___do_global_dtors in __main_s.o
      ___do_global_ctors in __main_s.o
ld: symbol(s) not found for architecture i386
collect2: error: ld returned 1 exit status
make[5]: *** [libgcc_s.dylib] Error 1
make[5]: Leaving directory
`/opt/gcc/build_w/x86_64-apple-darwin13.3.0/i386/libgcc'
make[4]: *** [multi-do] Error 1
make[4]: Leaving directory `/opt/gcc/build_w/x86_64-apple-darwin13.3.0/libgcc'
make[3]: *** [all-multi] Error 2
make[3]: Leaving directory `/opt/gcc/build_w/x86_64-apple-darwin13.3.0/libgcc'
make[2]: *** [all-stage1-target-libgcc] Error 2
make[2]: Leaving directory `/opt/gcc/build_w'
make[1]: *** [stage1-bubble] Error 2
make[1]: Leaving directory `/opt/gcc/build_w'
make: *** [all] Error 2

[Bug bootstrap/63188] [5 Regression] r214954 breaks bootstrap on x86_64-apple-darwin13

[joseph at codesourcery dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63188

--- Comment #2 from joseph at codesourcery dot com <joseph at codesourcery dot com> ---
INIT_SECTION_ASM_OP is meant to be a string constant, not empty.  Try 
defining it to "".  I suppose the cases in libgcc that actually use the 
string constant value inside asm, rather than just testing whether it's 
defined, don't get used for Darwin?

[Bug bootstrap/63188] [5 Regression] r214954 breaks bootstrap on x86_64-apple-darwin13

[dominiq at lps dot ens.fr]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63188

--- Comment #3 from Dominique d'Humieres <dominiq at lps dot ens.fr> ---
> INIT_SECTION_ASM_OP is meant to be a string constant, not empty.  Try 
> defining it to "".  I suppose the cases in libgcc that actually use the 
> string constant value inside asm, rather than just testing whether it's 
> defined, don't get used for Darwin?

See comment 1.

[Bug bootstrap/63188] [5 Regression] r214954 breaks bootstrap on x86_64-apple-darwin13

[joseph at codesourcery dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63188

--- Comment #4 from joseph at codesourcery dot com <joseph at codesourcery dot com> ---
On Fri, 5 Sep 2014, dominiq at lps dot ens.fr wrote:

> > INIT_SECTION_ASM_OP is meant to be a string constant, not empty.  Try 
> > defining it to "".  I suppose the cases in libgcc that actually use the 
> > string constant value inside asm, rather than just testing whether it's 
> > defined, don't get used for Darwin?
> 
> See comment 1.

That's about undefining it.  I suggested keeping it defined, but changing 
the definition from empty to "".  You should, however, examine the code 
paths used in libgcc to convince yourself that 
__LIBGCC_INIT_SECTION_ASM_OP__ does not actually get used as an asm 
argument on Darwin (either directly or via CRT_CALL_STATIC_FUNCTION) - 
though if it did get used, I'd have expected you to have got syntax errors 
from asm () before my patch.  (As far as I know, asm () is not valid 
syntax anywhere.)

[Bug bootstrap/63188] [5 Regression] r214954 breaks bootstrap on x86_64-apple-darwin13

[dominiq at lps dot ens.fr]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63188

--- Comment #6 from Dominique d'Humieres <dominiq at lps dot ens.fr> ---
testing finished without regression.

[Bug bootstrap/63188] [5 Regression] r214954 breaks bootstrap on x86_64-apple-darwin13

[mikestump at comcast dot net]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63188

Mike Stump <mikestump at comcast dot net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mikestump at comcast dot net

--- Comment #7 from Mike Stump <mikestump at comcast dot net> ---
Ok.

[Bug bootstrap/63188] [5 Regression] r214954 breaks bootstrap on x86_64-apple-darwin13

[mrs at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63188

--- Comment #8 from mrs at gcc dot gnu.org <mrs at gcc dot gnu.org> ---
Author: mrs
Date: Sat Sep  6 05:17:10 2014
New Revision: 214983

URL: https://gcc.gnu.org/viewcvs?rev=214983&root=gcc&view=rev
Log:
2014-09-05  Dominique Dhumieres  <dominiq@lps.ens.fr>

    PR target/63188
    * config/darwin.h (INIT_SECTION_ASM_OP): Define to "".
    * config/pa/pa64-hpux.h (INIT_SECTION_ASM_OP): Likewise.

Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/config/darwin.h
    trunk/gcc/config/pa/pa64-hpux.h

[Bug bootstrap/63188] [5 Regression] r214954 breaks bootstrap on x86_64-apple-darwin13

[dominiq at lps dot ens.fr]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63188

Dominique d'Humieres <dominiq at lps dot ens.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #9 from Dominique d'Humieres <dominiq at lps dot ens.fr> ---
Thanks for the commit. Closing as FIXED.

[Bug bootstrap/63188] [5 Regression] r214954 breaks bootstrap on x86_64-apple-darwin13

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63188

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |5.0